Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp4889847rwi; Mon, 17 Oct 2022 12:11:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6dBiALailKeWBSaftKtnNDtgCpTXSFVsaQX/BXqzFE4FJr4tH1Sbbje1jmJ1A1CVV2LPdV X-Received: by 2002:a17:907:1c86:b0:78d:b8dd:4826 with SMTP id nb6-20020a1709071c8600b0078db8dd4826mr9920208ejc.492.1666033890589; Mon, 17 Oct 2022 12:11:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666033890; cv=none; d=google.com; s=arc-20160816; b=cBER6k7k5zmb1DV6WwfQdMNA9DclQnNtjDOKh4f/vSH5f+ykdhD0/NaHPOorHBPc5O GoGmcYoD/TL5Pf5TGLvIX2oO9B0Rh9r/V25jClZ0eZ7NeAwtmVMu0dWgo74CZALk2UZp 9CV8BAXsdOVOJh1oyNxRYwPEJ44MUD3gYbHJAVptxGz8YgOFQArCObl5sZlQkrULhq0t u+Li2O1QasmGReWbWzgdMDH3+jTMmBrvMstiXB7NNM5UxQneg8TD3AOk/POVp7AfUEut 6l4i21JO3+RiTEKWvFn7+O5lkyX1lrThiV7iTdcR40M3t8ysLCj61nKIXYIN8mn4XTF9 E+cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=lq1ryJcl968Ik5HB0Yb2jD+Gw/+EidzY3ld4yzCYtK0=; b=mqbdWyqoeU4lJclm6O2v3iy7Pf5Ykv+zjK839IkQ2RprIZzb3J2pFCzxzFwvlGvDJe awG4n+Kg+AQhiHA24UDwGweVMUBievcQ02NV5HNHWNH5v8QDzAB+RaFpYPzC9OjupnIA /z+Xl+LQ9h8sNlm6LkRYNRtdBdwajnxx/eAJ85MMsfusqTk7x0mzScK//e0OYzvX9MQv FwLoY2yDyAj3bfJfGEbKE5jbfG/UhCp3SNJkoB0WM0T0kv/5aBliAebl3dUGGS6Og3qa zXyeofDtuDHCEvOxiXrR9h33VnYpyMSH0rH1fW90wouBdYUt6+2lo0DZ/tYTyhP3vyXz I50Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toxicpanda-com.20210112.gappssmtp.com header.s=20210112 header.b=f+VWY5js; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ht8-20020a170907608800b0078356aaeb63si10522004ejc.288.2022.10.17.12.11.05; Mon, 17 Oct 2022 12:11:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@toxicpanda-com.20210112.gappssmtp.com header.s=20210112 header.b=f+VWY5js; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229738AbiJQSXd (ORCPT + 99 others); Mon, 17 Oct 2022 14:23:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230087AbiJQSX3 (ORCPT ); Mon, 17 Oct 2022 14:23:29 -0400 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44A387392F for ; Mon, 17 Oct 2022 11:23:27 -0700 (PDT) Received: by mail-qk1-x733.google.com with SMTP id d13so7183688qko.5 for ; Mon, 17 Oct 2022 11:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lq1ryJcl968Ik5HB0Yb2jD+Gw/+EidzY3ld4yzCYtK0=; b=f+VWY5jsCcdoOqgQcMcNiyPnoQ62YcwD9UWqprttX5m8USSofE9ikd46EItFEN6AOB sGj9EF9Zjar0N27Oj9JDUqU9xXAzIMLeMILtXdr4JQGbYCqeNjU008EMbUykXbMhem94 foLhAEEt5i6FYyQ38Tu/rf7gVsuQoharx7sMB/650Tv7KJKe79HQenR9dClgWECShpDe StTmLSf3iQNSBb7jzViCrwnIyNdsD1BErmT/Q+0bWUeAW5TMOLc50OuFyvJUZTKstB5v GpKFZKWXhX4T3OchBhUUFFo3WR+IAEDZ7cuRE+5+lYMRNBnEIAOhkccA47cvSsqjRSDG 4Few== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lq1ryJcl968Ik5HB0Yb2jD+Gw/+EidzY3ld4yzCYtK0=; b=6AEgxEg61kcHWZyaaVUhGb3PD5v6T67gIHYtwhjB1O1TqWD6pq0/M+ExHPu9/YuXY7 FQoHQYopnr+Wls/DjN/rDu19PG+SVX2cnNETKGSg8y28Djc0OWjUzOz935NGX7ClLpWn aZVTnZEwdDwyXi07pnAYvEqUy1k9/UzTwqXccVIPod9TTRvh9DoF6N3QQ1WPVhy3dhG7 D/9B/GE/iUG51prHowC44KcKW2dwuh5Gv5iCwPbvh81PtT7pr7ipgd3MGf0SbIg0oWYf +S41pDvRy1wCDtpKlnget7h4ja7DUqQN36gJsKsyQzfu9h5Z+mytGZ4tN+fpkRIx9kyn vXFw== X-Gm-Message-State: ACrzQf2ICM05S+BGImf/AlGxA1GbhBQ2ESsCgYjOL+RFYT7IFPsYwtLH a7/Vk1ojs0BfkWneTgzLm8EwFw== X-Received: by 2002:a05:620a:2057:b0:6e6:f4d:980b with SMTP id d23-20020a05620a205700b006e60f4d980bmr8451222qka.544.1666031006222; Mon, 17 Oct 2022 11:23:26 -0700 (PDT) Received: from localhost (cpe-174-109-170-245.nc.res.rr.com. [174.109.170.245]) by smtp.gmail.com with ESMTPSA id bi26-20020a05620a319a00b006ce7bb8518bsm419785qkb.5.2022.10.17.11.23.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Oct 2022 11:23:25 -0700 (PDT) Date: Mon, 17 Oct 2022 14:23:24 -0400 From: Josef Bacik To: Kemeng Shi Cc: tj@kernel.org, axboe@kernel.dk, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] block: Remove redundant parent blkcg_gp check in check_scale_change Message-ID: References: <20220929074055.30080-1-shikemeng@huawei.com> <20220929074055.30080-2-shikemeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220929074055.30080-2-shikemeng@huawei.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 29, 2022 at 03:40:53PM +0800, Kemeng Shi wrote: > Function blkcg_iolatency_throttle will make sure blkg->parent is not > NULL before calls check_scale_change. And function check_scale_change > is only called in blkcg_iolatency_throttle. > > Signed-off-by: Kemeng Shi Reviewed-by: Josef Bacik Thanks, Josef