Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Mon, 17 Oct 2022 09:08:59 -1000
From:   Tejun Heo <tj@kernel.org>
To:     Kemeng Shi <shikemeng@huawei.com>
Cc:     axboe@kernel.dk, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/8] blk-iocost: Remove vrate member in struct ioc_now
Message-ID: <Y02oS3f8yTw1r0VC@slm.duckdns.org>
References: <20221017020011.25016-1-shikemeng@huawei.com>
 <20221017020011.25016-5-shikemeng@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221017020011.25016-5-shikemeng@huawei.com>
Precedence: bulk

On Mon, Oct 17, 2022 at 10:00:07AM +0800, Kemeng Shi wrote:
> If we trace vtime_base_rate instead of vtime_rate, there is nowhere to
> access now->vrate except function ioc_now using now->vrate locally.
  ^
  which accesses ("to access" doesn't mean the same thing here)

> Just clean it.
       ^
       remove

> Signed-off-by: Kemeng Shi <shikemeng@huawei.com>

With the above description updates,

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun