Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Mon, 17 Oct 2022 09:03:33 -1000
From:   Tejun Heo <tj@kernel.org>
To:     Kemeng Shi <shikemeng@huawei.com>
Cc:     axboe@kernel.dk, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/8] blk-iocost: Trace vtime_base_rate instead of
 vtime_rate
Message-ID: <Y02nBcwomc+9xZ+l@slm.duckdns.org>
References: <20221017020011.25016-1-shikemeng@huawei.com>
 <20221017020011.25016-4-shikemeng@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221017020011.25016-4-shikemeng@huawei.com>
Precedence: bulk

On Mon, Oct 17, 2022 at 10:00:06AM +0800, Kemeng Shi wrote:
> Since commit ac33e91e2daca ("blk-iocost: implement vtime loss
> compensation") rename original vtime_base to vtime_base_rate
> and current vtime_base is original vtime_base with compensation.
              ^
              vtime_rate

There are multiple places with the same mistake. Can you please fix the
patch description?

> The current rate showed in tracepoint is mixed with vtime_base
> and vtime_base_rate:
> 1) In function ioc_adjust_base_vrate, the first trace_iocost_ioc_vrate_adj
> shows vtime_base, the second trace_iocost_ioc_vrate_adj shows
> vtime_base_rate.
> 2) In function iocg_activate shows vtime_base by calling
> TRACE_IOCG_PATH(iocg_activate...
> 3) In function ioc_check_iocgs shows vtime_base by calling
> TRACE_IOCG_PATH(iocg_idle...
> 
> Trace vtime_base_rate instead of vtime_rate as:
> 1) Before commit ac33e91e2daca ("blk-iocost: implement vtime loss
> compensation"), the traced rate is without compensation, so still
> show rate without compensation.
> 2) The vtime_base_rate is more stable while vtime_rate heavily depends on
> excess budeget on current period which may change abruptly in next period.
> 
> Signed-off-by: Kemeng Shi <shikemeng@huawei.com>

Other than that,

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun