Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <162aa836-339e-80e2-3d55-7e6bdcb89296@oracle.com>
Date:   Mon, 17 Oct 2022 15:03:15 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH] fs/jfs: replace ternary operator with min_t()
Content-Language: en-US
To:     Jiangshan Yi <13667453960@163.com>
Cc:     jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org,
        Jiangshan Yi <yijiangshan@kylinos.cn>
References: <20220714025656.1685439-1-13667453960@163.com>
From:   Dave Kleikamp <dave.kleikamp@oracle.com>
In-Reply-To: <20220714025656.1685439-1-13667453960@163.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WGNmWW9tcldWOGtmcmlTUWJVTmVraHVXcDAxY1NZL1c2MWhud2ZvK1NHWGlB?=
 =?utf-8?B?V0ttUWFuUDc2Q0l0eVpKcWFaUHFoYU12bkJUMG43dnZzempsOU5iNWk4RHQ5?=
 =?utf-8?B?T1o2cFNuVE81VW5Lb0ROcVhXU2MyWWUyTk5OeVQwazJNcUc5cHZ1VTVPS0h1?=
 =?utf-8?B?cGpQUnZsMlE1UDVWQ01DOXAzdVZwakE5L2ZoL2huY3NYTEIxMXFUQUZoNGdL?=
 =?utf-8?B?T2Ercjk5U3h6RTd4ZFRwcG5CTGhWYzhtbkJ0QTNhNG91QnZvVzNIdWtHeVFX?=
 =?utf-8?B?Rjg3amQ2MzRPVmltYzJZTGVTZWlYazNuTGdHMGt6T1lMSGQwdVdndUNVWVh0?=
 =?utf-8?B?RUlqRGNxNlcvTGJHWHl5bW9vRWdYVEY3My85NHNvbFlHa2lzR2grdFl0RXln?=
 =?utf-8?B?Y3ZTWkgzN0NYVlIvMmp1NXdRWjZRK2VDVkd0Q1FUWmR6cDc0WlFDK3dlVWM2?=
 =?utf-8?B?K2Jkd0ZRd3REd1RoVjhBSm1PRHlodkhtb1R4VFB3OUNqOFBMR0pBRW53OHZy?=
 =?utf-8?B?eWpDbHV2aDRTNzZwK0NqMGxrcnVrc08vamx4dWxESm4zNGNKRHVNWTBkaVpP?=
 =?utf-8?B?dXZ0VGhNdDFGT2JWZDZ3Nmx0WU9ONDN4ditGNmRPUTZGamhtbzNVWmZJQktL?=
 =?utf-8?B?UmVUdEZYNzhySDdyMWFZN0tac3NGV0RvL1dQRUdZQjYvb1JJZi9RYks1WXFV?=
 =?utf-8?B?SHhpenJLd09rYXRWYU9UTTZCeXJ0NlcwOE5DZ1RBR0FPVTlLT25qWEU2UkNh?=
 =?utf-8?B?UnNYWW5LT2daeWxXQU5xTmd2Z2RUdDZld29CYUFCVmVZdzc1WVl4RTRrTEhh?=
 =?utf-8?B?ZFNOU2xZMjJ3V2lxRmVLM1J6SmQyZ01HOEN1MFhReDJaandSSy95RkJmT2Qz?=
 =?utf-8?B?bVRnZmFGS3NXQThKV3hGci9xbGhhSFZPYVVPSllQRGxwZ1RXVDVFOEFwYk5x?=
 =?utf-8?B?NzZGdUNZT0l4ZktOU3NURVdQbGdBaVFGWUxYV3dKb3NLc3UyczNWWkJoV1Qz?=
 =?utf-8?B?RUFiUXlWa1lVLzg2Tm9wWEdrb0JZM0ZmYWxTc3M0ZGwrK0N2L2t3WWZVd3pE?=
 =?utf-8?B?eFAzNU85RHJIb00xR3l3V1VORUlCbEZrS0xuWC9OZkdmMTliYUpQTU9DTjBV?=
 =?utf-8?B?VEgwZWtvTEVvTEVFakJrVTYwT1JkRVkzWHVLK3RIbndyT1hwcmVWUzdWNHl5?=
 =?utf-8?B?MGRKOHk0Vy9CTG82WEtlK0ZjMVJ6bmNObE5hR2lHdVNFcFhGekVENGtsMjJV?=
 =?utf-8?B?U2Q5Q05sMldvZFA1d0xUNWF6NEwvTEpuM3ZRaGNJQ3JldHVDUnV1TmRvd0or?=
 =?utf-8?B?WUNvT2doaHBpOFl4b1VyZ3Npck5DNk5oU2lpSElyZWIyR1pnd2tlYjdGWHN1?=
 =?utf-8?B?V2tKMFhEa0lqSkQ3NVBqWU1icWs3dmtQalN6TER0UytjdGg2VDB2YTZ0RUJO?=
 =?utf-8?B?bUJzUHRKVlgveU9JLzRDSDVyTk1mdFViZmw3Q21UeFI0UUU4TlpoUjZxaGhm?=
 =?utf-8?B?TU5JWC9UQ2I4dUU1OGhqcXowaUpXNElUOVN6RUg3MkNlTysrL1RtMnNmczJG?=
 =?utf-8?B?SkFmWkpMTCtVcDhpRGNKWUtSdTU1dlY5ckNsQWY2Y0FSOEkrV0hpbnJEalh3?=
 =?utf-8?B?QnBSNUpUVHRqZDFoQWI1ck95ajQrTHVBcXhqNUV0amtwODkzTTBPYlBnL1ZE?=
 =?utf-8?B?Ym04d01ZYVpTTEpkOXJmNytYbzRuQkRza0pUc3pva0NiTk9zdGd6ck9iVUJQ?=
 =?utf-8?B?cjdvWWlrR1dqWHN3RUpVQ243OCtRTlNsU2tENUgrSWpEeVFRbEVzRzZSQ0x1?=
 =?utf-8?B?SUcxVFZZd1g1QnVHZjFYdHdBQUluK2tmajZwM3RDdExMVFhROG1sVE1FRU9a?=
 =?utf-8?B?UUZqNERURzBkeWZEK1hWS2lyNEkvWmhDVG4yRWhFTWwrVVMrNzJlWFVTcEgx?=
 =?utf-8?B?YmhrL1RSZnFkb29xWWlYTWl2bnk3eFErdHNqQkRJL1R1YTYvdW5hV3N4V0NL?=
 =?utf-8?B?b3JiR1hNWEttK2lBRlJyVDQyS0kzWUZUTzVuZXZYci9rekhwY0JkVE5Cdmdl?=
 =?utf-8?B?RlBIK2l4Q3lCSjVjU1FaNk55aHZ3bTZqaktlS0FJWVpUVGI3NFpRK2NSMW1T?=
 =?utf-8?B?ODA2MTl6QitKOGs4azlrRWtWWGtnd1JIelBPdWNCWjFRajhRaThtSzJPRjdE?=
 =?utf-8?B?SkE9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b283b367-754f-479e-3e79-08dab07aa1d9
X-MS-Exchange-CrossTenant-AuthSource: MW5PR10MB5738.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 20:03:17.5969
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EOIOgLzLvo3MQ87sgSssC+P+KqiiNivVL9Yz93t/dlkddLnGsjbOnV6QT/0DZcDsYuhj2FOB468rTDniHtf4I5t7Tned4/THgGZ+PL2bBws=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4355
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-17_13,2022-10-17_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 bulkscore=0
 mlxscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210170116
X-Proofpoint-GUID: xXIqvUjgGodZdOvBShtRxSdgmOSITwsf
X-Proofpoint-ORIG-GUID: xXIqvUjgGodZdOvBShtRxSdgmOSITwsf
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Catching up on old patches. Sorry this took so long. Looks good to me. 
I'll push it to mainline.

Thanks,
Shaggy

On 7/13/22 9:56PM, Jiangshan Yi wrote:
> From: Jiangshan Yi <yijiangshan@kylinos.cn>
> 
> Fix the following coccicheck warning:
> 
> fs/jfs/super.c:748: WARNING opportunity for min().
> fs/jfs/super.c:788: WARNING opportunity for min().
> 
> min_t() macro is defined in include/linux/minmax.h. It avoids
> multiple evaluations of the arguments when non-constant and performs
> strict type-checking.
> 
> Signed-off-by: Jiangshan Yi <yijiangshan@kylinos.cn>
> ---
>   fs/jfs/super.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/jfs/super.c b/fs/jfs/super.c
> index 85d4f44f2ac4..d2f82cb7db1b 100644
> --- a/fs/jfs/super.c
> +++ b/fs/jfs/super.c
> @@ -745,8 +745,7 @@ static ssize_t jfs_quota_read(struct super_block *sb, int type, char *data,
>   		len = i_size-off;
>   	toread = len;
>   	while (toread > 0) {
> -		tocopy = sb->s_blocksize - offset < toread ?
> -				sb->s_blocksize - offset : toread;
> +		tocopy = min_t(size_t, sb->s_blocksize - offset, toread);
>   
>   		tmp_bh.b_state = 0;
>   		tmp_bh.b_size = i_blocksize(inode);
> @@ -785,8 +784,7 @@ static ssize_t jfs_quota_write(struct super_block *sb, int type,
>   
>   	inode_lock(inode);
>   	while (towrite > 0) {
> -		tocopy = sb->s_blocksize - offset < towrite ?
> -				sb->s_blocksize - offset : towrite;
> +		tocopy = min_t(size_t, sb->s_blocksize - offset, towrite);
>   
>   		tmp_bh.b_state = 0;
>   		tmp_bh.b_size = i_blocksize(inode);