Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765609AbXF1Srm (ORCPT ); Thu, 28 Jun 2007 14:47:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760208AbXF1Srg (ORCPT ); Thu, 28 Jun 2007 14:47:36 -0400 Received: from europa.telenet-ops.be ([195.130.137.75]:57272 "EHLO europa.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756077AbXF1Srf (ORCPT ); Thu, 28 Jun 2007 14:47:35 -0400 Date: Thu, 28 Jun 2007 20:47:33 +0200 (CEST) From: Geert Uytterhoeven To: Andrew Morton Cc: Heiko Carstens , linux-kernel@vger.kernel.org, Martin Schwidefsky , Roman Zippel Subject: Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM In-Reply-To: <20070628113819.c24e592d.akpm@linux-foundation.org> Message-ID: References: <20070628034321.38c9f12b.akpm@linux-foundation.org> <20070628133715.GA4343@osiris.boeblingen.de.ibm.com> <20070628110644.a530cfef.akpm@linux-foundation.org> <20070628113819.c24e592d.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2450 Lines: 63 On Thu, 28 Jun 2007, Andrew Morton wrote: > On Thu, 28 Jun 2007 20:27:22 +0200 (CEST) Geert Uytterhoeven wrote: > > > > endif > > > > > > > > obj-$(CONFIG_GENERIC_IOMAP) += iomap.o > > > > -obj-$(CONFIG_HAS_IOMEM) += iomap_copy.o devres.o > > > > +obj-$(CONFIG_HAS_IOMEM) += iomap_copy.o devres.o check_signature.o > > > > obj-$(CONFIG_DEBUG_LOCKING_API_SELFTESTS) += locking-selftest.o > > > > obj-$(CONFIG_DEBUG_SPINLOCK) += spinlock_debug.o > > > > lib-$(CONFIG_RWSEM_GENERIC_SPINLOCK) += rwsem-spinlock.o > > > > > > We didn't think of that. > > > > > > Alas, m68k `make allmodconfig' creates CONFIG_ISA=n, CONFIG_PCI=n, > > > CONFIG_HAS_IOMEM=y, so it will still be busted. > > > > > > But this seems to be the correct fix. Perhaps m68k config needs > > > attention? > > > > Euh, I don't think this is the correct fix. > > > > CONFIG_HAS_IOMEM is apparently used in two meanings: > > 1. The architecture has support for memory mapped I/O (s390 obviously > > hasn't) > > 2. The architecture has ISA/PCI-style memory mapped I/O (readb() and > > friends) > > > > check_signature() falls under the second category. > > > > Setting NO_IOMEM on m68k will make us loose some drivers (e.g. > > drivers/video/Kconfig depends on HAS_IOMEM). > > > > Apart from many Kconfig dependencies on HAS_IOMEM, CONFIG_HAS_IOMEM is > > further only used to control the build of lib/iomap_copy.c, which > > doesn't use readb() and friends, but the __raw*() operations. > > > > Well this is fun. > > How to fix? Should we add a new CONFIG_HAS_IO? (IOPORTS?) There already exists a CONFIG_HAS_IOPORT :-) (for ISA/PCI-style I/O port access). Just make check_signature() depend on ISA || PCI (and maybe || X86_32). According to its comment, it's used to `find BIOS signatures', which is a legacy PC thing. Please don't pollute non-legacy architectures with it ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/