Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: multipart/mixed; boundary="------------2pLdTOlKpJFxMMSbN1XIq5e0"
Message-ID: <f3a5b249-84d8-9ba3-9977-3557c82a7850@amd.com>
Date:   Tue, 18 Oct 2022 02:10:45 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [git pull] drm fixes for 6.1-rc1
Content-Language: en-US
To:     =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        Dave Airlie <airlied@gmail.com>,
        Arthur Marsh <arthur.marsh@internode.on.net>
Cc:     "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
References: <CAPM=9ty3DGWa8vnfumgSrpSgWnixWjikb6C0Zk_5bW+deKLVQw@mail.gmail.com>
 <20221016080833.5503-1-user@am64>
 <CAPM=9txsBf5HJ97tAMOQ8PdiPciK-zqngERUm7hGJO8Zyyqb+w@mail.gmail.com>
 <C98B32CF-86B0-438D-BC8D-10FA255B3B4F@internode.on.net>
 <7c645fa8-bf29-4b30-bdc5-e61e6bb09927@amd.com>
 <f0110d36-a9c2-c1b9-b193-32da4f98a975@amd.com>
 <67e2904a-4b80-5173-2d8f-6a3d1f702fbb@amd.com>
 <CAPM=9tz8=iDye+vYai2NLLW-u3TfZ=DKdA_h2e+kk==ZO7q3PQ@mail.gmail.com>
 <50dcf794-e96f-24a3-5d40-6c64941b1bc0@amd.com>
From:   Arunpravin Paneer Selvam <arunpravin.paneerselvam@amd.com>
In-Reply-To: <50dcf794-e96f-24a3-5d40-6c64941b1bc0@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHU3UnNYZTRHY0YyaGlHNEhaSWorVE5YQUpsa1VYN0ZnT1lrQklkZ281YU4z?=
 =?utf-8?B?Y29JRmd2YVpoR2FqZXVrSUpTajMzR1hYK1JMcEdoTXFDZmQ0a3UrY0V2aHpm?=
 =?utf-8?B?WHdGRUtIaHFrekZqWnVUbVdJb0lUVkgxdHdwUUVZM3prbG5FQXJNaWx3TWtV?=
 =?utf-8?B?TGRWR3J2N2R0Z0FNSUFzYUpiaEdlMzhPWVdoaFNOdzdlaXd6MVBELzFlSEY4?=
 =?utf-8?B?NGJrVDRBeXBVQzN1UnV2SUNVWExsU0RNV3djN1BCYVpSZDMwMTdCM3JiZm4w?=
 =?utf-8?B?LzV6YWVVNWNmMnBSRHVqQjNTeXhYWHl5bjJFempFV1pHb0w4T1VMeDQrQUdK?=
 =?utf-8?B?eUpMQ3UxZXZPSVFvdlgxazREaWYyYXJkTEZEOWI3ZG03bW5ickNkSmR6OWI3?=
 =?utf-8?B?bHE4akN3TG14eS84RElSVVRyZWJqeGJGOExwYzZRZEN1cmNyTTJ6cTZTRGxT?=
 =?utf-8?B?dTNhTy9nYTBDMGhLYWROSWI3aFVuQXk3bStxY09Fek5YdG1seWJsVFpMQWxT?=
 =?utf-8?B?Rm5EQ2l1UzNqMlhaU0luS2FzNFZCTVdNZEdvU0xSbk9yR3J6OThKTzZ6OTRr?=
 =?utf-8?B?dUI3MnU5d2ZkSHhzWDRWS08rUGdKd1dZMVZxckRaeFVabWFZUkpRSFUrUVY5?=
 =?utf-8?B?Wms4ZzE5U1BwVGNSQzRkOUpldDRyQThoeWFCRGZDWDhZaDMrVDdEVkptK1Z3?=
 =?utf-8?B?a1BEOVZ4TzBUUUQvZ0pyK25BVlpHQlR0ODZLeG1EcDFESEVpSkZFMzBkMFE5?=
 =?utf-8?B?OXhUOUhKSjE1S1ViQ3JMcEZrUmp5Y0MrUHlZcVlYTEJGdVRsQWhiTWdzL1oy?=
 =?utf-8?B?MldITEZsb2lnNmx4YlNWT01wK1N3Q293cTVsSUJwYXF6aVNMUDJGT3hRSytI?=
 =?utf-8?B?Y3FEYVNvcU1wTUJ2QlJEM3NYRkxnZEdNR1VpQjgwMEloR0RsVmxkaE93cmIw?=
 =?utf-8?B?YlNSdkJkcHBLeGwwS1FiTEJwY244R1ZGRzYwQmxSdjB5bERSaHRSTnVQRUFw?=
 =?utf-8?B?alRYRURzbHNFdDhVb0F1clpWUW4zdmMxM0RwMGgybG1kRmtBRE9HWnJ6bG1K?=
 =?utf-8?B?S1RMSmYwQU5pMlhvSGdkTkhyejdBQURkaXp2Q3JaWVJ2SWdtZzdpUXgyUGo0?=
 =?utf-8?B?NDN0blNZeXZmNG9kQUtNZjJ0Nzdob2VKa3RNYUlUU01GZUVxcm5tQWFjbGR3?=
 =?utf-8?B?RGNGamlTYVlmcU9CaGRhOWgwejNBUzlwc3N5MXhNeG9mYllyWHR5SHRzazh1?=
 =?utf-8?B?QjhRZnF5NXo1dDFMVFFUMVAybFlkMTZpQmZiSFpxUys3SVptVGpnK29tTHAr?=
 =?utf-8?B?TFczRGZYMjRwU1M3andHMXRvUjNBUkJXOFZENnJzV3J4MENqQjJCK0pPdTJm?=
 =?utf-8?B?UGRkNm52ZHA1T3FZSnRsQkhCU2U0bHZMZTNsTGlwMXBQTlZybUExWW0xT2Jv?=
 =?utf-8?B?NWNGdktzZjlsZWNqSUFtUDhMQjFXWWgzNjk1ekl4eDJUeWM5VXo2VDE3NEVL?=
 =?utf-8?B?MlYxK29OY1k3QWFOOE5jT1FWcHFRalVNcWxzL0tTTEVHS0xXSjdZNjE2TjVR?=
 =?utf-8?B?SW5ibFRIM1FTanhyL2NRMmhZOVhnOHUzY2RSUnJVZ1RCd0p1ZitESFJSdjdP?=
 =?utf-8?B?YjNrQjE4MEJMV2hham5RU1F0cGs3V0pVVk5PSmV6UWprVkE3dlFBcCsrVVVz?=
 =?utf-8?B?ZnRpMWxrTGphSDdncC94NEwrb3R4V2tlajA1VVczNkNiQXBZZkI0WFZZVnlh?=
 =?utf-8?B?aG5GZm45a0p0dnNCakdwUUVWdDlUVGNvd3FRVjVFbzFMOEVITDdaUHhnbFow?=
 =?utf-8?B?MjVuaW41NlFBcHFSZ1MrTUJIR2themFEZHVrb0pCUW1XOUx3WUpWMjlVU2Nx?=
 =?utf-8?B?eXJJUGdGYUZ6Y1dJN3ZZUlNRRUt1UzlRMjR1em1YczdHSVB0b21aVE9GZEpW?=
 =?utf-8?B?RHpNbTJ3ME5laElTTDBtZzI1MGxCeGxzR0R1NHNQbVdPZmFFZE9ab0ptL1B4?=
 =?utf-8?B?eDUzUGhBL0x4Z1ZKMnRsaVYrYjltRTVmSWJKeHpBaHFxT0xWc2pDbHVnbjBx?=
 =?utf-8?B?LzYyeUQ0Y3dWM1RITHpWNmUrY2VHdlZKNXdsNWJITjJ1bnpCbnBybE96T1BL?=
 =?utf-8?Q?2XX6mDUEvy8EYggWY9Gy6Upv7?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 14752e35-734c-44a3-9a04-08dab07fe4a3
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4342.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 20:40:57.3201
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +mTuA4OHKD1daj6oizaKa7PxB6O2+TLGpfpIdE/iiocAHYhoHCY7W3ydIdmyUq1aIQjOFaOp/UnYQSQQEVttpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7597
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--------------2pLdTOlKpJFxMMSbN1XIq5e0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Christian,

Looks like we have to exit the loop if there are no blocks to compare.
May be that's why the function returns false.

@Arthur Marsh Could you please test the attached patch.

Thanks,
Arun

On 10/17/2022 1:39 PM, Christian König wrote:
> Am 17.10.22 um 10:01 schrieb Dave Airlie:
>> On Mon, 17 Oct 2022 at 17:07, Christian König 
>> <christian.koenig@amd.com> wrote:
>>> Hi Arun,
>>>
>>> the hw generation doesn't matter. This error message here:
>>>
>>> amdgpu: Move buffer fallback to memcpy unavailable
>>>
>>> indicates that the detection of linear buffers still doesn't work as
>>> expected or that we have a bug somewhere else.
>>>
>>> Maybe the limiting when SDMA moves are not available isn't working
>>> correctly?
>> It is a CAPE_VERDE, so maybe something with the SI UVD memory 
>> limitations?
>
> Yeah, good point. Could be that we try to move something into the UVD 
> memory window and that something isn't allocated linearly.
>
> Arun can you trace the allocation and make sure that all kernel 
> allocations have the CONTIGUOUS flag set?
>
> Thanks,
> Christian.
>
>>
>> Dave.
>

--------------2pLdTOlKpJFxMMSbN1XIq5e0
Content-Type: text/plain; charset=UTF-8;
 name="0001-drm-amdgpu-Fix-for-BO-move-issue.patch"
Content-Disposition: attachment;
 filename="0001-drm-amdgpu-Fix-for-BO-move-issue.patch"
Content-Transfer-Encoding: base64

RnJvbSAxMzJjZTgzZjg5M2VhZWE3NDNmYjdmNDFhOWRjNzJhZmVhNTJjZGFhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBcnVucHJhdmluIFBhbmVlciBTZWx2YW0gPEFydW5wcmF2aW4u
UGFuZWVyU2VsdmFtQGFtZC5jb20+CkRhdGU6IE1vbiwgMTcgT2N0IDIwMjIgMTM6MTU6MjEgLTA3
MDAKU3ViamVjdDogW1BBVENIXSBkcm0vYW1kZ3B1OiBGaXggZm9yIEJPIG1vdmUgaXNzdWUKCklm
IHRoZXJlIGFyZSBubyBibG9ja3MgdG8gY29tcGFyZSB0aGVuIGV4aXQKdGhlIGxvb3AuCgpTaWdu
ZWQtb2ZmLWJ5OiBBcnVucHJhdmluIFBhbmVlciBTZWx2YW0gPEFydW5wcmF2aW4uUGFuZWVyU2Vs
dmFtQGFtZC5jb20+Ci0tLQogZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5j
IHwgMyArKysKIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9k
cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdHRtLmMgYi9kcml2ZXJzL2dwdS9kcm0v
YW1kL2FtZGdwdS9hbWRncHVfdHRtLmMKaW5kZXggZGMyNjJkMmMyOTI1Li41NzI3N2IxY2YxODMg
MTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYworKysg
Yi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdHRtLmMKQEAgLTQzOSw2ICs0Mzks
OSBAQCBzdGF0aWMgYm9vbCBhbWRncHVfbWVtX3Zpc2libGUoc3RydWN0IGFtZGdwdV9kZXZpY2Ug
KmFkZXYsCiAJd2hpbGUgKGN1cnNvci5yZW1haW5pbmcpIHsKIAkJYW1kZ3B1X3Jlc19uZXh0KCZj
dXJzb3IsIGN1cnNvci5zaXplKTsKIAorCQlpZiAoIWN1cnNvci5yZW1haW5pbmcpCisJCQlicmVh
azsKKwogCQkvKiB0dG1fcmVzb3VyY2VfaW9yZW1hcCBvbmx5IHN1cHBvcnRzIGNvbnRpZ3VvdXMg
bWVtb3J5ICovCiAJCWlmIChlbmQgIT0gY3Vyc29yLnN0YXJ0KQogCQkJcmV0dXJuIGZhbHNlOwot
LSAKMi4yNS4xCgo=

--------------2pLdTOlKpJFxMMSbN1XIq5e0--