Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-1047-g9e4af4ada4-fm-20221005.001-g9e4af4ad
Mime-Version: 1.0
Message-Id: <d5faaf6f-7de5-49b0-92d6-9989ffbdbf2e@app.fastmail.com>
In-Reply-To: <20221010101331.29942-1-parav@nvidia.com>
References: <20221010101331.29942-1-parav@nvidia.com>
Date:   Mon, 17 Oct 2022 22:55:00 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Parav Pandit" <parav@nvidia.com>, bagasdotme@gmail.com,
        "Alan Stern" <stern@rowland.harvard.edu>, parri.andrea@gmail.com,
        "Will Deacon" <will@kernel.org>,
        "Peter Zijlstra" <peterz@infradead.org>, boqun.feng@gmail.com,
        "Nicholas Piggin" <npiggin@gmail.com>, dhowells@redhat.com,
        j.alglave@ucl.ac.uk, luc.maranget@inria.fr,
        "Paul E. McKenney" <paulmck@kernel.org>,
        "Akira Yokosawa" <akiyks@gmail.com>, dlustig@nvidia.com,
        "Joel Fernandes" <joel@joelfernandes.org>,
        "Jonathan Corbet" <corbet@lwn.net>, linux-kernel@vger.kernel.org,
        Linux-Arch <linux-arch@vger.kernel.org>,
        linux-doc@vger.kernel.org
Subject: Re: [PATCH v4] locking/memory-barriers.txt: Improve documentation for writel()
 example
Content-Type: text/plain
Precedence: bulk

On Mon, Oct 10, 2022, at 12:13 PM, Parav Pandit wrote:
> The cited commit describes that when using writel(), explcit wmb()
> is not needed. wmb() is an expensive barrier. writel() uses the needed
> platform specific barrier instead of expensive wmb().
>
> Hence update the example to be more accurate that matches the current
> implementation.
>
> commit 5846581e3563 ("locking/memory-barriers.txt: Fix broken DMA vs. 
> MMIO ordering example")
>
> Signed-off-by: Parav Pandit <parav@nvidia.com>

I have no objections, though I still don't see a real need to change
the wording here.

Acked-by: Arnd Bergmann <arnd@arndb.de>