Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <700ae03f-12d2-8c01-2e20-8db797b4d5ef@oracle.com>
Date:   Mon, 17 Oct 2022 16:08:18 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH] jfs: remove unused declarations for jfs
Content-Language: en-US
To:     Gaosheng Cui <cuigaosheng1@huawei.com>, shaggy@kernel.org
Cc:     jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org
References: <20220909065055.1154080-1-cuigaosheng1@huawei.com>
From:   Dave Kleikamp <dave.kleikamp@oracle.com>
In-Reply-To: <20220909065055.1154080-1-cuigaosheng1@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZnhVQnJPY3oxTDhJMXFYY0o0a0hzdVN0YklqZVdJQUNKUW1wbWNkempCMXI2?=
 =?utf-8?B?M1NRRVpHMWREYWtjRktjd0F4S21vR2tEOWxoeXFqazJqOUMwZEZzR0Z0QUVV?=
 =?utf-8?B?dnlHeVhIblRQenY1ZURES1FxMFE0dGZwRURMUDY5NmtWSGQzVVRvRW10UGFl?=
 =?utf-8?B?U3ZlTkNuOGlRSjRHcER2WDh1S2RJaTFNZGxQVnhmT0VlaU03MXVuV1RyZUlO?=
 =?utf-8?B?RTFnbTc3Q2RnZnVIZkRGSlo3RHowSUFnOHhWc2lROWFxVWJDUDFGaG9HK2JC?=
 =?utf-8?B?SWY0MFpyaEM0akYzSXpPOFZiNVVZOEdUMmZmYTZmS2MxM3FsdWhWSmQrQk5m?=
 =?utf-8?B?L1ZZdmVHQ2V5VlIyb0pZWUR3WWZZN0VLcU1VRGFpdXJITVY2OVZlNGdtb1dC?=
 =?utf-8?B?c1l0RjJDM2liSkJ5VTBiZVFIb05HVWxyMjZ5b1RaUDdIenh5VDZ0UE1ycEpN?=
 =?utf-8?B?NytEeVA5clZqalpneDNQUXBqWFIzNDByZXpQbi9ldEhnRnBtZXArVDFjK2kx?=
 =?utf-8?B?Y3BvRDFyalJnNkVxZkNOM2pzMlh6TExZRy9yKzRPNkNRRlRsSGFOeUFGM1ZZ?=
 =?utf-8?B?OS96SysrWTBGeUpZd0FFREM0ZjdkekRFOC9CTHFDSkNVSmFmQTJJd25WakVh?=
 =?utf-8?B?NFBGZlRjektMUm8ycVJGcmVCQzZwQWRiYlF5UlRibE9tVWV1N1grUmRvVlk1?=
 =?utf-8?B?ZVlKeGpQaHlhODJMSVYvWmtvZmdEME9naUdyWGt1enloU0hBY2tNaXYxdjNF?=
 =?utf-8?B?QXExeG5ObzRFZzdJK2Q2M1hJMVdaK3M3VHViUForeG9pOGUxMHBxODRhNXpW?=
 =?utf-8?B?bndMYmkwN3FKWGVDSm1ybVhNVGhNd0Zkczh0WlEvclJlVXlIaFZ3ZUVBSzl4?=
 =?utf-8?B?VkNzNGZ3bXZCWlVuK1BaOWhlYnMvSlhKOFhCNG4wYmVLMDRJR3ZDV1MrRFl2?=
 =?utf-8?B?KzJWRnM5WTlOQnI5Q01ObUlzYTRubzA2SC9FSEZKRjVCNVlEbWJHSlhMNEl1?=
 =?utf-8?B?QVVTWVRpVVpQMnAyc0k4NnV5MDlzdXo0SjBPYVpZT0pYZExRdnIzS09xSHJa?=
 =?utf-8?B?Rlg1Sm9wSjdwTUg3YWRCY0dkcjg4TllULzZVK0V3TVJQVENTNURHV3lhK0xF?=
 =?utf-8?B?em10QWFYT2pFVGhpNzliTFZPaUZCUFhRY3F2cEdiKytoamp1UXc3TnlCRlpZ?=
 =?utf-8?B?aHJCT0FhL0JrcStVTnhJTDdwZHhBalIvRk9HVy8reCtwb2VnR1dsRzBrTUo2?=
 =?utf-8?B?VU1xTThTdDVpdmdicjQ1TlR1ZWgzaGdPMDhmUEtjRGJRRG9YQlNuUnVBQUIx?=
 =?utf-8?B?YmJGUlFJMzlWL0kwOE5EOHllRW9KcG5RT0drZ0VqSHZWQWtWMFo2VldKRVFS?=
 =?utf-8?B?MmFLaW1Hb0dHMSt3ZDdXRkt4TjhjS2lmalljelNLYjR0cnBmUnBpSWQ3WWdu?=
 =?utf-8?B?WTVhcVd3SkFpSGVNTmtzWFVOUkxCREZucEk3K3hESUQyTWd4Y1NjKzFlMjhI?=
 =?utf-8?B?UnQxMnFZeVd4TytFbnNBbXpWKzdxU1RCVUExdC9sQkM0WXgxNUZpK3RPRUZX?=
 =?utf-8?B?SG5yWjNocmQ3MzRSeE9xbEJpVXVvUEk2azQrWUt4bC8rbDRCOTFZSlhwQlhj?=
 =?utf-8?B?WVpnQUxoc3d1d3RveVlYODN5OTZGYzNXVGhpTVNOTFYyY0VpNnhOVHh6aFlS?=
 =?utf-8?B?Z2V4WnExSGRLUWh4cGYxVHZGcndmanREcGw1NnhPNS9TS2VtcU55bnZqcGVp?=
 =?utf-8?B?NDNXWHJmZWMyYmhqSEdlbElXVkZwNUNyY0dkVDdJdEwzYTUvclF3M2RVSmow?=
 =?utf-8?B?Y0xZK0l2d1lLUE5GZGg4c1ZoZzhycGhFMDZtRzBvK3pUS1hzWGl5ck1Yc1F2?=
 =?utf-8?B?ZTBmNGQxeElPM2h1TG40c3pKSk1GU2VhREdNZmQyNExmQW9mNll1RWpkYzBV?=
 =?utf-8?B?UjZ0a3MreUk2R01tZ1cvNitaSUV6alEzTVllclViY2NHckdYRVQ2WkpYRkZs?=
 =?utf-8?B?SVVzb04xNmJZdndwVGJhZGhZQXZyU2dpQnE5TzJwL2F6ZFdsVTMxdEJHN20r?=
 =?utf-8?B?dDBoTW02U1JLZUtYdDM5M1BnZGxBWUhKYWZ6TDdTN0FPZFVEMTJWSmtSRmtZ?=
 =?utf-8?B?clZZZHR2NmVPQXFWNVdQU2N3S0pyREtYUFJPVGZZbzEvOWhQRDMyektWbkRW?=
 =?utf-8?B?bVE9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35c8dadb-36c9-4db8-af99-08dab083b89a
X-MS-Exchange-CrossTenant-AuthSource: MW5PR10MB5738.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 21:08:21.2414
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1+Ofl6Pkyestsots6WRtRifa7aW2JkGvraBjP0zHil1O/3Ck0Nnv37RPgIC96VcfqJM6r1WjLhY5CRptUQWph3khdUSOhlpWcmwepmmDhlk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5323
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-17_13,2022-10-17_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 mlxscore=0
 suspectscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210170121
X-Proofpoint-ORIG-GUID: 675wuKcpu_GlYnKE6uf6LH28rSOrzkAE
X-Proofpoint-GUID: 675wuKcpu_GlYnKE6uf6LH28rSOrzkAE
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Applied.

Thanks,
Shaggy

On 9/9/22 1:50AM, Gaosheng Cui wrote:
> extRealloc(), xtRelocate(), xtDelete() and extFill() have been
> removed since commit e471e5942c00 ("fs/jfs: Remove dead code"),
> so remove them.
> 
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
>   fs/jfs/jfs_extent.h | 2 --
>   fs/jfs/jfs_xtree.h  | 4 ----
>   2 files changed, 6 deletions(-)
> 
> diff --git a/fs/jfs/jfs_extent.h b/fs/jfs/jfs_extent.h
> index 1c984214e95e..a0ee4ccea66e 100644
> --- a/fs/jfs/jfs_extent.h
> +++ b/fs/jfs/jfs_extent.h
> @@ -10,9 +10,7 @@
>   	(addressPXD(&(JFS_IP(ip)->ixpxd)) + lengthPXD(&(JFS_IP(ip)->ixpxd)) - 1)
>   
>   extern int	extAlloc(struct inode *, s64, s64, xad_t *, bool);
> -extern int	extFill(struct inode *, xad_t *);
>   extern int	extHint(struct inode *, s64, xad_t *);
> -extern int	extRealloc(struct inode *, s64, xad_t *, bool);
>   extern int	extRecord(struct inode *, xad_t *);
>   
>   #endif	/* _H_JFS_EXTENT */
> diff --git a/fs/jfs/jfs_xtree.h b/fs/jfs/jfs_xtree.h
> index 142caafc73b1..ad7592191d76 100644
> --- a/fs/jfs/jfs_xtree.h
> +++ b/fs/jfs/jfs_xtree.h
> @@ -96,12 +96,8 @@ extern int xtInsert(tid_t tid, struct inode *ip,
>   extern int xtExtend(tid_t tid, struct inode *ip, s64 xoff, int xlen,
>   		    int flag);
>   extern int xtUpdate(tid_t tid, struct inode *ip, struct xad *nxad);
> -extern int xtDelete(tid_t tid, struct inode *ip, s64 xoff, int xlen,
> -		    int flag);
>   extern s64 xtTruncate(tid_t tid, struct inode *ip, s64 newsize, int type);
>   extern s64 xtTruncate_pmap(tid_t tid, struct inode *ip, s64 committed_size);
> -extern int xtRelocate(tid_t tid, struct inode *ip,
> -		      xad_t * oxad, s64 nxaddr, int xtype);
>   extern int xtAppend(tid_t tid,
>   		    struct inode *ip, int xflag, s64 xoff, int maxblocks,
>   		    int *xlenp, s64 * xaddrp, int flag);