Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <81528485-fa80-55ab-16ce-84de520f5262@gmail.com>
Date:   Mon, 17 Oct 2022 14:05:42 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] usb: bdc: change state when port disconnected
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>, justinpopo6@gmail.com
Cc:     alcooperx@gmail.com, balbi@kernel.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        bcm-kernel-feedback-list@broadcom.com, justin.chen@broadcom.com
References: <1664997235-18198-1-git-send-email-justinpopo6@gmail.com>
 <Y0Gax8SUoq59hdoF@kroah.com> <f0706380-94f9-ed7d-1033-8da51aab6b01@gmail.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <f0706380-94f9-ed7d-1033-8da51aab6b01@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 10/10/22 07:58, Florian Fainelli wrote:
> 
> 
> On 10/8/2022 8:44 AM, Greg KH wrote:
>> On Wed, Oct 05, 2022 at 12:13:55PM -0700, justinpopo6@gmail.com wrote:
>>> From: Justin Chen <justinpopo6@gmail.com>
>>>
>>> When port is connected and then disconnected, the state stays as
>>> configured. Which is incorrect as the port is no longer configured,
>>> but in a not attached state.
>>>
>>> Signed-off-by: Justin Chen <justinpopo6@gmail.com>
>>> ---
>>>   drivers/usb/gadget/udc/bdc/bdc_udc.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>
>> What commit id does this fix?  Should it go to older kernels?  If so,
>> how far back?
> 
> This would be:
> 
> Fixes: efed421a94e6 ("usb: gadget: Add UDC driver for Broadcom USB3.0 
> device controller IP BDC")
> 
> that issue was present since the driver was included in Linux with the 
> commit above, we did not really consider it to be a serious enough bug, 
> but I suppose it would not hurt to affix the said Fixes tag.

Greg, are you picking up the patch as-is, or do you need Justin to 
resusbmit with the Fixes: tag added?
-- 
Florian