Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f31307ae-8413-d25a-d602-76016a52f7a7@oracle.com>
Date:   Mon, 17 Oct 2022 17:39:59 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH] jfs: remove redundant assignments to ipaimap and ipaimap2
Content-Language: en-US
To:     Colin Ian King <colin.i.king@gmail.com>
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221017215636.863916-1-colin.i.king@gmail.com>
From:   Dave Kleikamp <dave.kleikamp@oracle.com>
In-Reply-To: <20221017215636.863916-1-colin.i.king@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mkp6NmRINmN1cXdlb2p2S1NnZ3M5VXdQd1VadDBxd0FEem90TlNsSnF6UnBX?=
 =?utf-8?B?ZlRDazRXSkVTQTR2R0RLOHF3RjJsYnF1VURvZ2xpTmNZeVRORWtNTEtsUzdJ?=
 =?utf-8?B?SlhJRlhjZDBTRUhkQk9TTGpWb0JlUlVhSk1nTk0xOTRYT1c1dUIrdGw0dUNY?=
 =?utf-8?B?WnFJRGw5OHhxcU1FTXBtOGJPZElkbjIyamY0eFY3bzh2TE94M2NWU3hVT2h3?=
 =?utf-8?B?K2ZNL2V0OGJmRFk1enh4Mm9WL1JzK2ltV2daRFROVThCaWZ5M1VLdG85cDRJ?=
 =?utf-8?B?QTd2VzNzaUhnZkNPcnp5MTV1VFFDUkVrWk1WT3FoekVTSmxNU2lDb2dXSFFk?=
 =?utf-8?B?K054WXdSN2NlSEVWeUUyU01nRk91ajgybDNiR1JIZ29SbDZJVnBxMlZEVXVD?=
 =?utf-8?B?QUpqSlljcEttUGN4bURPVmlFQlVvZDZsYVFhVzVRWlpnZGdXc1pnRDBkVDBP?=
 =?utf-8?B?anhzVVpKOTlKcXRNU0xNa3VRY1IzemJta2p0SitTdWtGcUdMTjBlVEJTVVgr?=
 =?utf-8?B?NUk4SkVsajN3ZHpMVk43VitRTWovekoySVJDNFRYWTcwUzRpa2dOUEtrNFNn?=
 =?utf-8?B?UUY3NE5FT1BkODd0LzR3WXZkeUdlelJPRmJVZCs3SlVISUFSVncwQlRwNzNu?=
 =?utf-8?B?ZWpVcTlFdkpmdzkxRVN6c3RscGgzUEdmTGQ4bHRub0hOd2NZYXNPZFgyOFlq?=
 =?utf-8?B?UVhzVVdrcGd2eXM4N04wSGg4bUpoWlRjWG1rMnFnVHBIRHZWelNqSnNPZjhZ?=
 =?utf-8?B?WWNBNTdyaUhxakZFeDhPUWhmYkVHSnRITGxST3BnRERza3lrMGt3RXp0cDFr?=
 =?utf-8?B?Um15cTJzWngzelVERzVBYW5HM3FrSWVBalZiMTFvOUJNZ1BVdEw2ZUd2SkJQ?=
 =?utf-8?B?elhqa3FkU0dkWUxuL0pCQk9aTXJiZ1EzRld4WU9JTVpBS2tpcUFNb1l2NE8v?=
 =?utf-8?B?d25kcjZodW9Mc0JhcS9QY2lKbTlxSnJLVFdNRFEwa2pRWVVmNGtVOHdEWElC?=
 =?utf-8?B?YWhTZGRxWm9kZVFlQ0VhTmhDSTluSXQ3Y2JtbEo5aHZQaGlaNktYV0FZNksx?=
 =?utf-8?B?TmV1WEhVeExjRE5BWGdmblFXZEhzbDcvOFp4cE9qMFAxaGpDNElzdEFzMTl4?=
 =?utf-8?B?V0tqVUwzV1pPenZXZUNSZTJGbEcyM2h2TkIyRjN4Z3N4TkdQOTlsTDBvekRF?=
 =?utf-8?B?K015NlFyaDBEUHByWFJLcEpyNWhpaHRBb1l3VWxJNmZoV3hPbnNzMTFKZERt?=
 =?utf-8?B?T09HYnZaNW51eGVVUUxkVWFMNXBIeXl0ZWdXY1k3T2lnM3VrOHJUcURGTU05?=
 =?utf-8?B?dFFxaEFZRmFwczFpN2IxS1ZTVnREWDBvaHFIdjQzL2lMOW1NN3FUOTlaK281?=
 =?utf-8?B?SWlmZlUxRGFXbGtmMzdGNkxvVVFTTDR2NHRDZ0NMbWpJcUZVV0RSaTJ5bFNQ?=
 =?utf-8?B?VzFMZldHM3NES3ZuZjFsYkQ2YUpTMDJrM1ROSWxGMGgvOXhXRHd4N0JvNmIv?=
 =?utf-8?B?ZHJKTTdiL25QRCt3aElrbzBlYTRCRGdXcUV1VlMvVENhak1xamhERnhIYjRZ?=
 =?utf-8?B?QVYwYU1kSWxLK1BVTFpucTNZakxvYzNma00ySW1CZm9xMkpyazhaKzJGZjc4?=
 =?utf-8?B?ZGZYYVhzUUtGZW9ZT3I2U2MzcHVSeDJMTFhYWExWejBIMmd6MDBMUzk2dXRk?=
 =?utf-8?B?SzNtSitHc05idmpvakdBWVErcFRIWUdCV3Y1dXAyUmt1dEpZK01XNVlvWmZs?=
 =?utf-8?B?bHpJdllXakhiTVByTmp3UEp4K3VrRE1kb29sRjBRVkF3d3l0Um4yZ3dKQlFo?=
 =?utf-8?B?ZWt5VGZheUdpRXRMS2lDb0V6U3htSEIzVnZLS1hlZ1J3YTlKS0JWQWllaFVh?=
 =?utf-8?B?QUdkeU1CZmZqWXhFMnFCV2RHTnZiU2ozQ3ZNc1FWRkJiSGs3TS9JYlBLdG5I?=
 =?utf-8?B?NGFxakxpVmI0S3NWaDM4bzFrZXJXTm5oNlVCRjA1SHBuQlZraXkxNU43VDV3?=
 =?utf-8?B?VzdaUzJJQ3grcHhZZzRTaG05VHBXdXhIZ1FzZmNZcjZ2elRKV2pzSVIvemxF?=
 =?utf-8?B?dUZsNDJOdTZsOUw1Z0VDYWhsWjZMUlJlVUpwSUh6Y1FQT0hFeWZuRTR5ZkFI?=
 =?utf-8?B?NVQyVjZzVW5jbHlVZFVOVXhjRVplbFlGYUZzN2xSTWtGUWdCK0QwQXI1ZnVt?=
 =?utf-8?B?Rmc9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: abe45768-7359-4d9e-6162-08dab0908758
X-MS-Exchange-CrossTenant-AuthSource: MW5PR10MB5738.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 22:40:02.0707
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KPfz0zrl7Pjc+iDjye4mXISYBMBQdKZh3QktD8jzNMf/XeMhl/A6C5bpewsMp8gyHrJtXbUQ/DJePYRoRhiMqub8bzJZPYpTlb53ITc+b+U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5681
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-17_13,2022-10-17_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=857 phishscore=0
 suspectscore=0 spamscore=0 adultscore=0 mlxscore=0 malwarescore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210170129
X-Proofpoint-ORIG-GUID: eBWoDvIbfoVeXzyzyYfOyx9d8YtzIg8K
X-Proofpoint-GUID: eBWoDvIbfoVeXzyzyYfOyx9d8YtzIg8K
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/17/22 4:56PM, Colin Ian King wrote:
> The pointers ipaimap and ipaimap2 are initialized with values that are
> never read, they are re-assigned later when they are required. The
> initializations are redundant and can be removed.

Hmm. Or we can remove the later assignments. That would seem more 
consistent with the ipbmap and ipimap.

> 
> Cleans up two clang scan build warnings:
> fs/jfs/jfs_umount.c:42:16: warning: Value stored to 'ipaimap' during
> its initialization is never read [deadcode.DeadStores]
> 
> fs/jfs/jfs_umount.c:43:16: warning: Value stored to 'ipaimap2' during
> its initialization is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>   fs/jfs/jfs_umount.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/jfs/jfs_umount.c b/fs/jfs/jfs_umount.c
> index 3e8b13e6aa01..cc4d7e6e8a4b 100644
> --- a/fs/jfs/jfs_umount.c
> +++ b/fs/jfs/jfs_umount.c
> @@ -39,8 +39,8 @@ int jfs_umount(struct super_block *sb)
>   	struct jfs_sb_info *sbi = JFS_SBI(sb);
>   	struct inode *ipbmap = sbi->ipbmap;
>   	struct inode *ipimap = sbi->ipimap;
> -	struct inode *ipaimap = sbi->ipaimap;
> -	struct inode *ipaimap2 = sbi->ipaimap2;
> +	struct inode *ipaimap;
> +	struct inode *ipaimap2;
>   	struct jfs_log *log;
>   	int rc = 0;
>