Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220916083604.33408-1-nixiaoming@huawei.com> <20220930091406.50869-1-nixiaoming@huawei.com>
 <910e5533-4abc-85f1-6bfc-4d776f8bed7b@huawei.com>
In-Reply-To: <910e5533-4abc-85f1-6bfc-4d776f8bed7b@huawei.com>
From:   Phillip Lougher <phillip.lougher@gmail.com>
Date:   Mon, 17 Oct 2022 23:59:14 +0100
Message-ID: <CAB3wodeXGT0dGxZ+AGJvTU1mMHsqNo4--1c+6UVhYmJj4fO14w@mail.gmail.com>
Subject: Re: ping// Re: [PATCH v5 0/2] squashfs: Add the mount parameter "threads="
To:     Xiaoming Ni <nixiaoming@huawei.com>
Cc:     linux-kernel@vger.kernel.org, phillip@squashfs.org.uk,
        wangle6@huawei.com, yi.zhang@huawei.com, zhongjubin@huawei.com,
        chenjianguo3@huawei.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Oct 17, 2022 at 2:11 AM Xiaoming Ni <nixiaoming@huawei.com> wrote:
>
> ping

I was hoping you'd notice the obvious mistake you made in the patch set,
and send an updated version, which would avoid me having to point out
such mistakes again.

I have replied to patch [1/2]

Phillip

>
> On 2022/9/30 17:14, Xiaoming Ni wrote:
> > Currently, Squashfs supports multiple decompressor parallel modes. However, this
> > mode can be configured only during kernel building and does not support flexible
> > selection during runtime.
> >
> > In the current patch set, the mount parameter "threads=" is added to allow users
> > to select the parallel decompressor mode and configure the number of decompressors
> > when mounting a file system.
> >
> > "threads=<single|multi|percpu|1|2|3|...>"
> > The upper limit is num_online_cpus() * 2.
> >
> > v5: fix a low-level mistake in patching:
> >    fs/squashfs/super.c:492:7: warning: "CONFIG_SQUASHFS_DECOMP_MULTI" is
> >    not defined, evaluates to 0 [-Wundef]
> >
> > v4: https://lore.kernel.org/lkml/20220916083604.33408-1-nixiaoming@huawei.com/
> >   Based on Philip Lougher's suggestion, make the following updates:
> >   1. Use static modifiers to avoid changing symbol names.
> >   2. Fixed some formatting issues
> >
> > v3: https://lore.kernel.org/lkml/20220902094855.22666-1-nixiaoming@huawei.com/
> >    Based on Philip Lougher's suggestion, make the following updates:
> >    1. The default configuration is the same as that before the patch installation.
> >    2. Compile the three decompression modes when the new configuration is enabled.
> >    3. "threads=1" supports only the SQUASHFS_DECOMP_SINGLE mode.
> >
> > v2: https://lore.kernel.org/lkml/20220816010052.15764-1-nixiaoming@huawei.com/
> >    fix warning: sparse: incorrect type in initializer (different address spaces)
> >    Reported-by: kernel test robot <lkp@intel.com>
> >
> > v1: https://lore.kernel.org/lkml/20220815031100.75243-1-nixiaoming@huawei.com/
> >
> > Xiaoming Ni (2):
> >    squashfs: add the mount parameter theads=<single|multi|percpu>
> >    squashfs: Allows users to configure the number of  decompression
> >      threads
> >
> >   fs/squashfs/Kconfig                     | 51 ++++++++++++++++--
> >   fs/squashfs/block.c                     |  2 +-
> >   fs/squashfs/decompressor.c              |  2 +-
> >   fs/squashfs/decompressor_multi.c        | 20 ++++---
> >   fs/squashfs/decompressor_multi_percpu.c | 23 +++++---
> >   fs/squashfs/decompressor_single.c       | 15 ++++--
> >   fs/squashfs/squashfs.h                  | 23 ++++++--
> >   fs/squashfs/squashfs_fs_sb.h            |  4 +-
> >   fs/squashfs/super.c                     | 93 +++++++++++++++++++++++++++++++--
> >   9 files changed, 199 insertions(+), 34 deletions(-)
> >
>