Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ade90964-e8fe-c6d6-667d-133c36ad7c15@intel.com>
Date:   Mon, 17 Oct 2022 15:58:28 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.13.1
Subject: Re: [PATCH linux-next] iavf: Replace __FUNCTION__ with __func__
Content-Language: en-US
To:     Joe Perches <joe@perches.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        <yexingchen116@gmail.com>, <anthony.l.nguyen@intel.com>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <intel-wired-lan@lists.osuosl.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        ye xingchen <ye.xingchen@zte.com.cn>
References: <20221011111638.324346-1-ye.xingchen@zte.com.cn>
 <2e38c0f1-1b6c-1825-12c1-5ad135865c0c@intel.com>
 <a6d6e890c232775489daa9522c4f8dd9594b1656.camel@perches.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <a6d6e890c232775489daa9522c4f8dd9594b1656.camel@perches.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TnVSWUVpVHRjQmVyQ0JGMkEwVTNiT0VyWUtrRWFmc1AyeVlpcFYza3pYU1Zz?=
 =?utf-8?B?NDFlcWtlNXQ4R01HbTRhdkZJZm05RWtlVUZOZjk5TUh0aDNEZXkzaDhFR0hM?=
 =?utf-8?B?Q1czL2xVZUtsdDUzSXVLTm5uTjQ5N1ZMcTYwN0E3SXNJd2xvQ1ZXRVpkMXlj?=
 =?utf-8?B?NFlhczBMbFRzcmIrUlhLdnJOMk9NRThkcVh3Y3dFeVhHU2NYZTBMZ01Xbmp0?=
 =?utf-8?B?djB1aHhwRFJINEkxdDJzL05tTlUzM1lpNkQ0WlIzK0pudnlneTRMMndzSlhG?=
 =?utf-8?B?RjBMdS9UUFVIalN4dXFhTlFCM3N0UmE1MEFKUzAyOThXeXQ5S1RQY3pYQjZH?=
 =?utf-8?B?NFN1UTV6RVhqbWI2c0tzUmNRUU1Hb0JPR0dUR0RMK3VLcForTGIrcyswZ0RC?=
 =?utf-8?B?TnloMVoyNGpvNE11WUNSRGlYTjVScXZoWmF5YnNnK010empWMEhUSmxMZE5w?=
 =?utf-8?B?TGU3MmtDRXNsYnhqUkVYZzh5dnVzV2VwSmpNVjcvTFQyZFVTN05OQjN3TTRq?=
 =?utf-8?B?NU42Z2pvdk1ML1RrTklHZmhzc3pGVkdGcWhVSVltc2VNY1FkMURWOWRjaXhp?=
 =?utf-8?B?dlliOWlFbWlkREVURW04RU13cUJOQlN1TTNwd1c4TmthNnB4Q2NRT1VFaWkx?=
 =?utf-8?B?WUpwMUlBQWR1RndPeS9OM3ZnRTBaekMyT29tK3QzRUp3OWZIbG8rR0lSNFR0?=
 =?utf-8?B?eGJJcHRjWTlmanBUbDVpSmJZbGU2VkNaSHZ3a3BpYmNic1djT1RxS0t6MmJY?=
 =?utf-8?B?d2ozUGNvbnhZZzBuNThxVDVBQkZWWE80SThuYmVJY0lmTjB2V0xBdGRrMEtq?=
 =?utf-8?B?cVM0ejdLeDlXSUgvY25FMlhqaWFzMk0waFRRU0pSbHVrSDgyWDFyZDhFemRC?=
 =?utf-8?B?UjJPQ2ZkcW1rdWRtZ3NuYWtyMUdLMkxWUU5XVXVyYUw3d0g1bG8wWTF0ZjEv?=
 =?utf-8?B?TDJzRyszVW8vYmNYMlVxR0JtdWhxeVM1MDZxVWI3ZVRWZ0dYOFQ3cisvSmtu?=
 =?utf-8?B?ZEthU0pOcy9Pd0FNVDI2bnhaa0lrQTdlSC93QkhzLzBXZVYzbVF3RVBGRllF?=
 =?utf-8?B?d09qRXE5VUY4QWRIVWJ0S3hNbmJOWDZYZHRpckRWanlnSjhQbjBGd2FKdmNs?=
 =?utf-8?B?bTZ1T3liVnQ0V0Q0T0VBZ3RZT2ordTczaHNqU3E1a2d1blVxR3hrS3hLNnl0?=
 =?utf-8?B?WHdMdERtcUk1eWVDN1pWekswZ0dnZEQ1U0hsbk8renNHaTd5U1Nna0t6aXJZ?=
 =?utf-8?B?UjBLRyt0Q0NhZ1Z4WkZCWmxNY01sd21kNldpM2VFVE0wT0UvTHVDMExsR1dh?=
 =?utf-8?B?OVZoZVFPeWhaR2NwRU1lcEJ6bGQ3M0F2NGU2aGhtTFhQZHMzZlJrQ3J3VFJE?=
 =?utf-8?B?RmNWWlNkaEtKcnQwR1V0VjdhTDZ0bW5wVkVCWitRMXlBSm1neW0za1ZrRG1C?=
 =?utf-8?B?b3NJTndyeE8vZFIrUlFueVA5dEM2VW5iZ04xQWtMZCtUWVdDWVJGazV3Slpz?=
 =?utf-8?B?K0tUbTdXQWJoalVydzNwS3BaMzZoQjJqbFJ0V2t0QzcvZTV1RHh1OEU1L3lO?=
 =?utf-8?B?STk2VFhMcE5KVWJicXVOK0R3NldjeUtpR2JWUzNnMjl4MWdKN1RIa0dBZDRZ?=
 =?utf-8?B?eG9lRUQ3Yys0WENPWUtRZUZaZkkxeTVybklCQWlIZzlSY0YrQ2dERi9QSnBS?=
 =?utf-8?B?Mlo5NWhWRm4vOGZINFROSDUrMHZHUHZTMG9aZ1VSb0YzeUJLK1U3WGNMbWdy?=
 =?utf-8?B?bDl1UVlQQmwrWEJaN0JpTGxTQ1oxWWhIc0ZHbmo4YzJwRm5USVJTZEUzMVRX?=
 =?utf-8?B?ZXhVZGgveVVCMVI1Y2x3cC82bDJ3N2liRTFZa2UwdU5OZ1VTdGpRVC9NR0kx?=
 =?utf-8?B?SFRpd2FyVmY2VGJHckRrK1Z2UnRqRzhqYUJpeThXcGlNTTBwWktPbHdpamxP?=
 =?utf-8?B?T2VFRTc4MnVHMnFMZmk1dXlSaTZUdkt6T29raS9vUnA4eUplWjFwSHp4YjQz?=
 =?utf-8?B?YkhXVExKTzB5ZURJQTFQa21iSHdlZVFEcjhCS2ttZVJqUGZNcWwwLzYva0VV?=
 =?utf-8?B?TFVPNFBOWk5rRUk3elFJa2hGTGtxdUt4UnJlQ0FVeHoxRjBpTS82NHdIK1JG?=
 =?utf-8?B?NFpnK1JYWWNqaUhJUXgraWNRVmdQNW1Kb0NBbUxNaDIvOEp2SlEzTE11NlNa?=
 =?utf-8?B?cnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c09ab600-4021-46aa-62da-08dab0931f8f
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 22:58:36.3768
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tzhVCJpjNPPdDBb4Tz8VLQBoep6bkiHoAc1lYsdU2S+lsiqM5TlyJEwF9YHQAEJt5IefRE7VzNfEORTGT7fEla9vmP76VmmKLkeyk9cc9qQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6354
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/14/2022 8:10 AM, Joe Perches wrote:
> On Tue, 2022-10-11 at 14:46 -0700, Jesse Brandeburg wrote:
>> On 10/11/2022 4:16 AM, yexingchen116@gmail.com wrote:
>>> __FUNCTION__ exists only for backwards compatibility reasons with old
>>> gcc versions. Replace it with __func__.
> []
>>> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
> []
>>> @@ -4820,7 +4820,7 @@ static void iavf_shutdown(struct pci_dev *pdev)
>>>   		iavf_close(netdev);
>>>   
>>>   	if (iavf_lock_timeout(&adapter->crit_lock, 5000))
>>> -		dev_warn(&adapter->pdev->dev, "failed to acquire crit_lock in %s\n", __FUNCTION__);
>>> +		dev_warn(&adapter->pdev->dev, "failed to acquire crit_lock in %s\n", __func__);
> 
> Trivia: I suggest
> 
> 		dev_warn(&adapter->pdev->dev, "%s: failed to acquire crit_lock\n", __func__);
> 
> As almost all printed uses of __func__ use a form like
> 
> 	<printk_variant>("%s: message\n", __func__);
> 
> not
> 
> 	<printk_variant>("message in %s\n", __func__);
> 

I agree with Joe. Please fix this message up to use "%s: ...", __func__.
While at it, you might mention this fixes commit 226d528512cf ("iavf:
fix locking of critical sections") which introduced the use of __FUNCTION__.

Thanks,
Jake