Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     John Garry <john.garry@huawei.com>
Cc:     <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
        <jinpu.wang@cloud.ionos.com>, <damien.lemoal@opensource.wdc.com>,
        <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linuxarm@huawei.com>, <yangxingui@huawei.com>,
        <niklas.cassel@wdc.com>
Subject: Re: [PATCH v6 0/8] libsas and drivers: NCQ error handling
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1czap26t2.fsf@ca-mkp.ca.oracle.com>
References: <1665998435-199946-1-git-send-email-john.garry@huawei.com>
Date:   Mon, 17 Oct 2022 22:40:29 -0400
In-Reply-To: <1665998435-199946-1-git-send-email-john.garry@huawei.com> (John
        Garry's message of "Mon, 17 Oct 2022 17:20:27 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/P17qjuJcGZ/Cp33xKGq3bltd1ygU8R1N6pKTNNoAGJXhLt7vM5OCn6icYcT?=
 =?us-ascii?Q?TnrgFjiJlIINOsJoD+SnDPu7DAnmFkZDaSMEIS3HJ3/ul56vEvoUV0PdUpTg?=
 =?us-ascii?Q?CMZub070seDgc1oEthp3iIluHcufqWiSvyseXvFhJF9lwiOiqSXlOEo1TI8v?=
 =?us-ascii?Q?JUkt3hTfCNcxNep/yPnIaSFfsIRrYV4s/raLmiUo71//v9SGYNgGNA0kO+w7?=
 =?us-ascii?Q?wXVMN8KjENJoFHJjpVyTPPUP//h9O63GlWe1f6XfdPmdjDSnabsT7IqyaPkV?=
 =?us-ascii?Q?Ec6SwL657A9+dA6TwlsCEmDMtyAHdC90KIb1fq8oWY9G1HvaafrhU3ZLeYoK?=
 =?us-ascii?Q?uSiH+ldPtvztA1XbMtVFB7Jz9rpwgKSayQL5Uic5S0lTg7MYjytuVzi7nJVq?=
 =?us-ascii?Q?zKkqF3cZMdw+r181gtXPXeyJ0ke6UZaL3Iptgflv3QWdKjDxeFBQfpZPGK9I?=
 =?us-ascii?Q?cfomfgWipwufCvjp8cdt3g0MYwPhGo8zHiSpGatWTK3b770cTZ/GmLHCHiaM?=
 =?us-ascii?Q?uX7LPZiAR8snPZRAxPzyIUxKRebkoyD0n2jXIRolXcJuSgZjWZweMQAsjYgK?=
 =?us-ascii?Q?zKok1857FWY3Dvl2YDwS/1hprPu8A5t6uhFJCkWuwtSqIA7PVKwgo278nxWa?=
 =?us-ascii?Q?oLFWAAmA5dXtHMZ3wthKY9xDY7wBNVRo8CA1t0feUtkg1Ptt/ZuHtP3UUsou?=
 =?us-ascii?Q?epZNWEY2/ynka5emc3tQCz9s/DtvPKi66jEiB0up7KjJWwSFQB2XRLB4BfbP?=
 =?us-ascii?Q?CDuCDl0TL2+yAUDvUn2MnbAPSeblsIWZuE5LBJciMQ2GOhsnhvKAY2Mtn9V4?=
 =?us-ascii?Q?f5YtrPFZgQ3IREy3yV9xvsIZTpPGUB9FsxoNy2qYdpyGJhu2qzspPM4rZE6B?=
 =?us-ascii?Q?xywAZ2EyQ2mvYvSbj78I+YzBabMRJbki8IIrhjrzHlT3vlk1pFyuQNHPq87S?=
 =?us-ascii?Q?E0AtEBcWcvhEDCnjT7CgBWfh87Mq+2/omUW2arK5U0WAKSMdjDKJk2fYl31y?=
 =?us-ascii?Q?9kEVASK+pS/Sba3rpnXSn+Xp0U3/CwRVzvzZExVO9dj6YMBnfeywBSySYzqO?=
 =?us-ascii?Q?8bpRuXrUyKIlhyxCWPO1BjCxp+DwMZhADflSd2mzaD+keAEkr0szPR8Sowvy?=
 =?us-ascii?Q?f0zIY8wA3mj8nIEgJSb/BZrKgjmLzD8DV0EIsuvQVHZ7/iF85E7u88SOhdBK?=
 =?us-ascii?Q?1/C2ushbpRFUtKBVav4WHxYYA9pZJU4WHOGI46jkVAxVvYoFitkEbQv7MkTI?=
 =?us-ascii?Q?2ihMdobKERNXcCaXsrDabN0Ci6i+Rc9AsRWxiQ1jDa850ZaPqtSKC5JURmSM?=
 =?us-ascii?Q?IZnt0CQ/jciKxxZjlmAQmxJ/Wvb3immZuWeVt1T4FxA5P6jGp6ZNFwuSjyZE?=
 =?us-ascii?Q?CiIOnLY8J0La/wWPBUs1eEbiXWQaGHNQwPNF96ByY8+lPniD9Zm55lpsT1wf?=
 =?us-ascii?Q?YCUBuNla03Bklo4rHxzGiNgmeLEQj/kruzManF0XH8KExla1RmeEcsupLzy2?=
 =?us-ascii?Q?5cBB+I90R0ZtbDlup0paERvJxiIsjvhF9aC3hTiNnEi22QkLEmVWKv/uFp92?=
 =?us-ascii?Q?SYiJ89qAdlpBcBWf/R/yYBLjK59cWgGaz5wAIOrvrcEnSmKqwoiUzGdYxobs?=
 =?us-ascii?Q?DA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cff52e0a-613b-4c18-395e-08dab0b22052
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 02:40:32.1459
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /wrDYWvYlvHGEWwkNtLBVv8/+QxX8w1Gr3aQFrWLR52F5EqSLR0upw2unLb72P6MJ3kgFDwfRWmYCj815ZwOqZcIUwgEMN2m772RCTQxpoo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6347
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-17_13,2022-10-17_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 bulkscore=0
 malwarescore=0 phishscore=0 mlxlogscore=788 spamscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210180013
X-Proofpoint-ORIG-GUID: 7AQngRA6-HvPfP-AO_7D8GQ0jInRoN8S
X-Proofpoint-GUID: 7AQngRA6-HvPfP-AO_7D8GQ0jInRoN8S
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


John,

> As reported in [0], the pm8001 driver NCQ error handling more or less
> duplicates what libata does in link error handling, as follows:
> - abort all commands
> - do autopsy with read log ext 10 command
> - reset the target to recover, if necessary

Applied to 6.2/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering