Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp5394959rwi; Mon, 17 Oct 2022 21:03:32 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6ympKekbz4Ed+aVhIQt725veEWu1+TEV+9Psy1zygNtgqwuoj+Q5lGghOZdqbFRyI7XOY0 X-Received: by 2002:a05:6402:2409:b0:456:f97b:3794 with SMTP id t9-20020a056402240900b00456f97b3794mr805815eda.145.1666065812686; Mon, 17 Oct 2022 21:03:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666065812; cv=none; d=google.com; s=arc-20160816; b=rsuOMIR9EytfziZztC1A1na2XD9zinatMUwW0LmyJNviEJgA/KwdH2UGmZO64vFmnP uVaC6PC352JQLlgzEq/CywW7+/OWdS4mA/jOGbBVK7dPOk5VgBm+m0SaJzsKQNPtjan3 Hl92tOjop19qWhjqaI/3jq6QiOxNi4EBxULOL4WAVenLIQwTJhFCdXpglsXoHbG1tkh5 mCRvlpfWxOKEOGnL009fCitmjRj2c/MwsoSiePx/K1mM25mmisuyuTENd9NXVRZEvSqr WGsCOpDQcGW7eIOoK8GChzk/NJ52+s4nawt1ocyz42y6HW3q2z9ytAc+Tj4UNguVS8xM GwPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dXbOF6y7Fymm6S7gnJoAODCMCuVVw69/y7GC1AGShNs=; b=EzMguO0CJOlMflX0h/rWjUX6g5D7igh5SpJvJSa8PCqiRO8u0H84qnSzyIeNK8ufXu 1xI6nyKG7pxXEqAHJJ6DM6onJzp/BaRb5MBBqnGoAsYCvkNyATcCpoi9t4iPQNdPqrQO M9SKkyTklf7iTrOON0tyg+If9N6CVdD5CSN6xdLjaZ3mHQHikYPG9jBZZ2S3Q9WR+IjV 4m/qZzyI37dHzTFxeT1kSjnN4Mqy03mzVyCvTDA9cOfOZo/yrgS0B7tmuf1LG/Pz0kRy hkVlmCmjx9oBeqLfWBE6+gjKaf1+S6w3181NpI93rFVyPpELcDKf6b3LCCGQ7oxQK9IX Lxrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2022-7-12 header.b=IYHe1LFE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d25-20020a170906175900b0078e0e866a4dsi8160674eje.682.2022.10.17.21.03.06; Mon, 17 Oct 2022 21:03:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2022-7-12 header.b=IYHe1LFE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229602AbiJRDwY (ORCPT + 99 others); Mon, 17 Oct 2022 23:52:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229574AbiJRDwW (ORCPT ); Mon, 17 Oct 2022 23:52:22 -0400 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 992D81D2; Mon, 17 Oct 2022 20:52:16 -0700 (PDT) Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29HNYXqk019050; Tue, 18 Oct 2022 03:52:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2022-7-12; bh=dXbOF6y7Fymm6S7gnJoAODCMCuVVw69/y7GC1AGShNs=; b=IYHe1LFE5b8KxNjMafWDYPrD+PxPezpPKUE11CFb/orXIfrn6pJlL98DVGNpi1hRiOPv UTtzSp0wpgFwY4u+Ejhy7oxFBFc9OkixdeR4HYnZBPoYh7Q2dnahVzmf5NSr6IyUKNL7 98Vr/a30JG9u1iBLW/x2r2Fnrqj14NdmZ6MbEVlqIm5YlBh1H3CcZaotxKAhKJQ5hWDQ iw4GGgYjytGZrD3P8u7yWXasT95VOyDE1U8WUaZFpzGOyKJp8hcnjJ1nV1L6rsL8cS88 AA5TrtfhiTlbbM+eiVHHgIi9uHlDv/ESLY4vHn+3W9/DhSXdoI1rSxux1960xQuq6UnI sw== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3k7ndtds2s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 18 Oct 2022 03:52:10 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 29I3msCr036409; Tue, 18 Oct 2022 03:52:08 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3k8htff2b4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 18 Oct 2022 03:52:08 +0000 Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 29I3q8fc029581; Tue, 18 Oct 2022 03:52:08 GMT Received: from ca-mkp.mkp.ca.oracle.com (ca-mkp.ca.oracle.com [10.156.108.201]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 3k8htff2b0-1; Tue, 18 Oct 2022 03:52:08 +0000 From: "Martin K. Petersen" To: Muneendra Kumar , James Smart , Rafael Mendonca , Dick Kennedy , Hannes Reinecke , Gaurav Srivastava , "James E.J. Bottomley" Cc: "Martin K . Petersen" , James Smart , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH] scsi: lpfc: Fix memory leak in lpfc_create_port() Date: Mon, 17 Oct 2022 23:52:06 -0400 Message-Id: <166606442644.2366633.17731582434457392560.b4-ty@oracle.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220916035908.712799-1-rafaelmendsr@gmail.com> References: <20220916035908.712799-1-rafaelmendsr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-17_13,2022-10-17_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 suspectscore=0 spamscore=0 adultscore=0 mlxscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210180020 X-Proofpoint-ORIG-GUID: aJ2bWeYo6InoIuBytI8D5GRzxwEhAC-D X-Proofpoint-GUID: aJ2bWeYo6InoIuBytI8D5GRzxwEhAC-D X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Sep 2022 00:59:07 -0300, Rafael Mendonca wrote: > Commit 5e633302ace1 ("scsi: lpfc: vmid: Add support for VMID in mailbox > command") introduced allocations for the VMID resources in > lpfc_create_port() after the call to scsi_host_alloc(). Upon failure on the > VMID allocations, the new code would branch to the 'out' label, which > returns NULL without unwinding anything, thus skipping the call to > scsi_host_put(). > > [...] Applied to 6.1/scsi-fixes, thanks! [1/1] scsi: lpfc: Fix memory leak in lpfc_create_port() https://git.kernel.org/mkp/scsi/c/dc8e483f684a -- Martin K. Petersen Oracle Linux Engineering