Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932100AbXF1XGu (ORCPT ); Thu, 28 Jun 2007 19:06:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763604AbXF1XGn (ORCPT ); Thu, 28 Jun 2007 19:06:43 -0400 Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:48528 "EHLO the-village.bc.nu" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1759911AbXF1XGm (ORCPT ); Thu, 28 Jun 2007 19:06:42 -0400 Date: Fri, 29 Jun 2007 00:12:44 +0100 From: Alan Cox To: Roman Zippel Cc: Andrew Morton , Geert Uytterhoeven , Heiko Carstens , linux-kernel@vger.kernel.org, Martin Schwidefsky Subject: Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM Message-ID: <20070629001244.3ce09917@the-village.bc.nu> In-Reply-To: References: <20070628034321.38c9f12b.akpm@linux-foundation.org> <20070628133715.GA4343@osiris.boeblingen.de.ibm.com> <20070628110644.a530cfef.akpm@linux-foundation.org> <20070628113819.c24e592d.akpm@linux-foundation.org> <20070628132947.e3378811.akpm@linux-foundation.org> <20070628232537.02ced21c@the-village.bc.nu> X-Mailer: Claws Mail 2.9.1 (GTK+ 2.10.8; i386-redhat-linux-gnu) Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 725 Lines: 17 > > check_signature is relevant for anything with MMIO space (for example you > > can legitimately want to check_signature a MAC68K Nubus ROM). > > A generic check_signature() is a little difficult if we have separate io > functions for every bus. Does M68K implement iomap() and pci_iomap and friends yet ? check_signature has fairly few users so moving to be iomap based wouldn't be hard if that was a problem. The other option would seem to be bus->check_signature() ? Alan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/