Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [RESEND PATCH v2 1/5] dt-bindings: firmware: qcom-scm: Add
 "allow-multi-call" property
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Guru Das Srinagesh <quic_gurus@quicinc.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     David Heidelberg <david@ixit.cz>,
        Robert Marko <robimarko@gmail.com>,
        Rajendra Nayak <quic_rjendra@quicinc.com>,
        Elliot Berman <quic_eberman@quicinc.com>
References: <1661898311-30126-1-git-send-email-quic_gurus@quicinc.com>
 <1661898311-30126-2-git-send-email-quic_gurus@quicinc.com>
 <453bce1e-e2d3-bf26-9954-774e1e267d82@linaro.org>
From:   Sibi Sankar <quic_sibis@quicinc.com>
Message-ID: <2713bacb-922d-475c-e700-3107d4ebac90@quicinc.com>
Date:   Tue, 18 Oct 2022 11:26:02 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <453bce1e-e2d3-bf26-9954-774e1e267d82@linaro.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hey Krzysztof,
Thanks for taking time to review the series.


On 8/31/22 1:30 PM, Krzysztof Kozlowski wrote:
> On 31/08/2022 01:25, Guru Das Srinagesh wrote:
>> For firmware that supports it, allow multiple SCM calls to be passed
>> down to it by removing the serialization lock in the SCM driver.
>>
>> This patch is based on this YAML conversion patch [1] that is in-flight
>> currently.
>>
>> [1] https://lore.kernel.org/lkml/20220708090431.30437-1-david@ixit.cz/
>>
>> Signed-off-by: Guru Das Srinagesh <quic_gurus@quicinc.com>
> 
> Thank you for your patch. There is something to discuss/improve.
> 
> If you make a resend, at least be sure you Cc proper people. Use
> scripts/get_maintainers.pl to CC all maintainers and relevant mailing lists.
> 
> This was not Cced to device tree maintainers, therefore it has to be NAK-ed.
> 
> 
>> ---
>>   Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> index 9fdeee0..e279fd2 100644
>> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> @@ -70,6 +70,11 @@ properties:
>>     '#reset-cells':
>>       const: 1
>>   
>> +  allow-multi-call:
>> +    description:
>> +      Specify this flag to remove SCM call serialization. Need to ensure that
>> +      the firmware being used supports this feature first.
> 
> Missing vendor prefix, missing type.

Ack

> 
> Isn't support for this obvious from compatible?\

On further testing it looks like the property can't be truly enabled on
sm8450 yet so I'll drop the patch in the next re-spin.

> 
> Best regards,
> Krzysztof
>