Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH V3 1/1] x86/sgx: Add code to inject hwpoison into SGX
 memory
To:     Thomas Tai <thomas.tai@oracle.com>
References: <20221017223305.578073-1-thomas.tai@oracle.com>
 <20221017223305.578073-2-thomas.tai@oracle.com>
From:   Miaohe Lin <linmiaohe@huawei.com>
CC:     <tony.luck@intel.com>, <dave.hansen@linux.intel.com>,
        <jarkko@kernel.org>, <reinette.chatre@intel.com>,
        <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>, <naoya.horiguchi@nec.com>
Message-ID: <4a7c4187-5df3-f153-189b-62fae7de4cd2@huawei.com>
Date:   Tue, 18 Oct 2022 14:21:12 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <20221017223305.578073-2-thomas.tai@oracle.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/10/18 6:33, Thomas Tai wrote:
> Inspired by commit c6acb1e7bf46 ("x86/sgx: Add hook to error injection
> address validation"), add a similar code in hwpoison_inject function to
> check if the address is located in SGX Memory. The error will then be
> handled by the arch_memory_failure function in the SGX driver. After
> injection, the action_result() will print out the page type and the
> action taken.
> 
> Signed-off-by: Thomas Tai <thomas.tai@oracle.com>

Many thanks for your work. The patch looks good to me.

Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>

Thanks,
Miaohe Lin