Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Madalin Bucur <madalin.bucur@nxp.com>
To:     Sean Anderson <sean.anderson@seco.com>,
        "David S . Miller" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Camelia Alexandra Groza <camelia.groza@nxp.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Sean Anderson <sean.anderson@seco.com>
Subject: RE: [PATCH net] net: fman: Use physical address for userspace
 interfaces
Thread-Topic: [PATCH net] net: fman: Use physical address for userspace
 interfaces
Thread-Index: AQHY4kV4CTBQ6TpejkOf0p9IZqtcYq4TtZCQ
Date:   Tue, 18 Oct 2022 06:45:56 +0000
Message-ID: <AM6PR04MB3976D736CB1EFD55F0224E0BEC289@AM6PR04MB3976.eurprd04.prod.outlook.com>
References: <20221017162807.1692691-1-sean.anderson@seco.com>
In-Reply-To: <20221017162807.1692691-1-sean.anderson@seco.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gIWs/Oqi72FqMTdmCuKjE4K5LwR+rqjqE1xGxkgOVI0M+b7iWcB0AYDvVM2M?=
 =?us-ascii?Q?2S2H1x905X/rgWOpoEBrnOD90bJ1u0JOWzP5HzasCLUUHAUUYFNNgyKbj1da?=
 =?us-ascii?Q?KOblq/jUCrMYAAuH+an2UIVMFqo+KM54Wgu6X21M5BGZt7LwFtz7DB+rvbWg?=
 =?us-ascii?Q?y5sjjfkyusq5sBa8Pnwa1XXYmaSqeN+p/11YO04SHvBq75wnoiN06Syuecjj?=
 =?us-ascii?Q?RDrG+jdbUoubpseXh+HOwCAND9JdLvBZ7ngkP9L+VkkYwA1nqQHTUJ7RTcHC?=
 =?us-ascii?Q?2RQu/98mDTNPlmDQJgmh0Ogm87rUexmvsWqwBEHYHltw6EDU2Ki/7J37E/vz?=
 =?us-ascii?Q?ebuZJXptUe/M2AAU75veHKRND3EuOnsLIufasQ/SH8/Um+I8/TtAjIceiu3u?=
 =?us-ascii?Q?jTeH2GZY4xs/BUxWNGzvTlIGiOhYeexmSedo9F0ODTGXYsSqPdMULQO1CdRA?=
 =?us-ascii?Q?7OUq4lYmu11/e25YNbXwxVDsrB//EhUNWv7qdeY5ZVLy60xIU5GAbWHTRYP4?=
 =?us-ascii?Q?xGhjoMeKei7y+f5s3qJQY7baKuGwEULQzgOv8ZSfq+BNvBMFvMhc3GjB9XOp?=
 =?us-ascii?Q?qv7l/zNcyhF/FydwR6zPxYOfXP8HeMjAZlyb+h4CC4VF7hyqeBnZypMpXVzA?=
 =?us-ascii?Q?r5mZJmJOkfbQxt0867G5KQmzVCYhT3Y34T2b3b7kryzz4d4t3O2qqyERe/uR?=
 =?us-ascii?Q?IgQ0q0EnwUdJ9GSFDCebkcNz3k1qjMHgQ1Exl2ERhVMyBtKc+AV2bq83et8Y?=
 =?us-ascii?Q?hhpVK+ddjo0XpSwVAfBGc9TrmjZreMrt/cjb04N2s/OGgcSbSOu0eE1kCk9z?=
 =?us-ascii?Q?pJyyq9jM/ovFlQHp33NM/RhgblumKxEN40MFG4LXrCcIqq3q7jVdajBO1wh9?=
 =?us-ascii?Q?yrNJnTwIcgbheRCw783qHBdct5xh7ZU67vSG26H9isIPpBD0OH42D62fmWVu?=
 =?us-ascii?Q?Tj30bT3cwN473WHbJ3WAeBDCt2XoKkn3QF0G4NiVEBWC9/ivWxaOj8Gezj5X?=
 =?us-ascii?Q?Ymw+025PPQzU/dnde4OII6pHXefHiOTiVFtKOn0dkDMoRCm61EjzsD+ZU2US?=
 =?us-ascii?Q?E4hconJxmeeuZF2QHCNiZ0GDwj+UhkQl/pDqTUjRqv+01IjxM4OzUO1sKrHS?=
 =?us-ascii?Q?PH4FT+N22uDV//zlZO62AcX2co/107ZUiVUVQfLaZxAIWE7w+uiJObjTfs3j?=
 =?us-ascii?Q?ttsivi2iPs7DJYBXsVz/aKkTf4mpr4phai+K0Srdvzd8c88K+MrmEKcw+SXG?=
 =?us-ascii?Q?KAgclcoHJNqXXuGZ2+XLeJKtuj24Jvc2W6lnQ2rEzG0PnDM/cJqUxPX9+4nk?=
 =?us-ascii?Q?Y0cjCbG1MSZyJpsVLo4S1WXuFM+zR+onjWIeDZ4TQhw+McTHi17lTe+NdRVs?=
 =?us-ascii?Q?GFz6q+4yDEJ1OCIuq339fnN9KfgqrkkazUNsbYIVWnfojDubwlA748GktzX9?=
 =?us-ascii?Q?pDv0xWF+Kkoh8QPrSjB7aA2Fq8pa4GMswDKUwiwJLsZky0IYccK/WtEp1tUG?=
 =?us-ascii?Q?7oDOJIwm58feGPoN8qutZfntO1VBlgSMkbsLu8LwuHF4tEhsK6n0EOvdESxp?=
 =?us-ascii?Q?HEGe6G4wFBRZxCkaB5bf/iHD3wkW/BWYiwbNawCq?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB3976.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ff898856-0b48-4357-0ea8-08dab0d4691f
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2022 06:45:56.9076
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YBdqOfmFPkxBgP7W+TpaRIQYfOD4i+dKjKEhSQyjdP+ChDCBzC82z011ftRi/BrYir8i2IhLOYTSR1Zs5CLitQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8532
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Sean Anderson <sean.anderson@seco.com>
> Sent: 17 October 2022 19:28
> To: David S . Miller <davem@davemloft.net>; netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org; Madalin Bucur <madalin.bucur@nxp.com>;
> Jakub Kicinski <kuba@kernel.org>; Eric Dumazet <edumazet@google.com>;
> Paolo Abeni <pabeni@redhat.com>; Camelia Alexandra Groza
> <camelia.groza@nxp.com>; Geert Uytterhoeven <geert@linux-m68k.org>; Sean
> Anderson <sean.anderson@seco.com>
> Subject: [PATCH net] net: fman: Use physical address for userspace
> interfaces
>=20
> For whatever reason, the address of the MAC is exposed to userspace in
> several places. We need to use the physical address for this purpose to
> avoid leaking information about the kernel's memory layout, and to keep
> backwards compatibility.
>=20
> Fixes: 262f2b782e25 ("net: fman: Map the base address once")
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> ---
>=20
>  drivers/net/ethernet/freescale/dpaa/dpaa_eth.c       |  4 ++--
>  drivers/net/ethernet/freescale/dpaa/dpaa_eth_sysfs.c |  2 +-
>  drivers/net/ethernet/freescale/fman/mac.c            | 12 ++++++------
>  drivers/net/ethernet/freescale/fman/mac.h            |  2 +-
>  4 files changed, 10 insertions(+), 10 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> index 31cfa121333d..fc68a32ce2f7 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> @@ -221,8 +221,8 @@ static int dpaa_netdev_init(struct net_device *net_de=
v,
>  	net_dev->netdev_ops =3D dpaa_ops;
>  	mac_addr =3D mac_dev->addr;
>=20
> -	net_dev->mem_start =3D (unsigned long)mac_dev->vaddr;
> -	net_dev->mem_end =3D (unsigned long)mac_dev->vaddr_end;
> +	net_dev->mem_start =3D (unsigned long)priv->mac_dev->res->start;
> +	net_dev->mem_end =3D (unsigned long)priv->mac_dev->res->end;
>=20
>  	net_dev->min_mtu =3D ETH_MIN_MTU;
>  	net_dev->max_mtu =3D dpaa_get_max_mtu();
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth_sysfs.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth_sysfs.c
> index 258eb6c8f4c0..4fee74c024bd 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth_sysfs.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth_sysfs.c
> @@ -18,7 +18,7 @@ static ssize_t dpaa_eth_show_addr(struct device *dev,
>=20
>  	if (mac_dev)
>  		return sprintf(buf, "%llx",
> -				(unsigned long long)mac_dev->vaddr);
> +				(unsigned long long)mac_dev->res->start);
>  	else
>  		return sprintf(buf, "none");
>  }
> diff --git a/drivers/net/ethernet/freescale/fman/mac.c
> b/drivers/net/ethernet/freescale/fman/mac.c
> index 7b7526fd7da3..65df308bad97 100644
> --- a/drivers/net/ethernet/freescale/fman/mac.c
> +++ b/drivers/net/ethernet/freescale/fman/mac.c
> @@ -279,7 +279,6 @@ static int mac_probe(struct platform_device *_of_dev)
>  	struct device_node	*mac_node, *dev_node;
>  	struct mac_device	*mac_dev;
>  	struct platform_device	*of_dev;
> -	struct resource		*res;
>  	struct mac_priv_s	*priv;
>  	struct fman_mac_params	 params;
>  	u32			 val;
> @@ -338,24 +337,25 @@ static int mac_probe(struct platform_device *_of_de=
v)
>  	of_node_put(dev_node);
>=20
>  	/* Get the address of the memory mapped registers */
> -	res =3D platform_get_mem_or_io(_of_dev, 0);
> -	if (!res) {
> +	mac_dev->res =3D platform_get_mem_or_io(_of_dev, 0);
> +	if (!mac_dev->res) {
>  		dev_err(dev, "could not get registers\n");
>  		return -EINVAL;
>  	}
>=20
> -	err =3D devm_request_resource(dev, fman_get_mem_region(priv->fman),
> res);
> +	err =3D devm_request_resource(dev, fman_get_mem_region(priv->fman),
> +				    mac_dev->res);
>  	if (err) {
>  		dev_err_probe(dev, err, "could not request resource\n");
>  		return err;
>  	}
>=20
> -	mac_dev->vaddr =3D devm_ioremap(dev, res->start, resource_size(res));
> +	mac_dev->vaddr =3D devm_ioremap(dev, mac_dev->res->start,
> +				      resource_size(mac_dev->res));
>  	if (!mac_dev->vaddr) {
>  		dev_err(dev, "devm_ioremap() failed\n");
>  		return -EIO;
>  	}
> -	mac_dev->vaddr_end =3D mac_dev->vaddr + resource_size(res);
>=20
>  	if (!of_device_is_available(mac_node))
>  		return -ENODEV;
> diff --git a/drivers/net/ethernet/freescale/fman/mac.h
> b/drivers/net/ethernet/freescale/fman/mac.h
> index b95d384271bd..13b69ca5f00c 100644
> --- a/drivers/net/ethernet/freescale/fman/mac.h
> +++ b/drivers/net/ethernet/freescale/fman/mac.h
> @@ -20,8 +20,8 @@ struct mac_priv_s;
>=20
>  struct mac_device {
>  	void __iomem		*vaddr;
> -	void __iomem		*vaddr_end;
>  	struct device		*dev;
> +	struct resource		*res;
>  	u8			 addr[ETH_ALEN];
>  	struct fman_port	*port[2];
>  	u32			 if_support;
> --
> 2.35.1.1320.gc452695387.dirty

Thanks for the fix,

Acked-by: Madalin Bucur <madalin.bucur@oss.nxp.com>=20