Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b2be77b0-bafb-0519-33cb-359d83ded4d8@leemhuis.info>
Date:   Tue, 18 Oct 2022 08:33:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [REGRESSION v6.1-rc1] rtc: cmos: rtcwake broken on NUC8i7HVK
Content-Language: en-US, de-DE
To:     Kalle Valo <kvalo@kernel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc:     Mel Gorman <mgorman@techsingularity.net>,
        Bjorn Helgaas <bhelgaas@google.com>, linux-rtc@vger.kernel.org,
        regressions@lists.linux.dev, linux-kernel@vger.kernel.org
References: <87edv6mlow.fsf@kernel.org>
From:   Thorsten Leemhuis <regressions@leemhuis.info>
In-Reply-To: <87edv6mlow.fsf@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi, this is your Linux kernel regression tracker.

On 17.10.22 18:58, Kalle Valo wrote:
> 
> I upgraded my NUC8i7HVK test box to v6.1-rc1 and noticed that my suspend
> tests with ath11k were broken, the box never woke up from suspend
> automatically and I had to manually push the power button to trigger
> resume. This is the command I used:
> 
> sudo rtcwake -m mem -s 30
> 
> v6.0 works without problems and a bisect found this commit:
> 
> commit 4919d3eb2ec0ee364f7e3cf2d99646c1b224fae8
> Author:     Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> AuthorDate: Wed Oct 12 20:07:01 2022 +0200
> Commit:     Alexandre Belloni <alexandre.belloni@bootlin.com>
> CommitDate: Thu Oct 13 23:27:52 2022 +0200
> 
>     rtc: cmos: Fix event handler registration ordering issue

FWIW, Todd also reported this yesterday:
https://lore.kernel.org/all/967cfe4e2dba242352ccd1cd00bdbcfb48bdd697.camel@linux.intel.com/
https://bugzilla.kernel.org/show_bug.cgi?id=216600

And Zhang Rui provided a patch in bugzilla that should fix this.

HTH, Ciao, Thorsten

> And indeed reverting that commit fixed the issue and suspend works as
> before. Here's some info about my hardware:
> 
> $ dmesg | grep rtc
> [   10.884460] rtc_cmos 00:03: RTC can wake from S4
> [   10.888439] rtc_cmos 00:03: registered as rtc0
> [   10.888930] rtc_cmos 00:03: alarms up to one month, y3k, 242 bytes nvram
> 
> $ lshw
> nuc2
>     description: Desktop Computer
>     product: NUC8i7HVK
>     vendor: Intel(R) Client Systems
>     version: J71485-504
> [...]
>      *-cpu
>           description: CPU
>           product: Intel(R) Core(TM) i7-8809G CPU @ 3.10GHz
> [...]
>      *-pnp00:03
>           product: PnP device PNP0b00
>           physical id: 4
>           capabilities: pnp
>           configuration: driver=rtc_cmos
> 
> Do let me know if more info is needed, I can also test patches. But next
> week I'm travelling and do not have access to the box.
> 
> Kalle
> 
>