Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Oct 2022 09:22:57 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     netdev@kapio-technology.com
Cc:     davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Hauke Mehrtens <hauke@hauke-m.de>,
        Woojung Huh <woojung.huh@microchip.com>,
        UNGLinuxDriver@microchip.com, Sean Wang <sean.wang@mediatek.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Ivan Vecera <ivecera@redhat.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Shuah Khan <shuah@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Christian Marangi <ansuelsmth@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Yuwei Wang <wangyuweihx@gmail.com>,
        Petr Machata <petrm@nvidia.com>,
        Florent Fourcot <florent.fourcot@wifirst.fr>,
        Hans Schultz <schultz.hans@gmail.com>,
        Joachim Wiberg <troglobit@gmail.com>,
        Amit Cohen <amcohen@nvidia.com>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v7 net-next 3/9] net: switchdev: add support for
 offloading of the FDB locked flag
Message-ID: <Y05GQWYu0vM+bx5t@shredder>
References: <20221009174052.1927483-1-netdev@kapio-technology.com>
 <20221009174052.1927483-4-netdev@kapio-technology.com>
 <Y0gbVoeV/e6wzlbM@shredder>
 <d314ba738b12e28694a955de1301e906@kapio-technology.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d314ba738b12e28694a955de1301e906@kapio-technology.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?m43XdljETV1vhc6m6TnnbUL6ZsSkkmioK42u0yyIF7nsglUVMaYSb+8lpGdZ?=
 =?us-ascii?Q?t3BlfnBdmJj2zlnkFroop10PAZTrURzEm7fGvF4bDMJMrBkfTHHIaC/oKR/i?=
 =?us-ascii?Q?ByVZpCXVSJBhj+gey0PC2PLuMCZZODsIWBClFjfw/9yEHlCp9QZOmSd2e+5P?=
 =?us-ascii?Q?oQ9klGFPwUKUogvjotglI/iZpVqLnpLqW9oCp7yrvQEuBSHcSruUOmZ9Kv4e?=
 =?us-ascii?Q?PxASLB4cHLReDwB7Uhk3tWnyfTF85GW9gsQqL9lTAR4crh5ExCzvryfN7h/z?=
 =?us-ascii?Q?0sWe1j/YK1/4GhA1ZNTblpbUVgiD/BTU6TWYOHKUeTGFZpn7MLvz17ef86rz?=
 =?us-ascii?Q?MVFT+bWBFNbBcUJgu+/nbXLPqLlDKsxMiuzd0RZGb/pfvDzqoMAAk+LfB6HJ?=
 =?us-ascii?Q?3NLTrc+GzZLpM3eOWXB3LGZM/loFjzdUW+gz0aSHKaktxsuaL8PFVXUl1LaX?=
 =?us-ascii?Q?tFu4ygru0FQBRUcG69HydTKNOHmAMTyKDbzXzNjCJTwFxVcdGgWiunoIPqFS?=
 =?us-ascii?Q?wdXZlzfnfd/8d+07Ix3iOfwTkvKbDunCun8HMd6SB7nV6kWljoYGuNdlr6F3?=
 =?us-ascii?Q?KX7rUVO9wPnKPkC760f0rLd15iiS7zzg6cm2cfHBHyh4+3M+7YMfYD+A0bmb?=
 =?us-ascii?Q?QNS3kMrpTeETZ2N/Qnf7pTyeIuYOH9wq5sQhksYmMJoouazCg8vbStxbXaX3?=
 =?us-ascii?Q?vGfQkzljF43yGIa6S6soqWA4tMXP+uWoPK3vt9B73tBSlZZ49jgoljo8bwyX?=
 =?us-ascii?Q?yPJ+0//bsdvOfWYLyzA0EpbCb71JWbPS+lFpkDGG6cTpaASiXNx3r7dq5FWr?=
 =?us-ascii?Q?+5uJZ9YAnmT6kjzb1kvuSOpiZymYTVpbNf/1DZbL+6qeATgosLxzuGRqZx3H?=
 =?us-ascii?Q?nuHPRIYFKLX4Ov5G9Ar9nO1XzsxcQgjVt3gAnon2sJ8Wi4lZeEKYuxm4dZ+q?=
 =?us-ascii?Q?Vxnfy++OoQRx8GdTA+RJHQLXkuipWME9dbPFEhdrdbjdDLN7v3PF5hTJQOYd?=
 =?us-ascii?Q?1SyHaIgHwvrErWxapRz1wqREPI6PHsTOUbktROcVJ6kVVcsYAdJh8IVV9fjw?=
 =?us-ascii?Q?8q0HeIzdDv6V/HAreBJC+NBZdmXtbynZqduqZKuXKjDn55I/HTLt1WYFnwPn?=
 =?us-ascii?Q?meVxuU+klLxkNxzkCstgEHZg4mt8WL0HuUOx6HPCvH2K46y0XigHJd3eQYpn?=
 =?us-ascii?Q?Nmx69xfHHt0ZS9wldHjO7VJDt4aBf1X8zmcVF7Ufsp8D/25tVw1CSI2/eagt?=
 =?us-ascii?Q?NjxITjB7kKn3saE70gZdoT0cyPsqK/+64mKkkwLVqbR1BDE48H5/Xc2M/xb1?=
 =?us-ascii?Q?XSIITtmOx8PTl65Pj0Yx2DSC6tNl8gkp7aLMmt7wZw1Jn9TuH+3Zju8siLSL?=
 =?us-ascii?Q?IqOLfmFa8ZkIud3XVLlVXm63RSACtmJw+32nExLqWZdFDbNZZaakSNvLwsud?=
 =?us-ascii?Q?uDK+3xAFe6dPvprdhOrx7ByciKMhw9Rekdv+C6zxw3il9t9pe1Qre/SDtGDd?=
 =?us-ascii?Q?7xPLQnTblfub6Cph/vClDeDuzJ4NxLEH/Se08H8gNfRsQort6tpfEWIjtmv9?=
 =?us-ascii?Q?D01yZpGsBUt6OBVXPTYUVuj8apbVLe3bimO8j/5q?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 55bda53e-f923-4b14-b651-08dab0d13711
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 06:23:04.6782
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: roVqlVWxHIKZzIDi0koUiHVOr3xfe4GOPeUT1aGmWQf5Wmbnjhd8dF+hYgJyjazBP/KAuuIXRZqnNrOYRYo72A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6265
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 13, 2022 at 08:58:57PM +0200, netdev@kapio-technology.com wrote:
> On 2022-10-13 16:06, Ido Schimmel wrote:
> > > diff --git a/net/dsa/port.c b/net/dsa/port.c
> > > index e4a0513816bb..eab32b7a945a 100644
> > > --- a/net/dsa/port.c
> > > +++ b/net/dsa/port.c
> > > @@ -304,7 +304,7 @@ static int dsa_port_inherit_brport_flags(struct
> > > dsa_port *dp,
> > >  					 struct netlink_ext_ack *extack)
> > >  {
> > >  	const unsigned long mask = BR_LEARNING | BR_FLOOD | BR_MCAST_FLOOD |
> > > -				   BR_BCAST_FLOOD | BR_PORT_LOCKED;
> > > +				   BR_BCAST_FLOOD;
> > 
> > Not sure how this is related to the patchset.
> > 
> 
> In general it is needed as a fix because of the way learning with locked
> port is handled in the driver,
> so as with MAB and also locked port in the future needing a non-zero Port
> Association Vector (PAV)
> for refresh etc to work, inheritance of the locked port flag is a bad idea
> (say bug) and shouldn't have
> been in the first place.

If it's a fix, then it needs to be submitted to 'net' tree.