Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp5601093rwi; Tue, 18 Oct 2022 01:09:45 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5mpn2rGHwYSplZLicqNR+nNw/zHhMaqE2XBxtx4Rtxmi2vPoFAiJImHS0htu0jYc5eHv3X X-Received: by 2002:a17:906:1b49:b0:78d:b7b5:71cc with SMTP id p9-20020a1709061b4900b0078db7b571ccmr1372625ejg.536.1666080585475; Tue, 18 Oct 2022 01:09:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666080585; cv=none; d=google.com; s=arc-20160816; b=RpiLp6v1evHXBxyh6kn/8S4IffkwMkJpNkAuF6QM4H9ikayiO7xqSMKt+oXxWUH9xb xkwoLsY/g72x/JoYIL1JlyuZ4uR1hQgHHtFfyHs5faUsmXbvNYo27Nh3SYMl6J9SD4wC AzQM1DUhsHyGVuVHLHt9TzafLYpAehNDUV1X8yKL4lLo0ZFVy1SFbigC2ls/Lsumrojy 5JuVBHbtdUuXDstpa+H+6k0L1UWX8QuLEGa4p9v+9TqEeOgKTQT1JbOPfwv+mlikdJED BZTZD+6tqvKZiPImfFLPwaYjl+cT/LgLvMvGJYvNKOr5VU5H7lrwURbW+vw3swc9CPub kTfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:message-id:user-agent :references:in-reply-to:subject:cc:to:from:date:mime-version :dkim-signature; bh=WzMYkZQlDVdQITrjYiTqieDryDU5cl4+R2pxvS45MzU=; b=Z7/UTGT77hdeEDsZKpTAD0M5q7e40HOC01V1z89UD2StGXboklkG7hZp1nP4TVZanw s7YTF8WMB9MPFoWbsei7VCQYPpnklpaFWp1/Ku3hyGT9h0+n7LamFqpt+Q9JUbix5QTO g7b2HT0nlbiq/i3vkfhlRUD5EOZ4vK1aKNy9rAb/4JK/bODAY0VDiG5o+N0/Lf1qOm7q n6XK4lub/3hbtUEazfvIGrVjtmxnzDzOoJO4CSbn2KZOU6qPWWkbxxfPINpvDdsrqBsZ pOfB0X+bYHOfy66QGQGUo+aUzDUPmcQkh7l2WJGyuIM3Io69PQKXNSEJIs7XuWoy5f+m GPDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2022082101 header.b=F7I4Sfcc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=walle.cc Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u8-20020a056402064800b00458cdba7a90si9389775edx.471.2022.10.18.01.09.20; Tue, 18 Oct 2022 01:09:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2022082101 header.b=F7I4Sfcc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=walle.cc Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229968AbiJRHbD (ORCPT + 99 others); Tue, 18 Oct 2022 03:31:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229729AbiJRHbA (ORCPT ); Tue, 18 Oct 2022 03:31:00 -0400 Received: from mail.3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 798F03C8CE; Tue, 18 Oct 2022 00:30:58 -0700 (PDT) Received: from 3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.3ffe.de (Postfix) with ESMTPSA id 722261D23; Tue, 18 Oct 2022 09:30:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2022082101; t=1666078255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WzMYkZQlDVdQITrjYiTqieDryDU5cl4+R2pxvS45MzU=; b=F7I4Sfccmz6nIRGL9Kq3UnF88c8QEloNI2fTBYVEv+6xzZPBw7/NAnkNk7mD7b3AJRXiym cnr5RYGD6F6pH+BbgONYeNraclMyg6kOOQvW9d6zr4vHTmXAM9ZLPFUOvjnvxBdx//kxky sYu+gCiqQtDqRhfVu2PEkw8HiaYn1Jckmp8uSpS6QQWZXnFSCuVj2mv5rDa/XZsLtvsEmX KfpwEYMmdwEv7Di4fDSeOSjGugFJ+zLDwsMdowAw2nV/3v7bU/ramcxqgw2di0aFTL0UNm DiV9sZfoU+YTQbcn3sO6+w2dtpVP15m9p9cF0H5elZBGiL9HNzEMhygXc4zkVQ== MIME-Version: 1.0 Date: Tue, 18 Oct 2022 09:30:55 +0200 From: Michael Walle To: Horatiu Vultur Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linus.walleij@linaro.org, andy.shevchenko@gmail.com, UNGLinuxDriver@microchip.com Subject: Re: [PATCH] pinctrl: ocelot: Fix incorrect trigger of the interrupt. In-Reply-To: <20221018070959.1322606-1-horatiu.vultur@microchip.com> References: <20221018070959.1322606-1-horatiu.vultur@microchip.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <2c88f0a4955202091bbdf6c5db4f18cf@walle.cc> X-Sender: michael@walle.cc Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2022-10-18 09:09, schrieb Horatiu Vultur: > The interrupt controller can detect only link changes. So in case an > external device generated a level based interrupt, then the interrupt > controller detected correctly the first edge. But the problem was that > the interrupt controller was detecting also the edge when the interrupt > was cleared. So it would generate another interrupt. > The fix for this is to clear the second interrupt but still check the > interrupt line status. > > Fixes: c297561bc98a ("pinctrl: ocelot: Fix interrupt controller") > Signed-off-by: Horatiu Vultur Tested-by: Michael Walle -michael