Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <48b5848c-e8f6-a6f7-ba1e-8c914374e6b2@amd.com>
Date:   Tue, 18 Oct 2022 10:06:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v2 0/2] pinctrl: pinctrl-zynqmp: Revert output-enable and
 bias-high-impedance support
Content-Language: en-US
To:     Linus Walleij <linus.walleij@linaro.org>,
        Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
CC:     Michal Simek <michal.simek@xilinx.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        <devicetree@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <saikrishna12468@gmail.com>, <git@amd.com>
References: <20221017130303.21746-1-sai.krishna.potthuri@amd.com>
 <CACRpkdYYvznEKQ0huj5XwNwghMP-FRw5e54Di9FLVdXdsFP3-A@mail.gmail.com>
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <CACRpkdYYvznEKQ0huj5XwNwghMP-FRw5e54Di9FLVdXdsFP3-A@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 08:06:57.2281
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: def1678d-3807-4b6f-e3c0-08dab0dfba1d
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT101.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6658
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/18/22 09:51, Linus Walleij wrote:
> On Mon, Oct 17, 2022 at 3:03 PM Sai Krishna Potthuri
> <sai.krishna.potthuri@amd.com> wrote:
> 
>> Having support for output-enable and bias-high-impedance properties
>> causing system hang with older Xilinx ZynqMP Platform Management Firmware
>> because there is missing autodetection feature.
>> When this feature is implemented, support for these two properties should
>> bring back.
>>
>> changes in v2:
>> -> Added stable tree tag in 1/2 and 2/2 patches.
> 
> Patches applied for fixes!
> 
> Thanks for dealing with this, I hope you find a proper way to make
> it work with all firmwares.

The way what pmufw team described is that driver will ask firmware if that 
feature is available or not. If yes, the current calls will be made. Maybe we 
could do it via module parameter but this is the cleanest solution for now.

Thanks,
Michal