Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp5719822rwi; Tue, 18 Oct 2022 03:15:02 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5ti7QDFqFW2CGgFMDE0n39eBLGZxLeTZNQhQ1HT+pzMlPmRVH8aa9ZTuAvYd1Mr7iHaxx9 X-Received: by 2002:a17:903:247:b0:179:b5e1:54b7 with SMTP id j7-20020a170903024700b00179b5e154b7mr2236417plh.84.1666088102470; Tue, 18 Oct 2022 03:15:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666088102; cv=none; d=google.com; s=arc-20160816; b=W2VjTyFgMjxBJrf7xWE/SPlsbcxovv0Hv9irN98SSsQ60ocz+algp4Uz88NXkUe06L tDiCvY4hsPW6AUIN4i1AYl2twWwLkraLadwQUayLLBWzfMRkTscm2mSDkeCYSRsMfLuC V65jGCMLCsnszfOM0CtwpuXVsjrWzopuT6aGKtizk/Ucct/F8BqCkFnSWISyk/vhF5Y1 r4+9JXMYOpoEo9uc2gf50Nh2XzOWTyqEmToidMEsoBYU89w/KCHy9tFZukpDfKmnsbLU UGh6SnpQLud3OcOv2qx6OAigmE6SrKJsmodaaGkxlw7eSGjbP4gNOay9lV4D6kVP6nMt IXjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zKUSHBzIV9AmjcAPIwH4d1e4/pivyZO+yk3jBrIXqik=; b=eOrkbyDwOyXgT2suuRTZc2WIscdQyBZFZLUmKH4Aef4X8e2BXd00ZE8eXai5ygrg0n 8KVz3Vh8O+/M8Kgv5eu49NJY4zIVSDcHm5RoHBthF5cknQbePljjMRQxaE/I4FmyVgJy B0VjCzhH4YRFWPx0pm6XFiQ4nmXC+/cg23mdzJX25YeVzlK31krnu9M1G4CeaZ4GGXJc Tq1/PTvfJDRH822eoPOh9qX+EiWLSuHgUXdIcCGt5JjQQlRxCyfYNpHfjpNxWWzTbUwe TnPFl6tP2tNuya7cxPQOCVJZ/KWoBopRBEKlaBTbRbZmMZzEFRd20p7POdnDEbYtpKyT Dhzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Og8qUuzd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i4-20020a170902c94400b0017a0c197f3fsi16989030pla.335.2022.10.18.03.14.50; Tue, 18 Oct 2022 03:15:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Og8qUuzd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229784AbiJRKJl (ORCPT + 99 others); Tue, 18 Oct 2022 06:09:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229753AbiJRKJi (ORCPT ); Tue, 18 Oct 2022 06:09:38 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79AD01A226 for ; Tue, 18 Oct 2022 03:09:35 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id f23so13361757plr.6 for ; Tue, 18 Oct 2022 03:09:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zKUSHBzIV9AmjcAPIwH4d1e4/pivyZO+yk3jBrIXqik=; b=Og8qUuzdDioBAnndTRdVzqW2TKX37JQVBINZ/GxEZMvHmg91nkbp/PJcaf8RpNdIEr CX+xnORcAVblgI6/GK7I1zT5c5+88KvTGhc96WQKY4nHKe4MQ34CBQjvxc4GiiK13BwG JbpG2Xjma0DFxR3gRlBpequA1KZ/aXUeyFs4o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zKUSHBzIV9AmjcAPIwH4d1e4/pivyZO+yk3jBrIXqik=; b=J0Dp0enzFWRcITXM3J8dvz21dllxt3nypxvgQfRVDSHXwMd/KLF1Oglvd3Tu/FATuw aJ8M4LzRxUY+OWXNqe8lvGL9s+hZzM4i+h/639Pp7aUQyZEtPDA1IKqsYOOEJdEJx8+F K1h8gD2pBmmFQOEtE4uQ4NZgaSwdmkBGOU5ok8xnt0ssJRp6FbpP9uS79a3SskxXKcjS 7QZnCgWxb1/+41lqQDKXXICWRTZPGXAyuPgN65fDWgFCQ8UKKoopK0D9+PtOsuHiG9To sjQTl/jXXiJXNA4S6PRyUfArzocyB4DQ19EEwsGvy9z70qBQjnC5W4LrWq7KOFQkevPL 3NBw== X-Gm-Message-State: ACrzQf1VZPCqCdywtjUCYvfPFU8elLv9hxn2guENE073uPWI1pGryJ5g SHomLvBy/6WJCTpO+Gkwzkc/wg== X-Received: by 2002:a17:90b:1c11:b0:20d:459b:ef0e with SMTP id oc17-20020a17090b1c1100b0020d459bef0emr38396657pjb.129.1666087774961; Tue, 18 Oct 2022 03:09:34 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x1-20020a170902ec8100b0017da2798025sm8337107plg.295.2022.10.18.03.09.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Oct 2022 03:09:33 -0700 (PDT) Date: Tue, 18 Oct 2022 03:09:33 -0700 From: Kees Cook To: Michael J Ruhl Cc: Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v3 0/2] igb: Proactively round up to kmalloc bucket size Message-ID: <202210180307.484A016FE0@keescook> References: <20221018092340.never.556-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221018092340.never.556-kees@kernel.org> X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 18, 2022 at 02:25:23AM -0700, Kees Cook wrote: > Kees Cook (2): > igb: Do not free q_vector unless new one was allocated > igb: Proactively round up to kmalloc bucket size > > drivers/net/ethernet/intel/igb/igb_main.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) Ugh, yay for my MUA vs commas. Sorry for any future typo bounce spam. :( -- Kees Cook