Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp5753255rwi; Tue, 18 Oct 2022 03:47:45 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4LTy+x/8yC6lOyJqXRUZ3PLNtK0mu8QJMUsENIxMezdiaR9MDTYN5HCD8LUMkgh3ooa/43 X-Received: by 2002:a17:902:6546:b0:17f:7888:58b with SMTP id d6-20020a170902654600b0017f7888058bmr2278943pln.140.1666090064809; Tue, 18 Oct 2022 03:47:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666090064; cv=none; d=google.com; s=arc-20160816; b=OWaeumhjiTw5Md3zbnxThBs3LRTjdWmZl0MbQiUA+gOdApR0/Sq3pFEaKbXg5FeyLE ybAYosxb8XzzL2oMHBoFilWoeL0BxQbg9cwfGr+FW4elX2hQlHTEn/xBx0sQn4KSQOxx amQldmabEVGtEYmkRXzAG6GzIAHOg2+OVTQEvyRN/4uH/isA5G7NGmeDo3V1rfuZmyqv m1JLn8WRWsyAVoF8KgObfwS0gxzO8n6ck6U7fkZKvW5Ui8Z087S4MU3+X6nEdv5r0MF+ 7KMVHSsGvFB6ITE70XPWnU1nxyeL3tTXto0yzPX2NSCdc1ZqMh7XGaZ+8vyvsa1V9hh2 0S3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=RWwcbHxc4gNZkpX9lULBb97jbG0T6/PKCXFFwxy3BRo=; b=RW76RrxzpBan0QwdyZJBz0s3FBOW/JdRAEobzNgb+N6YMGSrB061A7hK+HWRxFT0l0 LVWiri1b8yjfNefDa3ES5eiOpK6AsFrKioDy+JtjUSJUsjxHSrlqDmU5DoRPkOK0e+1e Kj9rDRN80ZBpYEhvuJyZuxpbrcGKSHI4OE/7snn6Q5JN2ghBwQSX984x70e84ToiJuIQ XVL7kKZPUUcmMJKnz75hw+ppiupPeBP5Hz70oSiiDOY/W0fggIHI92e8kpwF2V9rV9H6 3t7SP4b73dvUFDxvDvOWcSSDV4yLT0au0OcGO8mGG/cP4eJ0s+j0FYXJ/VCT67ECUMLF F9sA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Q/VWQohe"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s4-20020a170902ea0400b00182631bdf78si6126367plg.222.2022.10.18.03.47.32; Tue, 18 Oct 2022 03:47:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Q/VWQohe"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229903AbiJRKhX (ORCPT + 99 others); Tue, 18 Oct 2022 06:37:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229592AbiJRKhW (ORCPT ); Tue, 18 Oct 2022 06:37:22 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 713672B632 for ; Tue, 18 Oct 2022 03:37:20 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id x31-20020a17090a38a200b0020d2afec803so13627090pjb.2 for ; Tue, 18 Oct 2022 03:37:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RWwcbHxc4gNZkpX9lULBb97jbG0T6/PKCXFFwxy3BRo=; b=Q/VWQoheR0jWqMa+lig4NkopBmoRotDVaP9cGfl7W4DQXcbenSZTvnHlU8ec5aY5Cd jBcPRpEQBqqGzCmNQmhr1llswDmnoxy4Vj1PMy0QYDpv6AVlZC7OQXu0eAY4SQmNIhBh v8Ej7R1pjU4YXoKJWzA3RMe3ynKxYOBjVlE56Ebbg795HXfU1w9F137tWGRC+aqPzyV7 iEehitdslfnyYbRf7oFhgqGOjtU2fml9JibMeOeuXxwWUeWifXf9VW8qJLdY9e5tN/5K P2Bs5z9LTvlwQw4z0p5reRgY8WmxLyLYIXQH45UFupvLtkdIxLDtAjzquUMDFa9ElfU9 P30Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RWwcbHxc4gNZkpX9lULBb97jbG0T6/PKCXFFwxy3BRo=; b=voeHv5WgOsqWYHGhuyXRqFBhUjGowWi6wQZu4LP3fGYHjDcjYofLCowU+NN1ZIDmOB FrbFoNebEtdMxdiK1X7lYJENXxQFBQ/52bvIiWWEE44cExzm9k1qHvVmqJSZYrLQjHlk RHD3D0Ilee1RqcO5fyZu/UoQGKw50RzKmfOMtxU0ySBgawtqlVTyKYPS6qOSRxAb1tPB akenuyZqtcq4tNA6FoKXLt9U9c5CSWcXncB+DDmzckfcfPWEIPCgjxvxcCAYiBTU0lxT smeuM+LWP7HDoxabsREHxIKVxHO6XMav92NZvAza8ihzOS6lWRdVNftKYgO0SPpgwEWX m1pA== X-Gm-Message-State: ACrzQf2R7KzW6DftIuYLhQzVlPwH+PXC4GfgtvZHGbxWAPjVsECec3/5 A9rxkhQ9+Gsiu+mRMcSOWVWDmw== X-Received: by 2002:a17:902:e750:b0:17f:71fa:d695 with SMTP id p16-20020a170902e75000b0017f71fad695mr2519699plf.105.1666089439919; Tue, 18 Oct 2022 03:37:19 -0700 (PDT) Received: from localhost ([122.172.86.128]) by smtp.gmail.com with ESMTPSA id s17-20020a170902ea1100b0017ec1b1bf9fsm8523191plg.217.2022.10.18.03.37.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Oct 2022 03:37:19 -0700 (PDT) Date: Tue, 18 Oct 2022 16:07:17 +0530 From: Viresh Kumar To: Fabien Parent Cc: ilia.lin@kernel.org, agross@kernel.org, andersson@kernel.org, rafael@kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v2 1/3] cpufreq: qcom: fix memory leak in error path Message-ID: <20221018103717.kjwmecadk6dknwxm@vireshk-i7> References: <20221015130424.1923706-1-fabien.parent@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221015130424.1923706-1-fabien.parent@linaro.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-10-22, 15:04, Fabien Parent wrote: > If for some reason the speedbin length is incorrect, then there is a > memory leak in the error path because we never free the speedbin buffer. > This commit fixes the error path to always free the speedbin buffer. > > Fixes: a8811ec764f9 ("cpufreq: qcom: Add support for krait based socs") > Signed-off-by: Fabien Parent > --- > > v2: Added missing "Fixes" tag > > drivers/cpufreq/qcom-cpufreq-nvmem.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) Applied all three. Thanks. -- viresh