Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Oct 2022 09:01:38 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     liulongfang <liulongfang@huawei.com>
Cc:     John Garry <john.garry@huawei.com>, alex.williamson@redhat.com,
        shameerali.kolothum.thodi@huawei.com, cohuck@redhat.com,
        linux-kernel@vger.kernel.org, linuxarm@openeuler.org
Subject: Re: [Linuxarm] [PATCH 1/2] hisi_acc_vfio_pci: Add debugfs to
 migration driver
Message-ID: <Y06Voma/Prezqmag@nvidia.com>
References: <20221014025757.39415-1-liulongfang@huawei.com>
 <20221014025757.39415-2-liulongfang@huawei.com>
 <42d12308-4777-47a7-a1ae-50dfada050cf@huawei.com>
 <7c041671-71bf-d558-d47a-70296fe5c30e@huawei.com>
 <Y01GdiFbt2J9La2Y@nvidia.com>
 <9826a418-4a14-aa4a-9eb8-6faf3e43c8e3@huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9826a418-4a14-aa4a-9eb8-6faf3e43c8e3@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0hhOHhsNjBpb2NpdHpFNlUrSGtWVzF5MmY3bDUzZnZmVXI0TDhCdUVGS0RZ?=
 =?utf-8?B?WWlnN3dpbUJGRVFhclR3Lytsbk40NTUwVVVwZy9yKzFFZ3lEU3h3SXIzbnlk?=
 =?utf-8?B?b280MTRuQnNVdzdkclZob04yeXViZUR5NlF1SFo5OXpOQWZhQko5V1NrcHNB?=
 =?utf-8?B?Zm1ESVh6V0ZvdmwwZFE3WnVtQmRvRHN3SytXZW10R0tXWFR0cG9DMmJ1R1Rt?=
 =?utf-8?B?TmY4UFlrcjRyS3M0ZDJhVFd1aGR3b2c0YnNpcmh2VVRvOUJmeEJ0dU44VkJ4?=
 =?utf-8?B?eGRYYXU4SDNlVDIzcVR4VDlIUkFVcVhmbnhiQmlYcnFQMUh3Y2tpTThZRzI4?=
 =?utf-8?B?TCtxeHFZNS91VWl1bnlwUUFYZG9EMnZ6WXlsK3dUSCtON2orRFc4VzZUMHR0?=
 =?utf-8?B?Y3RyUVhKSmNCb2pONTB6S3VZQlhseWE5ZHN5TlVkOFc3bTQ1R2pWc0FJSU5Z?=
 =?utf-8?B?VXhJYkZYS0lTNGdKeDRrdWZuU1gvMFVEV2YzVVNHdEl0Ymp1M3VnQ3RtUVVz?=
 =?utf-8?B?QXB2aVk0YTh0akVkMjZxS0NCUzFOOU9WYXBiUjlTWW1odE0wcVNHdkNUWncz?=
 =?utf-8?B?bFk2MWQwaDZBSVVPOHlLNFVqVDBXU1RjekNFWVg4UzREMkczeHRCSHk0MnVZ?=
 =?utf-8?B?UU9yWGdGNXRsRllNMkNHRWhLeWptRDBORGZKL2ZtRTRaR2g5cm9FdDNOUk5h?=
 =?utf-8?B?R1R0RjU2b3VvRkk4Rnp2VlptU0Z0engyT2ZZQXFxSkRsbWtuM0lETHhGcEFa?=
 =?utf-8?B?RU9NZ3NHOUJHTkwxKzk3dUZ5bmM0SmhrQnkwaXcrNUFjMEJXOWlpb1FTOWFG?=
 =?utf-8?B?UWMzRzlpTWUxRXZrTDZLbVRzQklKT3NjVnhzdmlreWw5RUlsb0JUQXExN2Zw?=
 =?utf-8?B?b1JNSStxMG1MbWhJWlV4NDNhTW5DMDQrN3h5TWN0UlErRDZqY2pwM0JWdVJH?=
 =?utf-8?B?bjVYMDZwZDYycFROQ1l4QThmTkpFSUxzUjdpUG9VSStBTzJiVkFhQnI1UDUx?=
 =?utf-8?B?QStZbkprTHM4dGxjQjhQTGd6VTJ1R25DcDNmSXdhVExscDJtK3dqVHVNYzdy?=
 =?utf-8?B?U3k3RUtzcEZXM1I5N1grVmJSeWNCYVNnU0ZnVWN2QzMwOUhNRGtKNUttdUJN?=
 =?utf-8?B?a1BzQkRyTnVSY3hsakl3a2RXTEQyczlialRMNDkvN0hXam42UnB4QnErSHVM?=
 =?utf-8?B?NCtWMURsblhVYWdURkJnZDBoNFY4dGtiTW1WMWVHTU1VbFhVZTk4aER2M3FY?=
 =?utf-8?B?SVNzeG9ySlVVV2QxUU9laHUzZDFyWXZoM3JFcmQ4RjhXTWd5Tk53S2p0Qyt6?=
 =?utf-8?B?VWtUbFFUTGFKNnpUZUhTa2wrNzlwVUU5NnBEK2lGYmVaZjNhVjlpWE5XeThZ?=
 =?utf-8?B?Mld3eWNQeGdFSTFDT1NBNDR6Z0dxZ1pJRU1iTnhCakFHbmZORTRoZU9kVkd6?=
 =?utf-8?B?d1pyamNwWmQybDdLYUhuV2lMWUV6VjVMSk55bmdPMDZoSVIrRUZaT1Z5RTIr?=
 =?utf-8?B?cE1YT3Z0cER6aW5PMENkVThOZzYzdEJUcXE1RERXL0wzNUp2NTFoV1pOeGRr?=
 =?utf-8?B?ekVrejJ0SEdmWHQ0RlJjRG5US3BydmJCYkJiM1JrbkV0Y3RyYkNSYkJjVmhO?=
 =?utf-8?B?VW1SS3NMbCtic1p4Nzg0WHdkTHpmL211SXVPMHgvYVBJcW9mTUwwYWZnbEZG?=
 =?utf-8?B?KzBVUmVsaFU4TkdINXY3NTVqcVFBRlF0bFVUSjRIN2N0aWllKzZnK0pJdHZQ?=
 =?utf-8?B?WWwxTVI1dkNlL3BiOEZ5bEtaSjg0ZTJsMGY4ZjFSdXpSYUh5V2I5TUJkYVFR?=
 =?utf-8?B?NC85SDlFempLVk1VaDZ0bGtzZ3ZpSkx5MDY4a1VzN0xFaWRrYlNRWEtTN3Z4?=
 =?utf-8?B?a0w5UWdFb0grdW85RGRpMlpJZHNRYUhPUEpRZDNabGR2NDVSeHJvMEpjQklr?=
 =?utf-8?B?Y2xXNFRsV21jVjdPTDVBbFpsZC8zbURyVVEybWdJQ2FMVXRGbDJPT0NMNlda?=
 =?utf-8?B?NnpJeUxkaUl0OWxjdWVncGFZY09xZTBkeWppcXE5ZGt3QmZoNnJiM1RZcGJo?=
 =?utf-8?B?cDZxeW9oaVJyNEcwcHVaN2pMaE02NUJCTFVyZHJPYW45VnEzNUM2RGpSWSsz?=
 =?utf-8?Q?D4AI=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ecde675-f90c-4659-a23a-08dab10083a3
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 12:01:39.3938
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YzN4//YJMwJaJW09ZtEpGxt7+1/dhou3aSPQupcMmcO1qVlYyrua6AOk92JKnj23
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5608
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Oct 18, 2022 at 03:06:43PM +0800, liulongfang wrote:
> On 2022/10/17 20:11, Jason Gunthorpe Wrote:
> > On Mon, Oct 17, 2022 at 05:20:34PM +0800, liulongfang wrote:
> >> On 2022/10/14 17:20, John Garry wrote:
> >>> On 14/10/2022 03:57, Longfang Liu wrote:
> >>>> +static void hisi_acc_vf_debugfs_init(struct hisi_acc_vf_core_device *hisi_acc_vdev)
> >>>> +{
> >>>> +    struct pci_dev *vf_pdev = hisi_acc_vdev->vf_dev;
> >>>> +    struct device *dev = &vf_pdev->dev;
> >>>> +    int ret;
> >>>> +
> >>>> +    if (!atomic_read(&hisi_acc_root_ref))
> >>>> +        hisi_acc_debugfs_root = debugfs_create_dir("hisi_vfio_acc", NULL);
> >>>> +    atomic_inc(&hisi_acc_root_ref);
> >>>> +
> >>>
> >>> This looks totally racy, such that I wonder why even bother using an atomic for hisi_acc_root_ref.
> >>
> >>
> >> When enabling VF, it is possible for multiple VMs to enable VF at the same time. The atomic variable
> >> is used to ensure that only one "hisi_vfio_acc" is created. When other VFs are enabled,
> >> it will not be created again, but will be used directly.
> > 
> > It is still completely racy. Use a lock
> > 
> 
> Do you have any suggested solutions?

If you want to keep it like this, use a lock around the creation.

Jason