Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Oct 2022 08:17:41 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Linus Walleij <linus.walleij@linaro.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Qingtao Cao <qingtao.cao.au@gmail.com>, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org, Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH v1 1/1] gpio: exar: Allow IO port access
Message-ID: <Y06ZZQ4q3Ql0sNkm@fedora>
References: <20221017170600.88480-1-andriy.shevchenko@linux.intel.com>
 <CACRpkdbNkPG5KsB47jByseDh=nOt+J2eE_nh5EJqRLAPDp8v8A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Gqn9ZZgaixBaZ3cX"
Content-Disposition: inline
In-Reply-To: <CACRpkdbNkPG5KsB47jByseDh=nOt+J2eE_nh5EJqRLAPDp8v8A@mail.gmail.com>
Precedence: bulk


--Gqn9ZZgaixBaZ3cX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 18, 2022 at 10:29:13AM +0200, Linus Walleij wrote:
> On Mon, Oct 17, 2022 at 7:05 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>=20
> > It's possible that PCI device can provide an IO port resource for
> > the device. regmap MMIO currently uses MMIO by default. With an
> > additional flag we enable support for IO port accesses.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>=20
> Looks clever to me!
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> I would let William have a look at it as well, as he's worked extensively
> with port-mapped I/O.
>=20
> Yours,
> Linus Walleij

I love how simple it is to add IO port support to these drivers now. :-)

Acked-by: William Breathitt Gray <william.gray@linaro.org>

I'm hoping to convert several of the port-mapped GPIO drivers to the
regmap API later this cycle, so it's good to see other modules making
use of this interface as well.

Thanks,

William Breathitt Gray

--Gqn9ZZgaixBaZ3cX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCY06ZZQAKCRC1SFbKvhIj
K4a2AQC5tyMmVg9lmM0Ig4lRNMikOooM39OWgxDsLS6TvV4qaAD+LgrR2MNu2N7+
UI00cdLogtU8YgtpqEbld147YhZXoQo=
=vFbp
-----END PGP SIGNATURE-----

--Gqn9ZZgaixBaZ3cX--