Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5935afbd-ec39-21f8-1585-57a932261271@nvidia.com>
Date:   Tue, 18 Oct 2022 14:18:49 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] serial: tegra: read DMA status before terminating
Content-Language: en-US
To:     Kartik <kkartik@nvidia.com>, ldewangan@nvidia.com,
        gregkh@linuxfoundation.org, jirislaby@kernel.org,
        thierry.reding@gmail.com, swarren@nvidia.com,
        akhilrajeev@nvidia.com, linux-serial@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1666074311-12764-1-git-send-email-kkartik@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <1666074311-12764-1-git-send-email-kkartik@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QU1Tc3M0RUJYSDV2ZzBzWXhFSEhjRitNQ0Vwano4NEhJT1J2U25ORUc5OUNu?=
 =?utf-8?B?Um1TNUJtT1RxUjY0ZUlka1dYT0NiTkpKdXRNWG1pREhWa1QrSGJ0emJVVlRO?=
 =?utf-8?B?VlN0aTc4aFdDaUVEQ1NrQ0xBNVNaMjFiQStnMk00N1JQVlFldFlPdnBPTzJa?=
 =?utf-8?B?dlFORU9FYXpJMkRNMysrSGVvRTYzM1hxbEY2RVJDMjVhQlpHRmpqcmR2bjFU?=
 =?utf-8?B?aDc2MnY0Z05Ra0FwMWdsbWhUQkpRRkZkOG9xZmdYemNCTkM1b3BXL2hEZTR3?=
 =?utf-8?B?Ukx4UWltRE94aStsdk9ZTzh3dXc5Q2gwQU5JbkZQRkVab0xXNVNpNjFtSEdq?=
 =?utf-8?B?eTJ0OVo3ZEx0dlczU1dNY29sL0loOE82MmdTSk50NDdINEE3aDJPUk9tT1VG?=
 =?utf-8?B?ZGFrKzFhZlA1Z25GcVFiYWFMQ0VDZkt3Q1lRYWdoT3RFcTExNTI4TW1pMmNk?=
 =?utf-8?B?TzhUMHBadFc0UEhidmRjSUdCS3JMQXJkdmFWS3lwMjFJbzZNLzdJMmJMc3NJ?=
 =?utf-8?B?enhOOE5HdUxGMlJ6NmhRSUJ2WCsvQUlaaWxranVKbGptU21pNlZDWmhPalo2?=
 =?utf-8?B?ZG9Zc2ZWeUJ5UkFuOCtyL2NSSk9RakNLMHFXUTlSbmtiOWlrZEdqQkdZSStu?=
 =?utf-8?B?NzNicHNUdUM5VnJXcFFvWVlPSnpyYnpJd09BT3h5d0ZjTVRCbUtVU0ZwV05M?=
 =?utf-8?B?c0FqeFNJQ3FuVWEwajRndXkyUm9pTnR5dXpzVncwY2xuYW1UcUFaUUk3NHJ1?=
 =?utf-8?B?YjhraW1ZcEJSQm5yazE1MlRLUVFSL1F0eCtrWU1rcWhEemIycHB6ckwxNFZB?=
 =?utf-8?B?UUZqSjI2TnhlNjI0VVJKWndpeTZtNHFnMzFsdFdxNGlHMzJqK2thUENGNXdk?=
 =?utf-8?B?SXB2UzBpRDlkdTR2Tmc3Ym1SU0Ryd1J4Q1N4aUdpZjFBQmQrcmNTUlRRSy83?=
 =?utf-8?B?RjFPMjI5dUxKOFFHOGk3L0xZakgyT1BTR0RmeHZlSHh6ZW52N24rZWQwbjgy?=
 =?utf-8?B?Z2w3eFI0dmpwR0pRU2d6Q05tRENhUnMwU3pyaHNLYmFBMWRJNGxrYnNpZGZQ?=
 =?utf-8?B?d29FS1VZMzBnd1R5VGFQdHBXNk5kcWdUZFpDWE1yUUtwckRDaU9kclY2OWR6?=
 =?utf-8?B?Ri9Jd3I1M0dlQStxQVFHRkcxMXZmZHBlNndEZFZUck9iRExwbVhvdW0yWXNh?=
 =?utf-8?B?N2ZiT1hKdFJrd1dXaTY2S0w1SUhBUlJJUytFVjBaNUZUU0dTeTBEN21tVmQ2?=
 =?utf-8?B?WHkwTHpuL2pXcnpyYy9sWnNHTFNHeDl6VjJyNmk4M2kyUHJON045TmJaVzFj?=
 =?utf-8?B?RDdFamV3eTIwd3ZwMloyYTFQOEI5eGN4QnJIZkQ1YVVBbEY0WGJGMk5wYURT?=
 =?utf-8?B?VktSbkZINHdORDdESHdJZWFuQXpOSzZZc0lXNy93T0hZUUdiTXg0Y0JlSUk0?=
 =?utf-8?B?QXpLQ2RuL2VGMGhMNGl4N0lmWmZkN2YvWlFwUHgrbG9hQllMUFVYWm1lN3A3?=
 =?utf-8?B?WVl4ZC9la2xhVWxLZmxtTGtOOVZPVTZ2a09zbldlay9nS2JLS25ITk02cVlJ?=
 =?utf-8?B?Q1BXaHg5bUZDRWZ1VkJLQmhBWmJQWVIySFBQMWtWeEpwMGUxUzc4UHZwOXVI?=
 =?utf-8?B?MFM2SkFLcytVc3FuVXB3VjhLYVRhWk10VEUxTUxnVjZzZmhKMUdNMG0xblJM?=
 =?utf-8?B?dW5sUEhaRC9iREs5YWxSWVFPd2F3YUtaRVFwMGlTNkY0RlFDUFAyTXRZdnMr?=
 =?utf-8?B?S3lDYU9DbDMzbWtIZytOaExxTEhLczNDUnBHNG9UNHNmV3hRY1VmUWtjSjlh?=
 =?utf-8?B?aHRPa2RDMC9RdmVURDZMNnZvcExrNGZXcUR1NlZBdGpUNTRoYno2TFBTd1Q0?=
 =?utf-8?B?S2RCYVVxQ2xHM1JnK01SbnltdkI0SzczeThEYkdVM0JRNUM1STQvbFkrVWFH?=
 =?utf-8?B?REhMV2JVRFpJWFVzRTBUMDA3NzVwbTVQaTlwL05oUm5ZRmQzdXExYXdDMGRC?=
 =?utf-8?B?dkxrNVhpdVNmZ3pmY1pWcFViZGRoUjQzbTkrUm9ZU0dqT0xPNlV0b0Y5Qmhz?=
 =?utf-8?B?L2FwNDk4ZGpNQWpOVHRpN0U3UGtNWXBVZUpIZFNnTjFPUVRYL1RhcXRXTTlN?=
 =?utf-8?B?Rk5ZajZjUzFPK1ZpdmhEckVROTI2NU5UbGYraE9nd1A4ZEFSN2ZNMVdvK09w?=
 =?utf-8?B?bGc9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d850f56-2a67-4c6b-9ffe-08dab10b4f3c
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 13:18:56.0987
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: En6jpPa21fOssVmsAhe7zMH/yH0/STmuZ9m9hP2bhCmFOUef7AhfcM3Od1aM1wu4VnK/7aSdgqUXKd9/9F3FwQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4537
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 18/10/2022 07:25, Kartik wrote:
> To get the valid data, read DMA status before terminating the DMA. As
> dmaengine_terminate_all() deletes the DMA desc.
> 
> Fixes: e9ea096dd225 ("serial: tegra: add serial driver")
> 
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> Signed-off-by: Kartik <kkartik@nvidia.com>
> ---
>   drivers/tty/serial/serial-tegra.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/serial-tegra.c b/drivers/tty/serial/serial-tegra.c
> index b7170cb9a544..2779b4491f02 100644
> --- a/drivers/tty/serial/serial-tegra.c
> +++ b/drivers/tty/serial/serial-tegra.c
> @@ -619,8 +619,8 @@ static void tegra_uart_stop_tx(struct uart_port *u)
>   	if (tup->tx_in_progress != TEGRA_UART_TX_DMA)
>   		return;
>   
> -	dmaengine_terminate_all(tup->tx_dma_chan);
>   	dmaengine_tx_status(tup->tx_dma_chan, tup->tx_cookie, &state);
> +	dmaengine_terminate_all(tup->tx_dma_chan);

The change looks fine to me, but on further review of other similar 
drivers I see that they pause first ...

  dmaengine_pause(tup->tx_dma_chan);
  dmaengine_tx_status(tup->tx_dma_chan, tup->tx_cookie, &state);
  dmaengine_terminate_all(tup->tx_dma_chan);

This makes sense so that when we calculate the amount of the data 
transferred we get the exact amount. Can we add a pause while we are at it?

Thanks!
Jon

-- 
nvpublic