Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <51a33dc0-424f-171c-3347-75eee598b6b8@squashfs.org.uk>
Date:   Tue, 18 Oct 2022 14:38:24 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: BISECT result: 6.0.0-RC kernels trigger Firefox snap bug with
 6.0.0-rc3 through 6.0.0-rc7
To:     Bagas Sanjaya <bagasdotme@gmail.com>,
        Hsin-Yi Wang <hsinyi@chromium.org>
Cc:     Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>,
        Jintao Yin <nicememory@gmail.com>,
        linux-kernel@vger.kernel.org, marcmiltenberger@gmail.com,
        regressions@leemhuis.info, regressions@lists.linux.dev,
        srw@sladewatkins.net
References: <20221015205936.5735-1-phillip@squashfs.org.uk>
 <20221018021507.612-1-nicememory@gmail.com>
 <41c05ece-2e63-391a-e1ba-fc1acb235559@alu.unizg.hr>
 <CAJMQK-hgQEkhgpO9VFOCgn-cKtVsr7Hb_58pAYiGoDi5SzGZtA@mail.gmail.com>
 <Y06jNzD92Tv5TKxI@debian.me>
From:   Phillip Lougher <phillip@squashfs.org.uk>
In-Reply-To: <Y06jNzD92Tv5TKxI@debian.me>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 18/10/2022 13:59, Bagas Sanjaya wrote:
> On Tue, Oct 18, 2022 at 04:24:46PM +0800, Hsin-Yi Wang wrote:
>> Hi Jintao,
>>
>> Thanks for pointing out and sorry for missing this. Does the following
>> diff improve the issue?
>>
>> diff --git a/fs/squashfs/file.c b/fs/squashfs/file.c
>> index e56510964b229..7759bd70dfbf2 100644
>> --- a/fs/squashfs/file.c
>> +++ b/fs/squashfs/file.c
>> @@ -600,7 +600,7 @@ static void squashfs_readahead(struct
>> readahead_control *ractl)
>>
>>                          /* Last page (if present) may have trailing
>> bytes not filled */
>>                          bytes = res % PAGE_SIZE;
>> -                       if (pages[nr_pages - 1]->index == file_end && bytes)
>> +                       if ((pages[nr_pages - 1]->index >> shift) ==
>> file_end && bytes)
>>                                  memzero_page(pages[nr_pages - 1], bytes,
>>                                               PAGE_SIZE - bytes);
>>
>>
>> readahead only handles the case that the first page and the last page
>> have the same block index:
>>      index = pages[0]->index >> shift;
>>      if ((pages[nr_pages - 1]->index >> shift) != index)
>>          goto skip_pages;
>>
>> The diff above makes a difference to SQUASHFS_INVALID_BLK case, which
>> will not be handled by squashfs_readahead_fragment() if
>> index==file_end.
>> With the above diff, it will now be memzero_page().
> 
> Hi Hsin-Yi Wang, thanks for the proposed diff. However, it was wrapped,
> so I have to manually type the changes.
> 
> I compiled 6.1-rc1 with your diff applied. For testing, I have both
> hello-world and lxd snaps installed. No problems on running the former.
> On the latter, I got coredump when trying to start lxd services with
> `snap start lxd`. The coredump for lxd processes are attached.
> 
>  From above, I think b09a7a036d2035 ("squashfs: support reading fragments in readahead call") should be reverted until we come up with proper solution.
> 
> Thanks.
> 

I am currently working with the snap developers to identify the issue.

When there is progress, I will post.

Phillip