Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f7e79f3a-be97-334b-84f2-76da0981e991@gmail.com>
Date:   Tue, 18 Oct 2022 14:54:07 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:96.0) Gecko/20100101
 Thunderbird/96.0
Subject: Re: [PATCH] perf report: Skip symbols for idle symbols
To:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
References: <20220608055146.1446-1-zajec5@gmail.com>
From:   =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
In-Reply-To: <20220608055146.1446-1-zajec5@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 8.06.2022 07:51, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Displaying idle symbols is rather useless and makes reviewing "real"
> symbols harder. perf top already skips them so perf report should
> probably do the same.
> 
> BEFORE
> 
> # Overhead  Command          Shared Object          Symbol
> # ........  ...............  .....................  ...................................
> #
>      75.04%  swapper          [kernel.kallsyms]      [k] arch_cpu_idle
>       1.05%  ksoftirqd/0      [kernel.kallsyms]      [k] __pi___inval_dcache_area
>       0.78%  ksoftirqd/0      [kernel.kallsyms]      [k] __netif_receive_skb_core
>       0.75%  ksoftirqd/0      [kernel.kallsyms]      [k] fib_table_lookup
>       0.58%  ksoftirqd/0      [kernel.kallsyms]      [k] __dev_queue_xmit
>       0.56%  ksoftirqd/0      [kernel.kallsyms]      [k] bcm4908_enet_start_xmit
>       0.55%  ksoftirqd/0      [kernel.kallsyms]      [k] __skb_flow_dissect
>       0.53%  ksoftirqd/0      [kernel.kallsyms]      [k] __pi___clean_dcache_area_poc
> 
> AFTER
> 
> # Overhead  Command          Shared Object          Symbol
> # ........  ...............  .....................  ...................................
> #
>       4.21%  ksoftirqd/0      [kernel.kallsyms]      [k] __pi___inval_dcache_area
>       3.13%  ksoftirqd/0      [kernel.kallsyms]      [k] __netif_receive_skb_core
>       3.01%  ksoftirqd/0      [kernel.kallsyms]      [k] fib_table_lookup
>       2.32%  ksoftirqd/0      [kernel.kallsyms]      [k] __dev_queue_xmit
>       2.23%  ksoftirqd/0      [kernel.kallsyms]      [k] bcm4908_enet_start_xmit
>       2.21%  ksoftirqd/0      [kernel.kallsyms]      [k] __skb_flow_dissect
>       2.13%  ksoftirqd/0      [kernel.kallsyms]      [k] __pi___clean_dcache_area_poc
>       2.00%  ksoftirqd/0      [kernel.kallsyms]      [k] eth_type_trans
>       1.86%  ksoftirqd/0      [kernel.kallsyms]      [k] bcm4908_enet_poll_rx
>       1.73%  ksoftirqd/0      [kernel.kallsyms]      [k] __local_bh_enable_ip
>       1.63%  ksoftirqd/0      [kernel.kallsyms]      [k] fib_rules_lookup
>       1.61%  ksoftirqd/0      [kernel.kallsyms]      [k] bcm4908_enet_poll_tx
>       (...)
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Ping? Does it look OK to you?