Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp6144071rwi; Tue, 18 Oct 2022 08:36:32 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7750XwCkGdTGFywgM3DnSvftDnbIc+lAps+9ElFGeQIrTE6HTJoKOsFWnROY6BesXZSJXc X-Received: by 2002:a17:907:94d1:b0:790:65a:3a18 with SMTP id dn17-20020a17090794d100b00790065a3a18mr2856644ejc.428.1666107391883; Tue, 18 Oct 2022 08:36:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666107391; cv=none; d=google.com; s=arc-20160816; b=OLuo1VHIU+hTShGVSJw06gwHvIsNhZGN/VMRSTHlh2SXjYfhGRTEsXsvMa6Dhmcv+h yRsNfXFIZlT4nh/434o84yIPWplR0xtZPk/zXQbiPkX3Ra0yE7mnRkJ6lclEPaOBBb2v C+dT77OT008fhFLE39UcRCTLzD65zurFhTJs2b7gvbENMx+OW7bzjQZyrNOsM2JtcdJZ CVXwBLpILA8bdD5ymGG1DInM2rqxgM8aRn52nuCrshoUvy0U9lof3uGABHyPtTcT/HP2 iTyPH3sn4JkHdVnRYLbeCDEw9T7NXMDofLlN1dBCkq2r3B/5MCrvxC/DzJsqLg5wHZz5 Ze0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=GU0+C6Q9HG49BdTqLSqQOm5ZxX0Mnusp9vHEt+nixFc=; b=JvmGiZbS2L6ZN2WAnQ8FEDDG9Ejp42rOWB4eO+VY4gb22vdb01icKqyI3tyH2KhRCs b8KbBGTixy8q8dHgXm91xa2RqXsrZiqeBQoaJL234SzBXs3qGy/8fhpm8hWeMTjJPxpE lpoJigAR3fYzaMgaQ6JghwIgRXbMl+Vw3j7fv8jE9E1mktWZDFfZQpZytW87YdQiaxLN WrwMzAOy0FU3EPFDY3fTDuHiLgiF+9fKO0N2j3JYnWlviYlqJ43vhHVmLx4y8oIQQ+Ca dscJaKvRFshiDymr7yhcs/v5cWxx5zziFgADh/pbmFBRz3Tu2ooqyLgtBBVUBUEQfiGi 9qzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Pi2DQhxF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sh36-20020a1709076ea400b0078209ff9896si11135582ejc.509.2022.10.18.08.36.05; Tue, 18 Oct 2022 08:36:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Pi2DQhxF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230232AbiJRPYY (ORCPT + 99 others); Tue, 18 Oct 2022 11:24:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230217AbiJRPYW (ORCPT ); Tue, 18 Oct 2022 11:24:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6635625B; Tue, 18 Oct 2022 08:24:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F0EDE615C5; Tue, 18 Oct 2022 15:24:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CBB8C433D6; Tue, 18 Oct 2022 15:24:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666106659; bh=BC2Hq7y2IYPbSVkSJem2YkCxDtM4WUocEUlVsVjhl5E=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=Pi2DQhxFBnpCX6HRCABC6Vnh/z7gDugQU/22bxdQ8rr1lw7bBpww/pIqFP+DW56Yw mOXllpywLImJT1IUVcIpyaCHhWJHRPyxUtUthP7QwHy6+U9TxHtndc+BPeiMwATQAY JieK49edOoqdA2wISlR/IfVRdNqoAcjWa9MB4WoT3AqdYELxTVLzgXHECUHgi66qDH 0HZ3sUXrmp3ST57wOe8R+oozatSjOGGZy0AHc+YJZoA1gnNUmXDZ5MasAfsgnv5iwU RIvyvFO2qP6TLKW686CoNaGL+EJXsviDkcIBEY5dDEVTPTR/Yhm27y8vzTKS889WA+ 77dD++DAsi3iA== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 03E285C0528; Tue, 18 Oct 2022 08:24:18 -0700 (PDT) Date: Tue, 18 Oct 2022 08:24:18 -0700 From: "Paul E. McKenney" To: John Ogness Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, rostedt@goodmis.org, tglx@linutronix.de, pmladek@suse.com, Frederic Weisbecker Subject: Re: [PATCH v2 rcu 0/8] NMI-safe SRCU reader API Message-ID: <20221018152418.GR5600@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <20220921144620.GA1200846@paulmck-ThinkPad-P17-Gen-1> <20220929180714.GA2874192@paulmck-ThinkPad-P17-Gen-1> <87k04x4e0r.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k04x4e0r.fsf@jogness.linutronix.de> X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 18, 2022 at 12:39:40PM +0206, John Ogness wrote: > Hi Paul, > > On 2022-09-29, "Paul E. McKenney" wrote: > > This RFC series provides the second version of an NMI-safe SRCU reader > > API in the guise of srcu_read_lock_nmisafe() and > > srcu_read_unlock_nmisafe(). > > I would like to post a new series for printk that will rely on the > NMI-safe reader API. From the feedback of this series it appears that > the RFC v2 is an acceptable starting point. How should we proceed? Currently, I have this series on -rcu branch srcunmisafe.2022.10.03a, with Frederic's patches on branch "dev". I will be producing a shiny new branch with your fix and Frederic's debug later today, Pacific Time. With luck, based on v6.1-rc1. > Will Frederic be sending a patch for the extra safety checks using > srcu_nmi_flags? Are you planning on posting a new version? Should I > include this or another version within my upcoming series? I will be incorporating these commits from Frederic: 6558b914fc4e ("srcu: Warn when NMI-unsafe API is used in NMI") 5dc788627109 ("srcu: Explain the reason behind the read side critical section on GP start") 54a118fce487 ("srcu: Debug NMI safety even on archs that don't require it") Are there other patches I should be applying? > Thanks for all your help on this! And looking forward to the new improved printk()! Thanx, Paul