Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2c02b2de-4fb3-1ad2-5a30-614f9550c108@oracle.com>
Date:   Tue, 18 Oct 2022 10:44:30 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH][V2] jfs: remove redundant assignments to ipaimap and
 ipaimap2
Content-Language: en-US
To:     Colin Ian King <colin.i.king@gmail.com>,
        jfs-discussion@lists.sourceforge.net
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221018152310.941770-1-colin.i.king@gmail.com>
From:   Dave Kleikamp <dave.kleikamp@oracle.com>
In-Reply-To: <20221018152310.941770-1-colin.i.king@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFp2eHV1czNoaEh2aVlNSDYvSmxUdmIvQmNReXIvNkxkQk5RcjBWU2ZkL1Q1?=
 =?utf-8?B?K2xjQ1VmVEppeWovUERZQ3Jjek5KSDB6UmJvNEVYTkFBeTBGb1ZrdXdLamFV?=
 =?utf-8?B?MTZYa084RFhPL2daVi9xVGpXNDlkVlFWb1BZT1FzSUtOSEp1c21ZT3daN1NX?=
 =?utf-8?B?bGNoMUhFbjY3cjJSYXFTdkp3RlUzcGtHTTd0b3lNNjRxeWwraTEwM1lvbnUv?=
 =?utf-8?B?S2xIMC9ZZlJXQWRwMXBhbkMzMWNjRTdCdDl2dVdFWVFDQTdOSS9BejVYaFdX?=
 =?utf-8?B?TlZnVTk0aHY5M0x5NklIV244MDJDS2pwY2lkM1A3cUJ2YUNxanRGYVh2Y0lG?=
 =?utf-8?B?NDZxVmRRN2pnZTkwZGRiVkVWTlRtR2tseTlBSllxQ21tUE5JM2tVeXRyNFMv?=
 =?utf-8?B?eVRsYk9JYjBzTkNzb1YvWmlGRGJLTzJiS1JOeHpZTitzSVZLVVlPTzJzRUdB?=
 =?utf-8?B?dlJvSlBwelJoelBkMWRvcUZ0LzRkc3g5b29mM3FFOWpNNjZaWnRmalhkUFRn?=
 =?utf-8?B?cnZ6MWd6cFRmZVBabVZ6ZEYxVUh4QXl5dDBoZndqemtoekluYXBiN2xEU1h3?=
 =?utf-8?B?MGVNVlBKM3pVSzQ1OVQzaUhkTmdFZUZBUExRNnh2aGZyMEtmY0RhOFhtVzBJ?=
 =?utf-8?B?YWZGSEVwVnF0Y05SQ3Y5MVFPSTlkMTQ1NWdzQnoxcXdxRHFzZVVVV0hZOVlB?=
 =?utf-8?B?d09LRnovUVN6Sko5ODVQUXZ3WjB5dksydVpWWllxSkEzVkJmYkFkdVRsQllK?=
 =?utf-8?B?M01MWE02cW1vbUpZMVhZekIyUEExVmdtN1BmMEQrTEJEYUY5MndxYzBna0F0?=
 =?utf-8?B?MkZETW9TMmwxRkNEbXVCemE5bTNibFd1aVpqTlMwbkFTUURqdEhoMmFySUYz?=
 =?utf-8?B?VVpYbWp2anRpczN0SkhQMGFwUWhlYlB3Q21jRHV0VUJkSzN2ZTlVcWFaNGlJ?=
 =?utf-8?B?M0t1dTFVVHRURVpFZHhuR2grYWlyTjg2T3owY2FrcURVZW9VVmpSczRrbTVJ?=
 =?utf-8?B?ekxVL2dabXJUdm5CMFFCLzNYcDZQb21lOENqRGFlckNmSmNRTXkzVXU0U3hN?=
 =?utf-8?B?a1NrQXM0MzY1ZUt0eVZ1Um1QbkxVTEdmUkpsd05LbktyOUhuV1BLR0lvTEdF?=
 =?utf-8?B?OWRSSXRuOUR6aGpWTHpYcm1MN25oU0dZeXNDbndsYjliTUFwVHJ4WEdJNHdR?=
 =?utf-8?B?K3VieHpmbzBPZjRUYVpqSG44UXN1aXRWZSt5UXF0eUUzZXdKLzBJYjdKV0FR?=
 =?utf-8?B?VE8zMU9NZE5BcjRSUi94elJORE5VYmxGVkpFMEhlSlIrS2VqcTdJWEVPeXVa?=
 =?utf-8?B?RStKWlIzSW9pSmpGSUlmdGV0bHlBc1RlWDA3eG5oZUtEM0M5UEVJdkRKN3FT?=
 =?utf-8?B?ZnNraGs4TVlwN3V3ZHIxV0ZmbHdOVGdrR2pzVStzbnVoRGRlelQ2UE91cUNi?=
 =?utf-8?B?QmZxenJFbjVmYUJ5ZkJZditvd2xBN2ZpdUtCd0phRkcraEtueW13dWN4ZHVW?=
 =?utf-8?B?Y3JoV0REbmczbG9FRU9XdmZ2TWpmVHlrU0VnM0ZWWWg5YzExd0pIT2kxOXpy?=
 =?utf-8?B?U2htc2NyWkU1ZG1ZbzRGYWI5Wmc3TTd0RHo2Q3JBZnc0MmRhUktkWmFjYVRk?=
 =?utf-8?B?Wm5ldENFdVlIR0ZvZUQ3b2NQbkxybjg2dDMwdXhOcHVEY090Y0s1UVBobk9K?=
 =?utf-8?B?M2ZXaDBNTVBTb0xyREt1aml2c2w5UnJocXMvWHljOGx2T0ZDNm9xUDVNclBN?=
 =?utf-8?B?Q2VOTzhIWmFjKzFZSWoyTUw5SGovOGhHN0l3MzdPU2I4R1N4QWVBb3MzODJ2?=
 =?utf-8?B?a1NmNWgvWUllSHFDRnFiYW4zWkZFQWxpcGJLUCtxRkxjVjllWXpKUVpkcFNw?=
 =?utf-8?B?N29EeFpoVVFnUVZ0bitsa1VkbWczREsySDdTQTVLYW5wRGw0U3Z1Skl0OXg4?=
 =?utf-8?B?Yi9iMlJvV2cyY3FBYnFmdEJERnp3Mmh3eHhEOW1QK2I4V3Nob0Zoai95YUda?=
 =?utf-8?B?TzZoQTZZSis4SGwrZE0rUE1NN0o1eEVscmkvdEpKeWRGR2VTVkM1eEZoZkRR?=
 =?utf-8?B?RlU3eXBlbUJaVjF3cW5KdWtXV0sxSk9kWEg5RmdSUTdyUi96WUUybElmWWU0?=
 =?utf-8?B?L3daeG9zVWxJTFVLM3JoRkZiQ2tSLzZ6ZFhJU1VzaTJJVWhFTWcxSG9nZVJq?=
 =?utf-8?B?eUE9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c05e085-031a-42f9-4781-08dab11fa6ad
X-MS-Exchange-CrossTenant-AuthSource: MW5PR10MB5738.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 15:44:32.6385
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RZ3vNLKR6XyNhiX3iRE6wBrz5t2AEZGrhYNAOBpIWSIh2vjK/kB14fJ9NFaJpc4OnZ05L40nUZIMCjteimvM5pIwdb4KqGvCmvgSgEQVpZI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5017
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-18_06,2022-10-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 bulkscore=0
 mlxscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210180090
X-Proofpoint-ORIG-GUID: yX5upKYJvUlFggn87Wku5MuevZOw_9Q_
X-Proofpoint-GUID: yX5upKYJvUlFggn87Wku5MuevZOw_9Q_
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Looks good. Applied.

Thanks,
Shaggy

On 10/18/22 10:23AM, Colin Ian King wrote:
> The pointers ipaimap and ipaimap2 are re-assigned with values a second
> time with the same values when they were initialized. The re-assignments
> are redundant and can be removed.
> 
> Cleans up two clang scan build warnings:
> fs/jfs/jfs_umount.c:42:16: warning: Value stored to 'ipaimap' during
> its initialization is never read [deadcode.DeadStores]
> 
> fs/jfs/jfs_umount.c:43:16: warning: Value stored to 'ipaimap2' during
> its initialization is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> V2: remove re-assignments rather than initializations as per the
>      recommendation from Dave Kleikamp
> ---
>   fs/jfs/jfs_umount.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/fs/jfs/jfs_umount.c b/fs/jfs/jfs_umount.c
> index 3e8b13e6aa01..95ebcd17ce75 100644
> --- a/fs/jfs/jfs_umount.c
> +++ b/fs/jfs/jfs_umount.c
> @@ -68,7 +68,6 @@ int jfs_umount(struct super_block *sb)
>   	/*
>   	 * close secondary aggregate inode allocation map
>   	 */
> -	ipaimap2 = sbi->ipaimap2;
>   	if (ipaimap2) {
>   		diUnmount(ipaimap2, 0);
>   		diFreeSpecial(ipaimap2);
> @@ -78,7 +77,6 @@ int jfs_umount(struct super_block *sb)
>   	/*
>   	 * close aggregate inode allocation map
>   	 */
> -	ipaimap = sbi->ipaimap;
>   	diUnmount(ipaimap, 0);
>   	diFreeSpecial(ipaimap);
>   	sbi->ipaimap = NULL;