Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Oct 2022 12:18:39 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Niklas Schnelle <schnelle@linux.ibm.com>
Cc:     Matthew Rosato <mjrosato@linux.ibm.com>, iommu@lists.linux.dev,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Gerd Bayer <gbayer@linux.ibm.com>,
        Pierre Morel <pmorel@linux.ibm.com>,
        linux-s390@vger.kernel.org, borntraeger@linux.ibm.com,
        hca@linux.ibm.com, gor@linux.ibm.com,
        gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com,
        svens@linux.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] iommu/s390: Use RCU to allow concurrent domain_list
 iteration
Message-ID: <Y07Dz/NROAMI0Hku@nvidia.com>
References: <20221018145132.998866-1-schnelle@linux.ibm.com>
 <20221018145132.998866-4-schnelle@linux.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221018145132.998866-4-schnelle@linux.ibm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aECK12L+c5f14O4Jm7A6fRn9ZdOZnn81RUD+0VbnSGOCFLH1SyBG/BSv0HGV?=
 =?us-ascii?Q?vzwn94xCyKgu7hekwQNSWITOk47rY7Ixgri6asOe6WWOkBb2oqEK7o8lNxA8?=
 =?us-ascii?Q?Lb0ceWMnZIw00V3O9LjHkBTKo1tIar3cV5Vdnj6foYN3wp10uFoDheGdbqe4?=
 =?us-ascii?Q?DgQ9ysphQddeSmkYA+faDy3Z4Q2ophfhLzcGQz7Jxvnd1X3RBE7/q9/lvVYm?=
 =?us-ascii?Q?+Xz0N07AvwRvlSAgG9nlOe/Z7MQaEnneO1F63Q2XkByblq0ahbR4c79y794B?=
 =?us-ascii?Q?mQoQhRCgnLMwQ1Q0tGXijMB1T0DVwGTn/bQuMqaCMN0h1SFtVfo2VDvmmVio?=
 =?us-ascii?Q?wG7XZEQJSekSiWUOd8k/M8gHc2TzVD+kSsOYpZYX8VO7zoJ56bkdXbmXmhVB?=
 =?us-ascii?Q?TZ+cjV2yFporLFUm0IRnBl6ye7hnJlkeDA+l0KMwjvcpANYJk1C/0Ukdhb7J?=
 =?us-ascii?Q?neFJjly0kdTQsdLDf3XdmxEvW9KL6MOMwzGfUBpdLZwSksirF5kSnfzTeWof?=
 =?us-ascii?Q?UP3yqfJTAg4s5Mz4Kl8sImXMB9Cjn0lMiDVP6UCcExWCVZFy6zGp75iwmexU?=
 =?us-ascii?Q?ctIjuHsZdCUcSOnHgVirpGwg/TXkK010N/XBOFm57s/nSnVtwpnzjXdggZHC?=
 =?us-ascii?Q?NTSw72GIYiDVjFG69/u9TmRFX6MV3sSXKrRmdssZqdNdGVqPk4pdsSwq40tL?=
 =?us-ascii?Q?VpAiiuzsSW8vIA98vU6KN70YeYoc81vt+coH1/C9sE1/kF6AwcUGnWWGoZYK?=
 =?us-ascii?Q?WiUtnKqE6uUtXPvX1NXR8Jg1ElIZXtjL09rYR36lVeYStyLNUoG4zG28LOtX?=
 =?us-ascii?Q?D8vPvLMdkO+3t84hrEaQPDQ4GgwQTT7OoUjCNJaKDDbjpu0bFRs/rFWezAup?=
 =?us-ascii?Q?Ifpu5/3t56BSH7okOaGI5IN5Tj7LMKxYpaRAMAIlUt04D2j/2Grq73bq1e8y?=
 =?us-ascii?Q?9YmFSkaBGwuXxGu1IS+/oIYmo3Tcpfr11zJ92FmZaAxyoK8lxZVmAAnH0DMZ?=
 =?us-ascii?Q?i7d2GFMWmdGZ32kK6XV3rM1jKyEp+guwBb4obLLF3j6KDhv5pAvix+FBDkya?=
 =?us-ascii?Q?UKCIyfkFDQ30DOBz4huY+vt/z6Bp8SXK+PUu/x/1eSJOV8v0w/l0ObunatOC?=
 =?us-ascii?Q?SDqmqgAO0t8GZcvVJlx7iRNQDaIhCsHpgwI9R40X32mVwxP4aTiXZFGegIe9?=
 =?us-ascii?Q?bABBWHozNCfcjgsnFfk54xnlAry/cVxwxVtXqQbLhjpD2511lU9wnMUFr21h?=
 =?us-ascii?Q?BSl2Q6rxgI1hsqRu0Xlgj1XY2D16gnX1ZjYYq98SK4/uMrfH5kCehAmaHPbK?=
 =?us-ascii?Q?ulmJ0jVuASa+ylicKxrv3qTBm+FmuzeBrnM2wzoJKQ+P5Xui7VIC6Fb1FLYp?=
 =?us-ascii?Q?soz8RR/9Ob487wAntq1ZoFWBc/7SKtXcu2oRxK6UISZanzzB1BL1LYLMPqtN?=
 =?us-ascii?Q?qzuQlpi6e6q0E4jcVnXABLCtHDjBo6tX0lvQn16Q8Q6iJwFdu3Pcn42bR3sm?=
 =?us-ascii?Q?AnnMNNbeiWxZXT6U/wGgfWlsPUyzJKwq5FuiEPO3tJNnjENgHmRHgyixpSas?=
 =?us-ascii?Q?VHBzlLJTIqqFQrKbHSg=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0af3f5f0-9c4e-4120-7326-08dab11c096c
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 15:18:40.2274
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2X5uDXBL2hxUM54/8cNoYXpEEonqJmHvIaFDT8UI5wqq72tJAbui8gHXlRED5DlL
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5906
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Oct 18, 2022 at 04:51:30PM +0200, Niklas Schnelle wrote:

> @@ -84,7 +88,7 @@ static void __s390_iommu_detach_device(struct zpci_dev *zdev)
>  		return;
>  
>  	spin_lock_irqsave(&s390_domain->list_lock, flags);
> -	list_del_init(&zdev->iommu_list);
> +	list_del_rcu(&zdev->iommu_list);
>  	spin_unlock_irqrestore(&s390_domain->list_lock, flags);

This doesn't seem obviously OK, the next steps remove the translation
while we can still have concurrent RCU protected flushes going on.

Is it OK to call the flushes when after the zpci_dma_exit_device()/etc?

Jason