Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Oct 2022 00:31:34 +0900
From:   Masami Hiramatsu (Google) <mhiramat@kernel.org>
To:     Zheng Yejian <zhengyejian1@huawei.com>
Cc:     <rostedt@goodmis.org>, <corbet@lwn.net>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <tom.zanussi@linux.intel.com>
Subject: Re: [PATCH -next] tracing/histogram: Update document for KEYS_MAX
 size
Message-Id: <20221019003134.cc24bd624cc6fca06a05206c@kernel.org>
In-Reply-To: <20221017103806.2479139-1-zhengyejian1@huawei.com>
References: <20221017103806.2479139-1-zhengyejian1@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 17 Oct 2022 10:38:06 +0000
Zheng Yejian <zhengyejian1@huawei.com> wrote:

> After commit 4f36c2d85ced ("tracing: Increase tracing map KEYS_MAX size"),
> 'keys' supports up to three fields.

This looks good to me.

Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Steve, do you this this document fix should go into the stable trees?

Thank you,

> 
> Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
> ---
>  Documentation/trace/histogram.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/trace/histogram.rst b/Documentation/trace/histogram.rst
> index c1b685a38f6b..87bd772836c0 100644
> --- a/Documentation/trace/histogram.rst
> +++ b/Documentation/trace/histogram.rst
> @@ -39,7 +39,7 @@ Documentation written by Tom Zanussi
>    will use the event's kernel stacktrace as the key.  The keywords
>    'keys' or 'key' can be used to specify keys, and the keywords
>    'values', 'vals', or 'val' can be used to specify values.  Compound
> -  keys consisting of up to two fields can be specified by the 'keys'
> +  keys consisting of up to three fields can be specified by the 'keys'
>    keyword.  Hashing a compound key produces a unique entry in the
>    table for each unique combination of component keys, and can be
>    useful for providing more fine-grained summaries of event data.
> -- 
> 2.25.1
> 


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>