Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Message-ID: <trinity-8fe25643-9cf4-4f09-bebb-208570a540d4-1666107900051@3c-app-gmx-bap38>
From:   Frank Wunderlich <frank-w@public-files.de>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Frank Wunderlich <linux@fw-web.de>,
        linux-mediatek@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Aw: Re: [RFC v1 02/12] dt-bindings: PCI: mediatek-gen3: add support
 for mt7986
Content-Type: text/plain; charset=UTF-8
Date:   Tue, 18 Oct 2022 17:45:00 +0200
Importance: normal
Sensitivity: Normal
In-Reply-To: <684c5659-0691-6534-1602-6c0a53e6e503@linaro.org>
References: <20221017104141.7338-1-linux@fw-web.de>
 <20221017104141.7338-3-linux@fw-web.de>
 <684c5659-0691-6534-1602-6c0a53e6e503@linaro.org>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

> Gesendet: Dienstag, 18. Oktober 2022 um 17:35 Uhr
> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
> On 17/10/2022 06:41, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files.de>

> Maybe the clock is not required on mt7986?

yes, mt7986 does not have all clocks currently defined in binding for gen3=
-pcie (currently mt8xxx)

the mapping is as followed:

CLK_INFRA_IPCIER_CK: peri_26m
CLK_INFRA_IPCIEB_CK: top_133m
CLK_INFRA_IPCIE_CK: pcie working clock from SoC, in MT7986 it is equal to =
tl_26m + tl_96m + tl_32k in MT8192
CLK_INFRA_PCIE_SEL: clock mux to select source clock to CLK_INFRA_IPCIE_CK
CLK_INFRA_IPCIE_PIPE_CK : pcie working clock from PHY, pl_250m

as far as i see the driver only enables the clocks in bulk (no access to t=
he clock-names), but binding needs the names

got it solved with help from mtk (see my comment on part 7) with filling m=
issing clocks with a fixed-clock-node.
If this is the right way this binding-change is enough ;)

> Anyway, for the bindings:
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

thx

regards Frank