Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Oct 2022 17:19:14 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Kartik <kkartik@nvidia.com>
Cc:     ldewangan@nvidia.com, gregkh@linuxfoundation.org,
        jirislaby@kernel.org, jonathanh@nvidia.com, alan@linux.intel.com,
        swarren@nvidia.com, akhilrajeev@nvidia.com,
        linux-serial@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] serial: tegra: Read DMA status before terminating
Message-ID: <Y07D8qIPJYrwqWPM@orome>
References: <1666105086-17326-1-git-send-email-kkartik@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="IHuIGTSViub8/3Tu"
Content-Disposition: inline
In-Reply-To: <1666105086-17326-1-git-send-email-kkartik@nvidia.com>
User-Agent: Mutt/2.2.7 (2022-08-07)
Precedence: bulk


--IHuIGTSViub8/3Tu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 18, 2022 at 08:28:06PM +0530, Kartik wrote:
> Read the DMA status before terminating the DMA, as doing so deletes
> the DMA desc.
>=20
> Also, to get the correct transfer status information, pause the DMA
> using dmaengine_pause() before reading the DMA status.
>=20
> Fixes: e9ea096dd225 ("serial: tegra: add serial driver")
>=20
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> Signed-off-by: Kartik <kkartik@nvidia.com>
> ---
> v1->v2:
>  * Pause the DMA before reading the DMA status.
>  * Updated commit message.
>=20
>  drivers/tty/serial/serial-tegra.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Seems fine:

Acked-by: Thierry Reding <treding@nvidia.com>

--IHuIGTSViub8/3Tu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmNOw/IACgkQ3SOs138+
s6GgFA//fpcMpjiCNE0bjI9gIWfKnoaHklq0pIKH3JzHH4bXoIEXDzpa4lRECS+O
Vaof0L0kUKBQwjPn87YmWoTc0QGO4YqFSV8OO4eyORk1H7affyY4IxpdcEdKg18y
dUGRLj0mjMNDs/ZZRIkNK6nJMoplMbjBBaDeBiuhQ1ijBJWwm9AuuNzdEzPTXu8p
uF8U9jM7dWBJ82JuasuJXnanT+qhyvPGnda4ABTV3fKgBN5XfwnzKLx1ik5mbGti
LGU65Vm7vokMTrCvWjrnDnMZEGPn8BMJPfrjMhNYWzjnXYM1+vWr1XtpVhOLQoCv
CxQ4A0eEbKb8E28DhUcJn2VFVIhpAEgL+kcDKB0LtrkRSAwwKKgaZKW8chUEl1kN
EuHKlfTnuEYIde0U6jUv9cw1Z3tnmVmcca7Iu9w5tXB8au1LqhxscO5XNotlTnJF
lRuHcGEkjThMET2s9iNrJqhC/fLXidPPuA3lHL8Z6Vp+Bp81cSwKFXbAcp6SEc/H
jent0tT879mWh5cbsHs6oGRP51CRyiNj7q0YddOsEXPgSEu2V447uPTltZlWk6Jl
JP+q1ERq48b7zBkt3jTXxeMYzdcxjWW02QWWtODS+nfANoM+aTy8W6X6NVWAZXY+
prx2rH+b5vL1evw6GamwxFE808z+uXmYBVctt5TH8EUdsOTD410=
=AAlD
-----END PGP SIGNATURE-----

--IHuIGTSViub8/3Tu--