Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <de1957b5-ef9c-1f78-d2e6-b97a6f678b26@benettiengineering.com>
Date:   Tue, 18 Oct 2022 19:29:27 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH 4/5] ARM: dts: imxrt1050: remove mmc max-frequency
 property
To:     Bough Chen <haibo.chen@nxp.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Cc:     Stephen Boyd <sboyd@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>
References: <20221017235602.86250-1-giulio.benetti@benettiengineering.com>
 <20221017235602.86250-4-giulio.benetti@benettiengineering.com>
 <DB7PR04MB40100794ED12BA4224CD6B1B90289@DB7PR04MB4010.eurprd04.prod.outlook.com>
Content-Language: en-US
From:   Giulio Benetti <giulio.benetti@benettiengineering.com>
In-Reply-To: <DB7PR04MB40100794ED12BA4224CD6B1B90289@DB7PR04MB4010.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Haibo,

On 18/10/22 05:01, Bough Chen wrote:
>> -----Original Message-----
>> From: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> Sent: 2022年10月18日 7:56
>> To: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
>> linux-kernel@vger.kernel.org; linux-clk@vger.kernel.org;
>> linux-mmc@vger.kernel.org
>> Cc: Stephen Boyd <sboyd@kernel.org>; Bough Chen <haibo.chen@nxp.com>;
>> Adrian Hunter <adrian.hunter@intel.com>; Ulf Hansson
>> <ulf.hansson@linaro.org>; Giulio Benetti
>> <giulio.benetti@benettiengineering.com>
>> Subject: [PATCH 4/5] ARM: dts: imxrt1050: remove mmc max-frequency
>> property
>>
>> According to i.MXRT1050 Reference Manual usdhc supports up to 208Mhz clock
> 
> Please double check this. As I know, the i.MXRT1050 and i.MX6/7/8/9 series use the same usdhc IP, maybe include some small difference.
> For the usdhc in i.MX6/7/8/9, I confirmed with IC team, the card clock output from usdhc can't be upper than 
200MHz, otherwise maybe meet some stable related issue.

Thanks for poiting, I've double checked and you're right. RM states 
208Mhz but DS states 200Mhz and it makes sense because of HS200.

> So here I think should change to like this:
>   max-frequency = <200000000>;

Ok, I'll send a V2 for this. I wait for other comments on the other 
patches for a bit before.

Best regards
-- 
Giulio Benetti
CEO/CTO@Benetti Engineering sas

> 
> Best Regards
> Haibo Chen
> 
> 
>> so let's remove max-frequency property in the .dtsi base file and in case add
>> that property in the board specific .dts file for a specific device connected to it.
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>>   arch/arm/boot/dts/imxrt1050.dtsi | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/imxrt1050.dtsi
>> b/arch/arm/boot/dts/imxrt1050.dtsi
>> index 114465e4dde6..0b44cc4ce6ad 100644
>> --- a/arch/arm/boot/dts/imxrt1050.dtsi
>> +++ b/arch/arm/boot/dts/imxrt1050.dtsi
>> @@ -93,7 +93,6 @@ usdhc1: mmc@402c0000 {
>>   			bus-width = <4>;
>>   			fsl,wp-controller;
>>   			no-1-8-v;
>> -			max-frequency = <4000000>;
>>   			fsl,tuning-start-tap = <20>;
>>   			fsl,tuning-step = <2>;
>>   			status = "disabled";
>> --
>> 2.34.1
>