Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
Subject: Re: [PATCH] perf: Fix missing raw data on tracepoint events
From:   Athira Rajeev <atrajeev@linux.vnet.ibm.com>
In-Reply-To: <20221012143857.48198-1-james.clark@arm.com>
Date:   Wed, 19 Oct 2022 00:00:35 +0530
Cc:     linux-perf-users@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <D3C85EE7-3545-44C7-B11D-71C1935036C1@linux.vnet.ibm.com>
References: <20221012143857.48198-1-james.clark@arm.com>
To:     James Clark <james.clark@arm.com>
Precedence: bulk


> On 12-Oct-2022, at 8:08 PM, James Clark <james.clark@arm.com> wrote:
>=20
> Since commit 838d9bb62d13 ("perf: Use sample_flags for raw_data")
> raw data is not being output on tracepoints due to the PERF_SAMPLE_RAW
> field not being set. Fix this by setting it for tracepoint events.
>=20
> This fixes the following test failure:
>=20
>  perf test "sched_switch" -vvv
>=20
>   35: Track with sched_switch
>  --- start ---
>  test child forked, pid 1828
>  ...
>  Using CPUID 0x00000000410fd400
>  sched_switch: cpu: 2 prev_tid -14687 next_tid 0
>  sched_switch: cpu: 2 prev_tid -14687 next_tid 0
>  Missing sched_switch events
>  4613 events recorded
>  test child finished with -1
>  ---- end ----
>  Track with sched_switch: FAILED!
>=20
> Fixes: 838d9bb62d13 ("perf: Use sample_flags for raw_data")
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
> Signed-off-by: James Clark <james.clark@arm.com>

Hi James,=20

Thanks for the fix. I was getting similar issue with =E2=80=9Cperf =
trace=E2=80=9D and it works with this fix.

Tested-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>


> ---
> kernel/events/core.c | 1 +
> 1 file changed, 1 insertion(+)
>=20
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index b981b879bcd8..824c23830272 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -9759,6 +9759,7 @@ void perf_tp_event(u16 event_type, u64 count, =
void *record, int entry_size,
>=20
> 	perf_sample_data_init(&data, 0, 0);
> 	data.raw =3D &raw;
> +	data.sample_flags |=3D PERF_SAMPLE_RAW;
>=20
> 	perf_trace_buf_update(record, event_type);
>=20
> --=20
> 2.28.0
>=20