Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933184AbXF2Hk3 (ORCPT ); Fri, 29 Jun 2007 03:40:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752360AbXF2HkH (ORCPT ); Fri, 29 Jun 2007 03:40:07 -0400 Received: from s2.ukfsn.org ([217.158.120.143]:39115 "EHLO mail.ukfsn.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1765160AbXF2HkF (ORCPT ); Fri, 29 Jun 2007 03:40:05 -0400 Message-ID: <4684B750.5030001@dgreaves.com> Date: Fri, 29 Jun 2007 08:40:00 +0100 From: David Greaves User-Agent: Mozilla-Thunderbird 2.0.0.4 (X11/20070618) MIME-Version: 1.0 To: David Chinner Cc: "Rafael J. Wysocki" , Pavel Machek , linux-pm , "'linux-kernel@vger.kernel.org'" , xfs@oss.sgi.com, LinuxRaid , LVM general discussion and development , David Robinson , Oleg Nesterov Subject: Re: [linux-pm] Re: [linux-lvm] 2.6.22-rc4 XFS fails after hibernate/resume References: <46744065.6060605@dgreaves.com> <200706281727.35430.rjw@sisk.pl> <20070628220045.GA4521@elf.ucw.cz> <200706290016.45719.rjw@sisk.pl> <20070629050024.GO31489@sgi.com> In-Reply-To: <20070629050024.GO31489@sgi.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1318 Lines: 32 David Chinner wrote: > On Fri, Jun 29, 2007 at 12:16:44AM +0200, Rafael J. Wysocki wrote: >> There are two solutions possible, IMO. One would be to make these workqueues >> freezable, which is possible, but hacky and Oleg didn't like that very much. >> The second would be to freeze XFS from within the hibernation code path, >> using freeze_bdev(). > > The second is much more likely to work reliably. If freezing the > filesystem leaves something in an inconsistent state, then it's > something I can reproduce and debug without needing to > suspend/resume. > > FWIW, don't forget you need to thaw the filesystem on resume. I've been a little distracted recently - sorry. I'll re-read the thread and see if there are any test actions I need to complete. I do know that the corruption problems I've been having: a) only happen after hibernate/resume b) only ever happen on one of 2 XFS filesystems c) happen even when the script does xfs_freeze;sync;hibernate;xfs_thaw What happens if a filesystem is frozen and I hibernate? Will it be thawed when I resume? David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/