Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp6396520rwi; Tue, 18 Oct 2022 11:50:36 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4tKgupnmor+JH6IyGd21D6ek4KhBeGHHCbath6rqPB7XDZiKK7ysN+DIiIs+USpHh80hVP X-Received: by 2002:a17:906:fe45:b0:791:9624:9ea5 with SMTP id wz5-20020a170906fe4500b0079196249ea5mr3661633ejb.282.1666119036220; Tue, 18 Oct 2022 11:50:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666119036; cv=none; d=google.com; s=arc-20160816; b=QfD0XhQoFaBx6Q52o45M2ewQ6Y6o8ILwM4/iOZ6vIWQByAHejvhAx8wBfgfCljCyQA QytTUPlauksOLrXC6iuQZT6OjQYU4JEyWStwRBoDEfC9flz51oHUhdyuSi8f79gEjPru uRL3uyoXUUlEmYX/3YgKU1z6JRmxmqdWvzFae09c0VoQMgh3/hK+lS5KvIQGadGuVcsJ IT6FpAo3hUKb11DrQojs8ONINduQrRn2Un+h7emG5qF/vd22uOvNAzbF7+f2KNAtSaXM P2nJ+mOHgE5ErzTg4hhU6qZXhJ1ImaEc/XCvFgrvzNvC454/PTCzoTU6CSRpR2kX6hZc aFKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=oQKkyXOOPjqSDRtWFzAzct4kkXQ65v1MkipM5ZQEx00=; b=SzwkOuLd7GWaGa/kAW1U6c2D6TyehSmamy2Lh/O88ItI2LiJKXcW9OA/YeW83K+++B w1mRyVGTn2Y10gINNev3HET/PPo1UGnXHlLMRzY2KSrebGh7i59C7itV6EOiV7QbzKn/ 763QinE6qWbXR/cGZh1eZNY/sdvBF4uJlyt3m++kC50McEn61jZ2qYBAt6BCHXGSb5L3 6VAGKYr7b+X7mUgwFpreICfHKo2ZTMDCXtFNc2fku1E2VI8o7YBXi9j9tQ51Zt/fYXy8 wZJ2XJbZciGZyqiz9ed8aok9oNX3qF8w76A/SxrkZmgyoC+tUHLVBV3CaOewqIgLz1Tx IjhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="BJ/ApFHO"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s16-20020a056402015000b0044f2fb68fe6si10899631edu.495.2022.10.18.11.50.09; Tue, 18 Oct 2022 11:50:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="BJ/ApFHO"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230055AbiJRSbm (ORCPT + 99 others); Tue, 18 Oct 2022 14:31:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229569AbiJRSbk (ORCPT ); Tue, 18 Oct 2022 14:31:40 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92E4F95AF1 for ; Tue, 18 Oct 2022 11:31:35 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id b12so21803524edd.6 for ; Tue, 18 Oct 2022 11:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=oQKkyXOOPjqSDRtWFzAzct4kkXQ65v1MkipM5ZQEx00=; b=BJ/ApFHOjzqdacBawUgooE0L73RGIUjbiem7XKGI2Pt+pMNZ/+V/c/vPELyjpNXHEJ hYfUll6PO1Ym4xEPVxxHz8LeZkApyaLBzMrTcPqlZ3XARjrat1Obh+BjTTlY8s2Ovu4f VmpTg3BM9AcG/Uz9B8IvppL8PG5+5G44fe0uE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oQKkyXOOPjqSDRtWFzAzct4kkXQ65v1MkipM5ZQEx00=; b=nESAFOnXdpK6mf6e2pzyff9r5XnByd6xuZj/5yj3cgOIml9MjfxRCfqu0gPXSmgmyo SNN2FdgygP2z+6JNtMG1ZZorEMRtOpgVGDDHeHWUO9J/yVPtoot+NPUTH5PX2mK1TojK KGF/dusxM6H/34vrsY5EYXRZpS1Jrmo8WQSVc1tCgXiL4ziTLv8JaBlZcHX+0f6aA0D1 0VwOJsLkA/6VB7hDg2EE9+/OYTeDdYENKjktfto6bx/uGM6UOUZn7L0oua5WdOOzC/3P BROdQLnG1sdbUR/e1XMAZRsXHcdEkLCPSnWFnWHlMWIYSsTbNQFjX8LfYOXPYVA5E6o2 UGgw== X-Gm-Message-State: ACrzQf1HlMQeEr+M/7IhXgd9mdJOZCD1VYmqm+Mgrhuq0WZomZ1l51v6 n4N5tu3g3uR7fRfHKaNMl+jI9/qA+FuAS7jzt7ZwFVkBb+x+xn0A X-Received: by 2002:a05:6402:2b85:b0:457:6216:d251 with SMTP id fj5-20020a0564022b8500b004576216d251mr3975159edb.56.1666117893581; Tue, 18 Oct 2022 11:31:33 -0700 (PDT) MIME-Version: 1.0 References: <20221018164532.1705215-1-tommaso.merciai@amarulasolutions.com> <20221018164532.1705215-3-tommaso.merciai@amarulasolutions.com> In-Reply-To: <20221018164532.1705215-3-tommaso.merciai@amarulasolutions.com> From: Michael Nazzareno Trimarchi Date: Tue, 18 Oct 2022 20:31:22 +0200 Message-ID: Subject: Re: [PATCH 2/2] drm/tiny: add support for tft displays based on ilitek,ili9488 To: Tommaso Merciai Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, kamlesh.gurudasani@gmail.com, David Airlie , Daniel Vetter , Maxime Ripard , Thomas Zimmermann , Javier Martinez Canillas , Sam Ravnborg , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On Tue, Oct 18, 2022 at 6:46 PM Tommaso Merciai wrote: > > This adds support for ilitek,ili9488 based displays with shift register > in front of controller. Waveshare,pico-restouch-lcd-3.5 are such displays > > Signed-off-by: Tommaso Merciai > --- Because I start to make it working this driver, I think that my signed-off is missing here > drivers/gpu/drm/tiny/Kconfig | 13 + > drivers/gpu/drm/tiny/Makefile | 1 + > drivers/gpu/drm/tiny/ili9488.c | 440 +++++++++++++++++++++++++++++++++ > 3 files changed, 454 insertions(+) > create mode 100644 drivers/gpu/drm/tiny/ili9488.c > > diff --git a/drivers/gpu/drm/tiny/Kconfig b/drivers/gpu/drm/tiny/Kconfig > index 027cd87c3d0d7..6e708e8414806 100644 > --- a/drivers/gpu/drm/tiny/Kconfig > +++ b/drivers/gpu/drm/tiny/Kconfig > @@ -148,6 +148,19 @@ config TINYDRM_ILI9486 > > If M is selected the module will be called ili9486. > > +config TINYDRM_ILI9488 > + tristate "DRM support for ILI9488 display panels" > + depends on DRM && SPI > + select DRM_KMS_HELPER > + select DRM_GEM_CMA_HELPER > + select DRM_MIPI_DBI > + select BACKLIGHT_CLASS_DEVICE > + help > + DRM driver for the following Ilitek ILI9488 panels: > + * LCD 3.5" 320x480 TFT (Waveshare Pico-ResTouch-LCD-3.5") > + > + If M is selected the module will be called ili9486. > + > config TINYDRM_MI0283QT > tristate "DRM support for MI0283QT" > depends on DRM && SPI > diff --git a/drivers/gpu/drm/tiny/Makefile b/drivers/gpu/drm/tiny/Makefile > index 1d9d6227e7ab7..aad6683b2ac40 100644 > --- a/drivers/gpu/drm/tiny/Makefile > +++ b/drivers/gpu/drm/tiny/Makefile > @@ -11,6 +11,7 @@ obj-$(CONFIG_TINYDRM_ILI9163) += ili9163.o > obj-$(CONFIG_TINYDRM_ILI9225) += ili9225.o > obj-$(CONFIG_TINYDRM_ILI9341) += ili9341.o > obj-$(CONFIG_TINYDRM_ILI9486) += ili9486.o > +obj-$(CONFIG_TINYDRM_ILI9488) += ili9488.o > obj-$(CONFIG_TINYDRM_MI0283QT) += mi0283qt.o > obj-$(CONFIG_TINYDRM_REPAPER) += repaper.o > obj-$(CONFIG_TINYDRM_ST7586) += st7586.o > diff --git a/drivers/gpu/drm/tiny/ili9488.c b/drivers/gpu/drm/tiny/ili9488.c > new file mode 100644 > index 0000000000000..b94d9d4ff4544 > --- /dev/null > +++ b/drivers/gpu/drm/tiny/ili9488.c > @@ -0,0 +1,440 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * DRM driver for Ilitek ILI9488 panels > + * > + * Copyright 2020 Kamlesh Gurudasani > + */ Code was changed a bit so please add copyright of me and you > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include