Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221018013906.3890007-1-qiang1.zhang@intel.com>
 <20221018104533.GC1166572@lothringen> <20221018175034.GU5600@paulmck-ThinkPad-P17-Gen-1>
In-Reply-To: <20221018175034.GU5600@paulmck-ThinkPad-P17-Gen-1>
From:   Joel Fernandes <joel@joelfernandes.org>
Date:   Tue, 18 Oct 2022 15:05:33 -0400
Message-ID: <CAEXW_YSaFKb7uv+wQnfdEEm41tAiXjEb=bge_0AtNFsQ2s-6Ug@mail.gmail.com>
Subject: Re: [PATCH] srcu: Export srcu_check_nmi_safety() to modules
To:     paulmck@kernel.org
Cc:     Frederic Weisbecker <frederic@kernel.org>,
        Zqiang <qiang1.zhang@intel.com>, rcu@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Oct 18, 2022 at 1:50 PM Paul E. McKenney <paulmck@kernel.org> wrote:
>
> On Tue, Oct 18, 2022 at 12:45:33PM +0200, Frederic Weisbecker wrote:
> > On Tue, Oct 18, 2022 at 09:39:06AM +0800, Zqiang wrote:
> > > When enable CONFIG_PROVE_RCU and built modules, the following
> > > error appear:
> > >
> > > ERROR: modpost: "srcu_check_nmi_safety" [kernel/rcu/rcutorture.ko] undefined!
> > > ERROR: modpost: "srcu_check_nmi_safety" [kernel/rcu/rcuscale.ko] undefined!
> > >
> > > This commit fix it by exporting the srcu_check_nmi_safety().
> > >
> > > Signed-off-by: Zqiang <qiang1.zhang@intel.com>
> >
> > Paul, whichever way you prefer, editing the commit or adding this
> > one on top.
> >
> > Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
>
> Thank you all!
>
> This is what I currently have, folded into Frederic's original.
>
> Thoughts?

Looks good to me, has this caught any issues yet?

Thanks.