Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Keller, Jacob E" <jacob.e.keller@intel.com>
To:     "yexingchen116@gmail.com" <yexingchen116@gmail.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
CC:     "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "joe@perches.com" <joe@perches.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        ye xingchen <ye.xingchen@zte.com.cn>
Subject: RE: [PATCH linux-next v2] iavf: Replace __FUNCTION__ with __func__
Thread-Topic: [PATCH linux-next v2] iavf: Replace __FUNCTION__ with __func__
Thread-Index: AQHY4pRmP/aRRZzjzkSYKlQ3Cy9uc64UjpSg
Date:   Tue, 18 Oct 2022 19:43:39 +0000
Message-ID: <CO1PR11MB5089B2FA5C1CB0E2064E4E34D6289@CO1PR11MB5089.namprd11.prod.outlook.com>
References: <20221018015204.371685-1-ye.xingchen@zte.com.cn>
In-Reply-To: <20221018015204.371685-1-ye.xingchen@zte.com.cn>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?94GCX8IxW97hobJ0woEtZDv+k+oQD7ClNf7egPr3BbTJ/UhyWP5AIUlkrbKa?=
 =?us-ascii?Q?l1uniLNNXDbkasgqqWQ8Uvn9R6hEHBu32aHrX+gNDptm03W93XxLGVKN29Uo?=
 =?us-ascii?Q?DvZT7lyDcHVSV487x+nojjTN1038yhBo61wXwFOqB11Mfe93054P4f6xOgjn?=
 =?us-ascii?Q?mFzMyDDMfFqqMxC41k4jTQw3KBELCqO/ns+fgA2sY2UNbO37+Idl+rPKIZSO?=
 =?us-ascii?Q?k0kJUvqDh5i4su/qFsG2Ibz8LfpX2pZ0nT4yKIPCjQ7oCVstB0zMJI95roOY?=
 =?us-ascii?Q?Lc5oleCBibKcfyy3NwmKV0HWAB98R+HVyajM44HVlfsnMJ08hWpnP8zZudsX?=
 =?us-ascii?Q?kbNK3liZhwhZ0lPzxwigjFN7EBDDKa4F6yapf2iyK4t9qK0dVWe81FDsQdGz?=
 =?us-ascii?Q?8+xRFC4ncbhm1fmmA8ZIgdPn961Z8FgbPVJHDzckpc9boHkOjzOIQ2x4jcBG?=
 =?us-ascii?Q?PsiXWk1abj39fBDccQvm4yxc+wMe+rIbQ+jeixxD8yCWUBLp2+sjoTf6ByIh?=
 =?us-ascii?Q?8tV+VabitUig0dVW+yhYPQyFHcs3Gz/bvucSb92iQIhnioGosLvWxiQlqz+m?=
 =?us-ascii?Q?KslbBeprmQ6Dhg2hy1Nz/lzOjIDbRpVnO+HtwVnaSSZj6TzK1N6Ky4X5lvlV?=
 =?us-ascii?Q?Xtcl5Lj2rhjzN33d/EpOdmrAHAvjsK6NqdghMIpPcSIFss+mJMjFwVOkXTab?=
 =?us-ascii?Q?RL5YYBgnwfsZpvQdNQzhp8ab4BbfNd3KT7SNQrSghLWwsOK2Eqy5E79drXUx?=
 =?us-ascii?Q?PC3OSP7/sbcvobYYmUqLdxd/qbcJx2hPW8QRlDLZPti/rJ6oL6u5XxbIzvO1?=
 =?us-ascii?Q?nvrs33aiOjZub8rb4wGOiiz5pmFsCUgLb572egHEAN4fjsBEtDN/5aiCzk/G?=
 =?us-ascii?Q?J1IAHMZ0Q3YAfRp+9tLhbbdyTp+B06bfhrnZ5DusXO88fTllJg0v/GC9nmme?=
 =?us-ascii?Q?nIGLW9jkLltrfBzoniWyQQbgXyliYZo02UgAp5UoImY65MiGCbbFIDF1XHo0?=
 =?us-ascii?Q?E3lN3q2T3dYHeANpUDbe9HL7HZyNCd7rpDxVBdFJvA7r7+2j9S972KbyKe/e?=
 =?us-ascii?Q?2waW4za8pdkDKCuWlnFNhLdxSYT4KA4KWUcZIE6CDb0SWrt7iAj/WlVObmad?=
 =?us-ascii?Q?HbLevFfc0ECuV9EjXGw+KGyr0DQMATr2OpmshDzora5YKy796GUF4uMjfm68?=
 =?us-ascii?Q?+rISMtNprmmXIKvdudy+8xImciEFr+uaVl0baIpahc+AsT8dOVT+oTXUoRNe?=
 =?us-ascii?Q?c/V1xkwSvtRzFnEyLF0BXzxPu6WZaSIK615RJn3ClcWytgcm5PM7n/vLVS+3?=
 =?us-ascii?Q?aRJODNhpUFq1qebkC3RuL/LlysufmTm/sVvpZAyYyoCuMkj5DXQSUpta1W34?=
 =?us-ascii?Q?9eXIfANLvuGs4LLfUoNtn4yhVjOHyhmPT4lkSAIEtwWMQBKWWI3V1aRGMQtP?=
 =?us-ascii?Q?w3XZ9hZ+J1v/EpP+wtovrq67VwDjhDrH4C8EjkQRp7BAlBmPpu0GH+ngMc/i?=
 =?us-ascii?Q?hxiwgE1KIe5/eFER9s2hbXVo+h+6mTNu1FuBzbenxNQtpgzSsVH5GX0zFuqZ?=
 =?us-ascii?Q?J64pwUuo3I3CxfoYhuLRovV4dgQdhg58b0TM7XpC?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0bdb8398-ac66-4041-a1fe-08dab1410dec
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2022 19:43:39.0792
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VC6nQ9V09CTHksJ25cgXYDJo0yZM0I3jpOPGxDE8uwsWngMPcrnk0eKRz3Fee+7rpjm3nvxws5q5EuqSMHCizWltLCiZF28S1MCIinDpQ8M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5162
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: yexingchen116@gmail.com <yexingchen116@gmail.com>
> Sent: Monday, October 17, 2022 6:52 PM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>
> Cc: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; davem@davemloft.net;
> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; Keller, Jacob E
> <jacob.e.keller@intel.com>; joe@perches.com; intel-wired-lan@lists.osuosl=
.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; ye xingchen
> <ye.xingchen@zte.com.cn>
> Subject: [PATCH linux-next v2] iavf: Replace __FUNCTION__ with __func__
>=20
> From: ye xingchen <ye.xingchen@zte.com.cn>
>=20
> __FUNCTION__ exists only for backwards compatibility reasons with old
> gcc versions. Replace it with __func__.
>=20
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>

Thanks for cleaning this up!

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

> ---
> v1 -> v2
> Fix the message up to use ("message in %s\n", __func__)
>  drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index 3fc572341781..efa2692af577 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -4820,7 +4820,7 @@ static void iavf_shutdown(struct pci_dev *pdev)
>  		iavf_close(netdev);
>=20
>  	if (iavf_lock_timeout(&adapter->crit_lock, 5000))
> -		dev_warn(&adapter->pdev->dev, "failed to acquire crit_lock in
> %s\n", __FUNCTION__);
> +		dev_warn(&adapter->pdev->dev, "%s: failed to acquire
> crit_lock\n", __func__);
>  	/* Prevent the watchdog from running. */
>  	iavf_change_state(adapter, __IAVF_REMOVE);
>  	adapter->aq_required =3D 0;
> --
> 2.25.1