Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e07df85d-9b98-75b8-d773-1124278aeb2e@linuxfoundation.org>
Date:   Tue, 18 Oct 2022 14:33:02 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] power: cpupower: utils: Add malloc return value check
Content-Language: en-US
To:     Li kunyu <kunyu@nfschina.com>, shuah@kernel.org
Cc:     trenn@suse.com, ray.huang@amd.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20221014042911.298308-1-kunyu@nfschina.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <20221014042911.298308-1-kunyu@nfschina.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/13/22 22:29, Li kunyu wrote:
> Add the check and judgment statement of malloc return value.
> 
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
>   tools/power/cpupower/utils/helpers/misc.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tools/power/cpupower/utils/helpers/misc.c b/tools/power/cpupower/utils/helpers/misc.c
> index 9547b29254a7..eafdbd6d760c 100644
> --- a/tools/power/cpupower/utils/helpers/misc.c
> +++ b/tools/power/cpupower/utils/helpers/misc.c
> @@ -139,6 +139,8 @@ void print_online_cpus(void)
>   
>   	str_len = online_cpus->size * 5;
>   	online_cpus_str = (void *)malloc(sizeof(char) * str_len);
> +	if (unlikely(!online_cpus_str))
> +		return;

You don't need unlikely here.

>   
>   	if (!bitmask_isallclear(online_cpus)) {
>   		bitmask_displaylist(online_cpus_str, str_len, online_cpus);
> @@ -157,6 +159,8 @@ void print_offline_cpus(void)
>   
>   	str_len = offline_cpus->size * 5;
>   	offline_cpus_str = (void *)malloc(sizeof(char) * str_len);
> +	if (unlikely(!offline_cpus_str))
> +		return;

You don't need unlikely here.

>   
>   	if (!bitmask_isallclear(offline_cpus)) {
>   		bitmask_displaylist(offline_cpus_str, str_len, offline_cpus);

thanks,
-- Shuah