Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221018190541.189780-1-mairacanal@riseup.net> <20221018190541.189780-2-mairacanal@riseup.net>
In-Reply-To: <20221018190541.189780-2-mairacanal@riseup.net>
From:   Daniel Latypov <dlatypov@google.com>
Date:   Tue, 18 Oct 2022 14:12:32 -0700
Message-ID: <CAGS_qxof66Lbthg+bJHGWK2UQzovc4FLYVAHTdHP=QyfBBo6=w@mail.gmail.com>
Subject: Re: [PATCH v6 1/3] kunit: Introduce KUNIT_EXPECT_MEMEQ and
 KUNIT_EXPECT_MEMNEQ macros
To:     =?UTF-8?B?TWHDrXJhIENhbmFs?= <mairacanal@riseup.net>
Cc:     Brendan Higgins <brendanhiggins@google.com>, davidgow@google.com,
        airlied@gmail.com, daniel@ffwll.ch, davem@davemloft.net,
        kuba@kernel.org, jose.exposito89@gmail.com, javierm@redhat.com,
        andrealmeid@riseup.net, melissa.srw@gmail.com,
        siqueirajordao@riseup.net, Isabella Basso <isabbasso@riseup.net>,
        magalilemes00@gmail.com, tales.aparecida@gmail.com,
        linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
        linux-kernel@vger.kernel.org,
        Muhammad Usama Anjum <usama.anjum@collabora.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Oct 18, 2022 at 12:06 PM Ma=C3=ADra Canal <mairacanal@riseup.net> w=
rote:
> diff --git a/include/kunit/test.h b/include/kunit/test.h
> index b1ab6b32216d..cde97dc4eed5 100644
> --- a/include/kunit/test.h
> +++ b/include/kunit/test.h
> @@ -658,6 +658,39 @@ do {                                                =
                              \
>                       ##__VA_ARGS__);                                    =
      \
>  } while (0)
>
> +#define KUNIT_MEM_ASSERTION(test,                                       =
      \
> +                           assert_type,                                 =
      \
> +                           left,                                        =
      \
> +                           op,                                          =
      \
> +                           right,                                       =
      \
> +                           size,                                        =
      \
> +                           fmt,                                         =
      \
> +                           ...)                                         =
      \
> +do {                                                                    =
      \
> +       const void *__left =3D (left);                                   =
        \
> +       const void *__right =3D (right);                                 =
        \
> +       const size_t __size =3D (size);                                  =
        \
> +       static const struct kunit_binary_assert_text __text =3D {        =
        \
> +               .operation =3D #op,                                      =
        \
> +               .left_text =3D #left,                                    =
        \
> +               .right_text =3D #right,                                  =
        \
> +       };                                                               =
      \
> +                                                                        =
      \
> +       if (likely(memcmp(__left, __right, __size) op 0))                =
      \
> +               break;                                                   =
      \
> +                                                                        =
      \
> +       _KUNIT_FAILED(test,                                              =
      \
> +                     assert_type,                                       =
      \
> +                     kunit_mem_assert,                                  =
      \
> +                     kunit_mem_assert_format,                           =
      \
> +                     KUNIT_INIT_MEM_ASSERT_STRUCT(&__text,              =
      \
> +                                                  __left,               =
      \
> +                                                  __right,              =
      \
> +                                                  __size),              =
      \
> +                     fmt,                                               =
      \
> +                     ##__VA_ARGS__);                                    =
      \
> +} while (0)
> +

I think this should have been the only real change we needed to make
(to resolve the merge conflict I created).
Looks good to me. I think this series is still good to go.

Sorry for changing the assertion internals out from under you!

Daniel