Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp153618rwi; Tue, 18 Oct 2022 15:37:50 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7w4nCseh3HVPPmDlOBggxvYjInoFQpSEtXMJWQMxGGik68wGmqBGUXyX5Y29TYqolNHCI9 X-Received: by 2002:a17:907:a429:b0:78d:b6bb:304f with SMTP id sg41-20020a170907a42900b0078db6bb304fmr4185754ejc.497.1666132670368; Tue, 18 Oct 2022 15:37:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666132670; cv=none; d=google.com; s=arc-20160816; b=UjtnRxDCNvGrd2+iL4khGJOkW6HN4E1OSwY7L5L9o2rVBE3Z9MK0XaZG9139GTmYm6 YjFlhDrCXibfxmdrcVi3XuCXLQehdCZhd1rm+tNdYUu2aTN+GX7D5gSpxmawI4VJAyRa rY0w1iIOpCFgbT/SWH8W8Sb0pAGg7JICrElQ5PIDQzYj78Epb2QYP4XSjvMn9i0O7JSR gs7s39PNHSF3LXvCAV3mXrHtI2Ts4yCHRqsNjiYSNyP5WMrPyzN118xrEAxfPNL2RCIo KTLaGc7Ks8yUzGziw3d8ciAjAmvDl5eyMS3m6wF8jM6Ff7Rs4jiV034EJpYZJvR6TTwi 2wHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=Npw9U2c80p06chnkb9rb6oryKUDtS8J9ELZ3fxHXL0Q=; b=u1xOHVn1xXYldMrXky1CLSMUHGPIJeZ80FLCmabw62ThoTlg/hWz5kgZg/w+E/yA+/ nPZR34Ap3gdxxlrps8eRjfQc9IgPM9v0mfHyPgUNKShsoO3546c2IiZXF9Oq8P22UUDJ VvWpayGKe6OZor9M1alvz/6kR+2ttLoslGFtnbW4Q5QJXY3HmAVvQFyb0xyvOrMd1MmR 9ybgJ5oKSzMTCapPoZAdQEg3K+qlG4Hrw81WLPrugXEdpX54t/QmF3m+zZty9j2HSCw0 mkxKsnw2UEPQyb07xMtdyRvZH+YdZgDFlqZoaFWgncDW6Oso84IxPvWev5WHkiNiHhLi zgXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l4-20020a170906938400b0078e03186703si10049746ejx.207.2022.10.18.15.37.24; Tue, 18 Oct 2022 15:37:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229905AbiJRWZ6 (ORCPT + 99 others); Tue, 18 Oct 2022 18:25:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229864AbiJRWZ5 (ORCPT ); Tue, 18 Oct 2022 18:25:57 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A21C6525A; Tue, 18 Oct 2022 15:25:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 19F90B82177; Tue, 18 Oct 2022 22:25:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49C98C433C1; Tue, 18 Oct 2022 22:25:52 +0000 (UTC) Date: Tue, 18 Oct 2022 18:25:53 -0400 From: Steven Rostedt To: Daniel Bristot de Oliveira Cc: linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org, kernel test robot Subject: Re: [PATCH 1/2] rv/dot2c: Make automaton definition static Message-ID: <20221018182553.06f13a50@gandalf.local.home> In-Reply-To: References: X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 Aug 2022 17:20:28 +0200 Daniel Bristot de Oliveira wrote: > Monitor's automata definition is only used locally, so make dot2c generate > a static definition. > > Link: https://lore.kernel.org/all/202208210332.gtHXje45-lkp@intel.com > Link: https://lore.kernel.org/all/202208210358.6HH3OrVs-lkp@intel.com > Somehow this fell through the cracks. Daniel, is there any reason I shouldn't pull this in now? -- Steve > Cc: Steven Rostedt > Fixes: e3c9fc78f096 ("tools/rv: Add dot2c") > Reported-by: kernel test robot > Signed-off-by: Daniel Bristot de Oliveira > --- > tools/verification/dot2/dot2c.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/verification/dot2/dot2c.py b/tools/verification/dot2/dot2c.py > index fa73353f7e56..be8a364a469b 100644 > --- a/tools/verification/dot2/dot2c.py > +++ b/tools/verification/dot2/dot2c.py > @@ -111,7 +111,7 @@ class Dot2c(Automata): > > def format_aut_init_header(self): > buff = [] > - buff.append("struct %s %s = {" % (self.struct_automaton_def, self.var_automaton_def)) > + buff.append("static struct %s %s = {" % (self.struct_automaton_def, self.var_automaton_def)) > return buff > > def __get_string_vector_per_line_content(self, buff):