Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <87h700u2sr.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
Cc:     lgirdwood@gmail.com, broonie@kernel.org, spujar@nvidia.com,
        perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] ASoC: simple-card: Fix up checks for HW param fixups
In-Reply-To: <20221018230409.610538-1-aidanmacdonald.0x0@gmail.com>
References: <20221018230409.610538-1-aidanmacdonald.0x0@gmail.com>
User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0
Content-Type: text/plain; charset=US-ASCII
Date:   Tue, 18 Oct 2022 23:31:32 +0000
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HHnUq/Ff8g9GNB4aOJTAaLc5od4Mfa/vr0tOB2EWgrgdIrNuLxj/B+HePzuG?=
 =?us-ascii?Q?n07i6PN1M1Ova/yoriw8EAXkE3LBgl2cdfWGmciThtl4RzweuixNoCTicqmC?=
 =?us-ascii?Q?caQM0DNf/j9KidzPjt7bEgi/WMNA81mVwQdwMO0y+jv5XX+dc7cb3vkyO9vw?=
 =?us-ascii?Q?xdlP1ygOIiww63m5JrWz+rRjMvklr4FAFV22jSnsGqqwm8HwvLAKgwTeCNnL?=
 =?us-ascii?Q?CuRDR4WDak4Jj0467VmiCLFOV1962gpvoqd0H9gySopv7VgVFjsyzkQnKH95?=
 =?us-ascii?Q?0bFgOZtt9KycAcFeFWnIbwvZUkZZoFdcJqXNl/Eimxr+ZH+80nfcBD2sJf3z?=
 =?us-ascii?Q?q6LbzPUlnr47KZWvi/z8aTYreLHmUPk6V77U5DKUglfXsX5eRiYO/c3LqW+Q?=
 =?us-ascii?Q?iOhwEfBv3l6Lws7rz1+yvMUX7+dz9qlrIq1Inxa/CrfG4CflHTlFRrXHQY2X?=
 =?us-ascii?Q?Qx/Z9fP1ivlOVqwkudpM/Zg5yB/Ac+GjwLqRjG0haZnNoW9QS9ltpX2t7Lq/?=
 =?us-ascii?Q?4eWfuXnCL2OhSc5O1LTJcYvvkeaJ1vfgdI5rTSeY3IDVg8aJ5wrBeiyNs7Sy?=
 =?us-ascii?Q?UA1a5lOyZsJb6EZLEE/ix3Xx50bExtezOxsyRg6u9gX40e3hNryP/S5YhymT?=
 =?us-ascii?Q?EDwGOlHoGuro1X3Z9bVwEv3YRfm303+RdZ7cVGW1O3nkbiktBSwBMJgJwXhA?=
 =?us-ascii?Q?QISisRTjH5mijUy3BLGF+vAIaPsJJeQrmI8n2OIynhw82Y9T83n49ofDhZuW?=
 =?us-ascii?Q?wl0eUgnfjTTXYdozQxYwOjSqxR+01Oq/CKSaDmKhcY11sCgGciNyG+jzIPcL?=
 =?us-ascii?Q?VZ00Ng2p78s3X1STgXIxs9kyFcn7TgCQgywf3f8dvMJo095FgiVqUwwNezUm?=
 =?us-ascii?Q?sAt0e0aPMOQEaUqpw8MqRG2+TVuVVHKkr8M4dwCEGeY1+3wdejk+C165DCMB?=
 =?us-ascii?Q?3R9nd8PdLlxWUSU4L7cz7ynq9Bs8pmcD+NbNtn95RVg+6za5poKyzNU84m+3?=
 =?us-ascii?Q?VOGKX2v8nbMn48x1ebSMn9u7BLICzs2zRxuoODnSUekGsHXeZN74SuWKE7hk?=
 =?us-ascii?Q?vMTncqXuAlYeRL+psnlWISuBsY7oDw+jCTKoc9H0MzOAxawAZSCPgQA+GqAN?=
 =?us-ascii?Q?BVDCRdK6OQXGKewIO6blclqzLqVSbxJDYgIDbkNKqIyDtXuEUd6Q9GCRnzns?=
 =?us-ascii?Q?S0h6e0Q7egfpgoAIrV1mt0wuf4YXTmxkPgnh6jCB82JC+H1cFHnrGqZSUZ70?=
 =?us-ascii?Q?7/SpzEPbF7BHEeulqAJRrx0PFphEEkFqIBHe9wZT5aVEMb43cKh/4GYVmKYq?=
 =?us-ascii?Q?x5SbstL5Z/vWuWY7U5HW9PRuiwc0wLcdvGuQcW0CZbaPuWafvvWtcK6Otpr0?=
 =?us-ascii?Q?ZIJRJA2SUiozOQu3UOcldgpynpwIwttS5Qg9fQ3KHJyeZZXCRGM49Q6soTv7?=
 =?us-ascii?Q?R/TnO4DqelKf1xdH0kXHsqxgPN5hEuLQTCV8bPONiqOsVz/FT7Cx1ExWp4Jr?=
 =?us-ascii?Q?2aQ3gE+SW6uarXCTyNpMdbWXIQx+RX6WZmMOS0Uy4NW3l10UqtshI8x8o3Wv?=
 =?us-ascii?Q?UUItUDX/HGHhbBl0MXAGfYl/KVxI7Hd7muebDF1zaaNlbMUAYA6i97Rb3IsP?=
 =?us-ascii?Q?43657EvMNRabZXBXpBTH0IU=3D?=
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b5d5c6f8-31fb-496c-21ca-08dab160e40f
X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 23:31:32.8940
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mjZeMorZCgaJys/XY1A8YXtM8GmWxZUyP+r1R4HzYxBv9HTGnoYpA+C3nQ80LBL1FM8DKOFv4TMbz8BkFjN6Ee7I7YkQaFboyNgHtYcDY1cg1GggrU22OTQLJOtW9IlW
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB8193
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Aidan

> The "convert-xxx" properties only have an effect for DPCM DAI links.
> A DAI link is only created as DPCM if the device tree requires it;
> part of this involves checking for the use of "convert-xxx" properties.
> 
> When the convert-sample-format property was added, the checks got out
> of sync. A DAI link that specified only convert-sample-format but did
> not pass any of the other DPCM checks would not go into DPCM mode and
> the convert-sample-format property would be silently ignored.
> 
> Fix this by adding a function to do the "convert-xxx" property checks,
> instead of open-coding it in simple-card and audio-graph-card. And add
> "convert-sample-format" to the check function so that DAI links using
> it will be initialized correctly.
> 
> Fixes: 047a05366f4b ("ASoC: simple-card-utils: Fixup DAI sample format")
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
> ---
(snip)
> +bool asoc_simple_convert_is_required(const struct asoc_simple_data *data);

This is not a big deal, but "is_conert_required" is better for me :)

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thank you for your help !!

Best regards
---
Kuninori Morimoto