Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Oct 2022 16:59:03 -0700
From:   Ashok Raj <ashok.raj@intel.com>
To:     "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
CC:     Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, <x86@kernel.org>,
        Kostya Serebryany <kcc@google.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Alexander Potapenko <glider@google.com>,
        Taras Madan <tarasmadan@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        "H . J . Lu" <hjl.tools@gmail.com>,
        Andi Kleen <ak@linux.intel.com>,
        Rick Edgecombe <rick.p.edgecombe@intel.com>,
        "Bharata B Rao" <bharata@amd.com>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>,
        <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCHv10 10/15] x86/mm, iommu/sva: Make LAM and SVM mutually
 exclusive
Message-ID: <Y089x212wn0KMPAx@a4bf019067fa.jf.intel.com>
References: <20221018113358.7833-1-kirill.shutemov@linux.intel.com>
 <20221018113358.7833-11-kirill.shutemov@linux.intel.com>
 <Y08HgXqvNSpTUgWe@a4bf019067fa.jf.intel.com>
 <20221018223537.7bmhuknclkboqgnk@box.shutemov.name>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221018223537.7bmhuknclkboqgnk@box.shutemov.name>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eWWovijoMXOh3fVITmfhVGAP0pb5AvHbLJjuqWQOaK+0qbWZsM9S9qM6hp0D?=
 =?us-ascii?Q?ZCEvddkKDZakKKiZBE0yAVm6XrsByZW+zDhk6za71V0x84Rcrakij+JCAeKO?=
 =?us-ascii?Q?CJnbzGuuejbo69GDtr5f8O+NEaGAMHVwur7RskfSR5wIumkDtxQxyPeT2rf9?=
 =?us-ascii?Q?kq1BrxATZz+CBCaR6FPwhDt4G88hiBA5HC1O4ErSqamgOuBlbZ/FC5aQNEXH?=
 =?us-ascii?Q?VVkBiK4FjjcqYW9tGv7ua/+Us7bZQNEkbpjGfreTu07uaMoNl6J9E7A0IKST?=
 =?us-ascii?Q?LVyVEB5e+471bI6iii+e44pYXx9DAtxl/dfdy40B32cVKjXbQNbKgK8rYdBL?=
 =?us-ascii?Q?T08RCcVqxWay4jC0ZDtvpXMI7/YU7CvBMxwT2ERNUflPq+WaVSKMawlj6Rtq?=
 =?us-ascii?Q?c8wguN7q5wwBXa8Wn7arCXMZP5cJ072jZgYhvY0MPe7H6Kaxb0fX9uQ1ZZT7?=
 =?us-ascii?Q?sLUZ2izsLjxQvRNtv3vIcm1yj4HX17Okh3b7nr2MYGAP/SRf9VVqg3sD1uFd?=
 =?us-ascii?Q?GZHGc8MxiImGzyg+EWJIPSae5eKYLegYEOf6vHmyFbL4hD6bIOXVI+QQTOfj?=
 =?us-ascii?Q?AhmfPx3AJX83yHh7H3P/UWc0AX8wGXJgV4C4XLyHrWaczzM+2NjcxBxMKAxU?=
 =?us-ascii?Q?0KMc1OzPdfuRrHlXbwC6j5a5XUMdjhTTWEH4URRN4Ms16DUzfogl45L1hp4S?=
 =?us-ascii?Q?50gWlVnfheXJG1BOvBgJ5G51LwamCcLH2+tVDAkgI9dlNSFLioHlJAH2zvqx?=
 =?us-ascii?Q?D036EASP4JgTtY2OwTYY8Yus7kQUet8xPxmmfnSk4hi9kiQYph6lytwv34IU?=
 =?us-ascii?Q?wqpZBPFPAwNHvxAmnEdo5HJd8XrERvGdwrouAy0i9sxmBdyY3z2Th8hoq86I?=
 =?us-ascii?Q?2dBjEDdpgnJ2BU5F8LdhliQxVRqPF17Qz96ht4ss9ij8e3myEltkYNs9tkuZ?=
 =?us-ascii?Q?sJVVVhY9fM0jOiwxcbDi1h+DUB1yNXVBGSRkfjZP5OoG2ciNwMNd/WY8W32Z?=
 =?us-ascii?Q?nmYmBRH/xFrSWN1E5hZOZA3WqMMM2u24tOF2McgPmDlZqjYR8n+jjr3y560r?=
 =?us-ascii?Q?nZ3WSf+bV1nYsutC39zorHKeR6Yim9cK3oLjv9fIWyNSGqXyaN494rSYCGMT?=
 =?us-ascii?Q?1Q37m4AtEuoXQ65SV7owBrKOxhZNrCtdMu0qNoP7TEQ15K6gn/J/sLRR24De?=
 =?us-ascii?Q?QbxOMXzw52d4eyRtOyelOiJU+v96O+D6wnsaCXuNyetBtR8D1SZNd5ZjTXVq?=
 =?us-ascii?Q?5zBNfiaglSwfSxYCIe9oJi4qA06SdndzimNV8pjsftqBOs6zZrOkxMIvgbdk?=
 =?us-ascii?Q?9H5DZWVGA4dzlKSm0NXIdKEkav/9YB4m0xP+5TybRIHbdnIsDYZyk82dRhmr?=
 =?us-ascii?Q?mLqxJzdmRh1uTASRB/DDnvFUBN/JoFK8MOOWWrRFyeIf0OEv0Dt5hBwRhHj5?=
 =?us-ascii?Q?GOxrRXz7rlGtRZj24anhz6WXrCwYv2FHwpPn3BvveqjxIVt4mG55itlqMhwT?=
 =?us-ascii?Q?G4Nr9ZMU/xaVVU4MzV0FCrHppoYI5yiRJrJvkqRi3uonwrblz8VOMB1tLT6G?=
 =?us-ascii?Q?V1Iz2HoW9xlTtubUv+xoEzzjLuKj/1M3JS3NXyX8kAEZT6SGV5kaPejNztRM?=
 =?us-ascii?Q?CQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d562536-b0b4-45b3-8e95-08dab164bfbd
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 23:59:09.9001
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9VLfu1Q+CeqjLIrhbYM/gVO3sOkXaqaKTetLHCd3ySRkJsX/8XZ0xBH9rJWZ/UyecaouKAMHKHilF3kDleapLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5298
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 19, 2022 at 01:35:37AM +0300, Kirill A. Shutemov wrote:
> > >  
> > >  /* Uprobes on this MM assume 32-bit code */
> > > -#define MM_CONTEXT_UPROBE_IA32	BIT(0)
> > > +#define MM_CONTEXT_UPROBE_IA32		BIT(0)
> > >  /* vsyscall page is accessible on this MM */
> > > -#define MM_CONTEXT_HAS_VSYSCALL	BIT(1)
> > > +#define MM_CONTEXT_HAS_VSYSCALL		BIT(1)
> > 
> > Nit: Looks like the two above format changes got in here :-)
> 
> That's side effect of keeping the new longer flag aligned to the rest.
> 
> A separate patch looks like an overkill, no?

Agree, just thought i'll flag it, but I don't think a new patch is
required.