Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20221018230409.610538-1-aidanmacdonald.0x0@gmail.com>
 <87h700u2sr.wl-kuninori.morimoto.gx@renesas.com>
From:   Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
To:     Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc:     lgirdwood@gmail.com, broonie@kernel.org, spujar@nvidia.com,
        perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] ASoC: simple-card: Fix up checks for HW param fixups
Date:   Wed, 19 Oct 2022 02:19:37 +0100
In-reply-to: <87h700u2sr.wl-kuninori.morimoto.gx@renesas.com>
Message-ID: <xqJhkVSkypEjXLHM2nTiM6gHnxhl1J2B@localhost>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> writes:

> Hi Aidan
>
>> The "convert-xxx" properties only have an effect for DPCM DAI links.
>> A DAI link is only created as DPCM if the device tree requires it;
>> part of this involves checking for the use of "convert-xxx" properties.
>>
>> When the convert-sample-format property was added, the checks got out
>> of sync. A DAI link that specified only convert-sample-format but did
>> not pass any of the other DPCM checks would not go into DPCM mode and
>> the convert-sample-format property would be silently ignored.
>>
>> Fix this by adding a function to do the "convert-xxx" property checks,
>> instead of open-coding it in simple-card and audio-graph-card. And add
>> "convert-sample-format" to the check function so that DAI links using
>> it will be initialized correctly.
>>
>> Fixes: 047a05366f4b ("ASoC: simple-card-utils: Fixup DAI sample format")
>> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
>> ---
> (snip)
>> +bool asoc_simple_convert_is_required(const struct asoc_simple_data *data);
>
> This is not a big deal, but "is_conert_required" is better for me :)
>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Thank you for your help !!
>
> Best regards
> ---
> Kuninori Morimoto

That sounds better, thanks. I'm sending patch v2 now.
- Aidan