Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp387959rwi;
        Tue, 18 Oct 2022 19:45:40 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM55Dz3ZLvFfnaMMyouxxmXT/9mvIgJt3fVtnjy3l0u9/nIwWfQxlVYnemVQ57m+d7wY1K9U
X-Received: by 2002:a17:903:2144:b0:182:42ce:5778 with SMTP id s4-20020a170903214400b0018242ce5778mr5997487ple.46.1666147529777;
        Tue, 18 Oct 2022 19:45:29 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1666147529; cv=none;
        d=google.com; s=arc-20160816;
        b=H4rOzhlh9OeJb5si6LztYwkdskx9b7iLdvL+k3D/0hHb6QpbULm8geR4qzpm9sNUuJ
         wrnF5BCTp1mO1sPfXQjr87IvsMcjCF9SPRRhPXdsa0nawRZfIJb6tCYr/VjX2rhJ/Jpa
         buYShoO0fWYV++It+odqOlaTLcl2qifnaR+UUmGlnJQOSFPbpUKd+N+pVpfUMNUEsWYZ
         AcDRmQaHnNfc9NMcLK7mFfp56Fd1JL+Lb5XR6ij7gtWPwGMS9rpg/MJr2s4guN7UTVRX
         W7ulC4yp7M4tNOKvJLwFfDrrhZWPngIg1KqNday5ia9Oto09q/BMa2nN7KNvhXwIPDVA
         HE5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=ngJbHNr74JMBOGG/PBMc1tgv8pg02VS0s/AhpqV2kkA=;
        b=AKI0zutDqBIqi1UpgXbtw5iXmUn0rmCd1pI9yj48DFWZujJDKLAizBweJkjQAOaU/R
         0t0Gg1/2Fve9Fi99MusvCDfRjIrfurlSPiVYkRJnPlfSVK1pA2GK5/VoGhBeGPLbFKo4
         IPOSCREVd1PpNSGRQHkSbNxtKqhmQPRJSfqZg4yx+jt7U4W3jI2KGhETJgug4Z/6MQwE
         D8ukyEv9a0WrfxyNj72uMVlDnfTMtFgOyfb2bBOfneycI+KTFoxB2NKMOSXpsM59tLl4
         mAp4upiX5gVlLNyXsf5/n1awvQ6Rf/5T1DR0LzntljJu46O8KZyQmQmDJDBfHo/rnKSL
         dyyg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Nq2rbg4n;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id z10-20020a63c04a000000b0044ed36e4c57si17502067pgi.217.2022.10.18.19.45.16;
        Tue, 18 Oct 2022 19:45:29 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Nq2rbg4n;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229930AbiJSC3R (ORCPT <rfc822;artur.folwarczny@gmail.com>
        + 99 others); Tue, 18 Oct 2022 22:29:17 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46076 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229508AbiJSC3O (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 18 Oct 2022 22:29:14 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E2F66D9F7;
        Tue, 18 Oct 2022 19:29:07 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id DC9BB61757;
        Wed, 19 Oct 2022 02:29:06 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id DBC34C433D6;
        Wed, 19 Oct 2022 02:29:05 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1666146546;
        bh=XaMinZPA6FphhuKxsMEDvnDI0O6vGbqFBXSn9EvEMzo=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=Nq2rbg4nhr2EYB4wSOHKcIRTCvJogAODraO/mzJKBbb0Pj+ddVdp9d784KG9KO4IN
         v8yveHyKHgh8AWMBY8C04GGQAx5luw2+ypUoz4kTiS34UNjCT0HqYeL9dRHQTdENzX
         sMzyuHdq73VYmiPiKBEw4ojPXcAAMpYJeYOhlanhpOHT75qv4EB+Fuo0g7NtHxNuR2
         KvYE5uUJk1tGLDCWOVLH1kEWf+wChQGsRlpqQrUkNnVbhgvkkj/wkCAUj1nMFKZYCQ
         DcNN+BMJcZhV4pUWRZI2pcoclaBzF79mGbxEjBUhUpim9+aYGcGpF1vycaFdcqwEpT
         iV1ttqJkS0mHg==
Date:   Tue, 18 Oct 2022 19:29:04 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Doug Berger <opendmb@gmail.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: bcmgenet: add RX_CLS_LOC_ANY support
Message-ID: <20221018192904.4beb2f41@kernel.org>
In-Reply-To: <20221017213237.814861-1-opendmb@gmail.com>
References: <20221017213237.814861-1-opendmb@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 17 Oct 2022 14:32:37 -0700 Doug Berger wrote:
> +	__u32 tmp;

nit: please name this more appropriately and use normal u32 or unsigned
int type, __u* types are for uAPI definitions only.