Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Oct 2022 19:58:49 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Zhao Liu <zhao1.liu@linux.intel.com>
CC:     "K . Y . Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        "H . Peter Anvin" <hpa@zytor.com>, <linux-hyperv@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        "Fabio M . De Francesco" <fmdefrancesco@gmail.com>,
        Zhenyu Wang <zhenyu.z.wang@intel.com>,
        Zhao Liu <zhao1.liu@intel.com>
Subject: Re: [PATCH] x86/hyperv: Remove BUG_ON() for kmap_local_page()
Message-ID: <Y09n6dRN+zxsaLW/@iweiny-desk3>
References: <20221018162117.2332508-1-zhao1.liu@linux.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221018162117.2332508-1-zhao1.liu@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?a6KO8pVUVDsfBYsHwFHhEEZMndOt6tnqVI1VKoju6eYlk7lQcJrvRjx9wVXL?=
 =?us-ascii?Q?2FKSnHJy/dpFmIPuMovR555dGgpvF0BBno7k3U2FdZJTjNf/KR4yJAfdrQzH?=
 =?us-ascii?Q?ogJOh8t6acSMz3JLnV06oeI4fRuEFA2uGqrqbv0k5t0YxB9h1TBIJMvp7HiV?=
 =?us-ascii?Q?CgPZZDe6oNrxC/4gtJJhwuRx4TIJEgjx+B5zHnK9Al0p6pvYP8z2EM64csRB?=
 =?us-ascii?Q?PP/m/IriotbHQeleGDIZmRw8Nq5WyDk9is7axWBMwH5Qbj6Ryn3gna8yMkjP?=
 =?us-ascii?Q?lquSuUBrnijvRJnW2v3B+8//yPBUEzfiykTjdtGq0VWd8/7DES1hgsM2xq1Q?=
 =?us-ascii?Q?J1jYVair1GVlQlH+NIQw/FiMy3ns4Qj763REI8Ovg7hPhzQFueAO3kW1uuCm?=
 =?us-ascii?Q?15s1konPgsWmcH+rMu5QCeWoXd3LtzheAku2qYK6kG5UVPBUMGyDPwtbqgDW?=
 =?us-ascii?Q?bGqDVacYw12EKPOUU9z8nAUXoP6a89vPnY5fekYuDTTeJsKYlFP+C6eQ0KRS?=
 =?us-ascii?Q?knl6GgGYDTicvSqqDzcE7aShxYda00/TJU49hiuxI1IQFeVncy8yaNnESC+r?=
 =?us-ascii?Q?qpXSm/aLUe6F86VkyOTdspgu6aNYUx09TEZFAPXhpZXoxNsBUt8kVTW8uUTl?=
 =?us-ascii?Q?z5KnoQIaHF9lFE1iaBXz0ExKzenWhPhSAO1JLvVJCIDkBW246v1KZrsW8kJN?=
 =?us-ascii?Q?OhLHFD1eIK/DwMF4NCBIPHyeC30CNzrQllIteoLcPPH3J3xafohqfMV2TSIx?=
 =?us-ascii?Q?XGG3mZfnY6iRebGcTu8f4UPvJMt4Bg+0G49veLXzycPmwiJU6l+iedpxf9vk?=
 =?us-ascii?Q?TZ4DWVuIFxLU96ZOfE/as9NYrju8e8t0l6Haec5HA8GUhCPOdyGrlZVHr3K+?=
 =?us-ascii?Q?dM1ETYaaGad9vw8W5S9io1n7GTrJgHv2MOkT0HNN4KaS7thyTRFH/OLkL8tj?=
 =?us-ascii?Q?eZOmUqUmbqz/rXxq3PaMHMA7kzjYgZfNV7j5JRhtfAnwL20E72FYFvz89COu?=
 =?us-ascii?Q?1934/Oga1DzOUWWaE1iWTnqjh3fB4gjDnUpjkRJ5j4x+/U9aZgkIEKzbre2g?=
 =?us-ascii?Q?lVNXawGJOqdMilF6R0KT3mOY7L9QMeQs5XISvZSRcyq1JrH9B9XDB4wLHMUF?=
 =?us-ascii?Q?sUOwvAjlguu9vZkMN9S/DomqRFhMz3B4OfYLrEnAWivXkZyt9WUt7lFsP+ow?=
 =?us-ascii?Q?Jwbn0fW79jyurKlqVyfXhXcwJ/wcZojzbOYWvXezl4dBIunpmToku2MEGnLQ?=
 =?us-ascii?Q?YXh6j2d2ftcoAtmIgjN0XNEAvARs85bpjYRajvGVaYieD8gAjJ9/9xqQ9a5i?=
 =?us-ascii?Q?eoLFv5pwLv2C+i47l3WgGI3GdQdfr0vzxCLJ4cyhx9pkUmwmMqxs6YLnt1om?=
 =?us-ascii?Q?LrDU6HdZ0jRf28gHl3QJYYlXpIg1WSWjXJyMYR9R5s1hhyD9wKpdoebgY6nr?=
 =?us-ascii?Q?0lE4BvVV8EOXns4ZLXLLYfQUEBroja1HODX/v9jJVxUroumsov/MIXFfxVF2?=
 =?us-ascii?Q?/tVo2DVyQ+qLCH00+xhHnMPG689RNJsT466N7KcVed7IoBcUnllz577sDyaW?=
 =?us-ascii?Q?MmzLOMwxFTVsD+3/36H76T/g5sZz+38mV3n12+i8?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 74c9b97e-9057-427f-9523-08dab17ddb96
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 02:58:54.2097
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JoGIIeU0uwuEqPpWXB1CjMftcEHVgY64cBxZQJ3tlP/Jm2Aa51wu2gxNB6KmOPWxzKON1K1lrDwx3RsjXqJHQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6811
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 19, 2022 at 12:21:17AM +0800, Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
> 
> The commit 154fb14df7a3c ("x86/hyperv: Replace kmap() with
> kmap_local_page()") keeps the BUG_ON() to check if kmap_local_page()
> fails.
> 
> But in fact, kmap_local_page() always returns a valid kernel address
> and won't return NULL here. It will BUG on its own if it fails. [1]
> 
> So directly use memcpy_to_page() which creates local mapping to copy.
> 
> [1]: https://lore.kernel.org/lkml/YztFEyUA48et0yTt@iweiny-mobl/
> 
> Fixes: 154fb14df7a3 ("x86/hyperv: Replace kmap() with kmap_local_page()")

I don't know that a fixes is required here.  We are not looking to backport any
of this and the other patch was correct.  This is just a follow on cleanup.

> Suggested-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> Suggested-by: Ira Weiny <ira.weiny@intel.com>

Code looks good.  Without the fixes.

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
>  arch/x86/hyperv/hv_init.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c
> index 29774126e931..f66c5709324f 100644
> --- a/arch/x86/hyperv/hv_init.c
> +++ b/arch/x86/hyperv/hv_init.c
> @@ -459,13 +459,11 @@ void __init hyperv_init(void)
>  		wrmsrl(HV_X64_MSR_HYPERCALL, hypercall_msr.as_uint64);
>  
>  		pg = vmalloc_to_page(hv_hypercall_pg);
> -		dst = kmap_local_page(pg);
>  		src = memremap(hypercall_msr.guest_physical_address << PAGE_SHIFT, PAGE_SIZE,
>  				MEMREMAP_WB);
> -		BUG_ON(!(src && dst));
> -		memcpy(dst, src, HV_HYP_PAGE_SIZE);
> +		BUG_ON(!src);
> +		memcpy_to_page(pg, 0, src, HV_HYP_PAGE_SIZE);
>  		memunmap(src);
> -		kunmap_local(dst);
>  	} else {
>  		hypercall_msr.guest_physical_address = vmalloc_to_pfn(hv_hypercall_pg);
>  		wrmsrl(HV_X64_MSR_HYPERCALL, hypercall_msr.as_uint64);
> -- 
> 2.34.1
>