Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH V3 1/2] dt-bindings: firmware: qcom-scm: Add optional
 interrupt
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <andersson@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <robh+dt@kernel.org>
CC:     <agross@kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <konrad.dybcio@somainline.org>, <robimarko@gmail.com>,
        <quic_gurus@quicinc.com>, <quic_rjendra@quicinc.com>
References: <1666086406-5452-1-git-send-email-quic_sibis@quicinc.com>
 <1666086406-5452-2-git-send-email-quic_sibis@quicinc.com>
 <12d79669-6e8c-6cf8-2e32-d4e0e2e42f3d@linaro.org>
From:   Sibi Sankar <quic_sibis@quicinc.com>
Message-ID: <2464d90f-64e9-5e3c-404b-10394c3bc302@quicinc.com>
Date:   Wed, 19 Oct 2022 11:44:23 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <12d79669-6e8c-6cf8-2e32-d4e0e2e42f3d@linaro.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hey Krzysztof,
Thanks for taking time to review the series.

On 10/18/22 10:41 PM, Krzysztof Kozlowski wrote:
> On 18/10/2022 05:46, Sibi Sankar wrote:
>> From: Guru Das Srinagesh <quic_gurus@quicinc.com>
>>
>> Add an interrupt specification to the bindings to support the wait-queue
>> feature.
>>
>> Signed-off-by: Guru Das Srinagesh <quic_gurus@quicinc.com>
>> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
>> ---
>>
>> The interrupt property for scm firmware from a binding perspective is
>> completely optional i.e. not all tz fw running in the wild on sm8450
>> devices support this feature. The bootloader does the interrupt property
>> addition on sm8450 devices with wait-queue support.
>>
>>   Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> index c5b76c9f7ad0..6483d76b2371 100644
>> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> @@ -71,6 +71,11 @@ properties:
>>     '#reset-cells':
>>       const: 1
>>   
>> +  interrupts:
>> +    description:
>> +      The wait-queue interrupt that firmware raises as part of handshake
>> +      protocol to handle sleeping SCM calls.
> 
> You still miss here constraints... nothing improved. Just look at other
> properties in this file.
> 
> maxItems:1
> 

Ack. Missed adding it in the re-spin.

-Sibi

> Best regards,
> Krzysztof
>